abogical (Abdel-Rahman Abdel-Rahman)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 16 2018, 1:57 AM (129 w, 20 h)
Availability
Available

Recent Activity

May 7 2020

abogical committed R224:d73bcdb00e00: Unmute audio when volume changes (authored by abogical).
Unmute audio when volume changes
May 7 2020, 11:20 AM

Apr 28 2020

abogical committed R225:decb179bad07: Fix typo (authored by abogical).
Fix typo
Apr 28 2020, 10:44 PM

Apr 9 2020

abogical updated the diff for D28550: Optimize Firefox bookmark import query and fix to include folders.

Improve query filter

Apr 9 2020, 3:07 AM · Falkon

Apr 7 2020

abogical placed T11015: Support dual SIM SMS up for grabs.

MR's have been merged. I'm not doing the device combobox for now.

Apr 7 2020, 9:53 PM · KDE Connect
abogical updated subscribers of D28550: Optimize Firefox bookmark import query and fix to include folders.

@drosca @dfaure @SGOrava
Do I need to add subscribers other than falkon? I have 3 other differentials that needs review but no response is made for some time, unless I mention by name.

Apr 7 2020, 9:50 PM · Falkon
abogical committed R224:d3062cafd414: Receive SMS subscription ID and reply using it (authored by abogical).
Receive SMS subscription ID and reply using it
Apr 7 2020, 8:41 PM
abogical committed R225:bfbe6b55ecdf: Consider subscription id when sending SMS messages (authored by abogical).
Consider subscription id when sending SMS messages
Apr 7 2020, 8:11 PM

Apr 6 2020

abogical added a comment to T9276: Notify connected devices when about to suspend.

Made MR to complete this task. Awaiting review.
https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/236

Apr 6 2020, 12:45 AM · KDE Connect

Apr 4 2020

abogical claimed T9276: Notify connected devices when about to suspend.
Apr 4 2020, 10:33 PM · KDE Connect
abogical updated the diff for D28550: Optimize Firefox bookmark import query and fix to include folders.

Comment grammar correction

Apr 4 2020, 6:18 AM · Falkon
abogical updated the test plan for D28550: Optimize Firefox bookmark import query and fix to include folders.
Apr 4 2020, 6:16 AM · Falkon
abogical requested review of D28550: Optimize Firefox bookmark import query and fix to include folders.
Apr 4 2020, 6:15 AM · Falkon
abogical requested review of D28549: Describe error when querying Firefox places.sqlite for bookmarks.
Apr 4 2020, 3:07 AM · Falkon

Mar 30 2020

abogical added inline comments to D28240: special character shown in warning dialog.
Mar 30 2020, 7:46 PM · Falkon

Mar 29 2020

abogical added a comment to T11015: Support dual SIM SMS.
Mar 29 2020, 1:19 AM · KDE Connect

Mar 28 2020

abogical updated the diff for D27655: Open all URLs in command line arguments.

Done requested change

Mar 28 2020, 4:45 PM · Falkon

Mar 25 2020

abogical added inline comments to D27655: Open all URLs in command line arguments.
Mar 25 2020, 1:27 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Use qAsConst

Mar 25 2020, 1:23 PM · Falkon

Mar 22 2020

abogical updated the diff for D27655: Open all URLs in command line arguments.

Used range loop as requested.

Mar 22 2020, 9:40 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Using QString reference as requested.

Mar 22 2020, 6:33 PM · Falkon
abogical added inline comments to D27655: Open all URLs in command line arguments.
Mar 22 2020, 6:07 PM · Falkon

Mar 21 2020

abogical added a comment to T11015: Support dual SIM SMS.

Made the relevant MR's to complete this task:
https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/220
https://invent.kde.org/kde/kdeconnect-android/-/merge_requests/135

Mar 21 2020, 3:15 PM · KDE Connect

Mar 17 2020

abogical added a comment to T11015: Support dual SIM SMS.

The mobile app already sends the subscription id of the sms message with commit abcb6cbf332bc8c145c2338ab1bd5d882a4e327d . All that's left is to interpret the new field on the KDE side.

Mar 17 2020, 12:26 AM · KDE Connect

Mar 15 2020

abogical committed R224:0240c43bb505: Make incoming call notification persistent (authored by abogical).
Make incoming call notification persistent
Mar 15 2020, 10:23 PM
abogical claimed T11015: Support dual SIM SMS.

I'll give this task a try. Remove my assignment if I don't complete it within this month.

Mar 15 2020, 1:25 AM · KDE Connect

Mar 14 2020

abogical claimed T11851: Make incoming call notification persistent.
Mar 14 2020, 11:29 PM · KDE Connect

Mar 11 2020

abogical added a comment to T11851: Make incoming call notification persistent.

MR made on GitLab: https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/212

Mar 11 2020, 1:54 PM · KDE Connect

Mar 6 2020

abogical updated the diff for D27655: Open all URLs in command line arguments.

Stylistic fix

Mar 6 2020, 5:34 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Done requested changes.

Mar 6 2020, 5:31 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Popping from QUrl list instead of using an iterator, as requested.

Mar 6 2020, 1:02 PM · Falkon
abogical updated the diff for D27691: Be able to launch a new non-private window from a private window.

Requested changes done.

Mar 6 2020, 12:42 PM · Falkon
abogical added inline comments to D27655: Open all URLs in command line arguments.
Mar 6 2020, 10:56 AM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Requested changes done.

Mar 6 2020, 10:52 AM · Falkon

Mar 5 2020

abogical added a comment to D27691: Be able to launch a new non-private window from a private window.

bump? @drosca

Mar 5 2020, 10:13 PM · Falkon
abogical updated subscribers of D27655: Open all URLs in command line arguments.

bump? @drosca @SGOrava

Mar 5 2020, 10:13 PM · Falkon

Feb 27 2020

abogical updated the diff for D27691: Be able to launch a new non-private window from a private window.

It's not supposed to create a new process, as falkon is designed to be a single process application. Nevertheless, I added a condition to send a new window command if an instance is running. This avoids process creation overhead.

Feb 27 2020, 10:20 PM · Falkon
abogical requested review of D27691: Be able to launch a new non-private window from a private window.
Feb 27 2020, 2:08 AM · Falkon

Feb 25 2020

abogical updated the test plan for D27655: Open all URLs in command line arguments.
Feb 25 2020, 5:39 PM · Falkon
abogical added a comment to D27655: Open all URLs in command line arguments.

In case you're wondering, Yes, I'm interested in becoming a GSoC student. I've contributed to different KDE projects including this year's SoK. However, this is my first patch to Falkon. Once this is done, you can recommend another bug to fix if you prefer.

Feb 25 2020, 4:34 PM · Falkon
abogical updated subscribers of D27655: Open all URLs in command line arguments.
Feb 25 2020, 4:16 PM · Falkon
abogical requested review of D27655: Open all URLs in command line arguments.
Feb 25 2020, 4:13 PM · Falkon

Feb 14 2020

abogical committed R344:b19e057c7bd4: Fix SearchPlaylist creation (authored by abogical).
Fix SearchPlaylist creation
Feb 14 2020, 2:08 AM

Jan 15 2020

abogical committed R344:b5c46ea06790: Add timeout to switching playlists during drag and drop of tracks (authored by abogical).
Add timeout to switching playlists during drag and drop of tracks
Jan 15 2020, 11:01 PM
abogical committed R344:221b10689577: Switch to the playlist when dragging tracks to it. (authored by abogical).
Switch to the playlist when dragging tracks to it.
Jan 15 2020, 11:01 PM

Dec 30 2019

abogical committed R344:50559afaa50d: PlayerManager: Unify volume slots (authored by abogical).
PlayerManager: Unify volume slots
Dec 30 2019, 10:48 PM

Dec 27 2019

abogical committed R344:444a4c9f102d: Save config after it is closed by the window manager (authored by abogical).
Save config after it is closed by the window manager
Dec 27 2019, 12:43 AM

Feb 18 2018

abogical added a comment to D10566: Fictionbook: Add support for code, superscript, & subscript tags.

Full name is 'Abdel-Rahman Abdel-Rahman'. but I just like to hide my last name.

Feb 18 2018, 10:05 PM · Okular
abogical added a comment to D10566: Fictionbook: Add support for code, superscript, & subscript tags.

Name is Abdel-Rahman A.

Feb 18 2018, 10:01 PM · Okular

Feb 16 2018

abogical updated the diff for D10566: Fictionbook: Add support for code, superscript, & subscript tags.

Use QStringLiteral .

Feb 16 2018, 8:52 PM · Okular
abogical updated the diff for D10566: Fictionbook: Add support for code, superscript, & subscript tags.
Feb 16 2018, 8:49 PM · Okular
abogical updated the test plan for D10566: Fictionbook: Add support for code, superscript, & subscript tags.
Feb 16 2018, 12:18 PM · Okular
abogical retitled D10566: Fictionbook: Add support for code, superscript, & subscript tags from Add support for code, superscript, & subscript tags in fictionbook to Fictionbook: Add support for code, superscript, & subscript tags.
Feb 16 2018, 12:14 PM · Okular
abogical retitled D10566: Fictionbook: Add support for code, superscript, & subscript tags from Add support for code tags in fictionbook to Add support for code, superscript, & subscript tags in fictionbook.
Feb 16 2018, 12:05 PM · Okular
abogical updated the diff for D10566: Fictionbook: Add support for code, superscript, & subscript tags.

Added support for superscript and subscript tags, also fixed formatting issues. Just a question, what tools does the KDE developers use for linting the formatting of their code?

Feb 16 2018, 12:04 PM · Okular
abogical requested review of D10566: Fictionbook: Add support for code, superscript, & subscript tags.
Feb 16 2018, 2:08 AM · Okular