Feed Advanced Search

Jul 8 2019

shubham added a project to D22321: Add unit test for Polkit backend: KDE Partition Manager.
Jul 8 2019, 9:31 AM · KDE Partition Manager
shubham requested review of D22321: Add unit test for Polkit backend.
Jul 8 2019, 9:31 AM · KDE Partition Manager
shubham added a comment to D22290: Update stopwatch granularity on change in settings.

There you go, congratulations on your first patch!!

Jul 8 2019, 5:23 AM · Kronometer
shubham closed D22290: Update stopwatch granularity on change in settings.
Jul 8 2019, 5:23 AM · Kronometer
shubham committed R136:70e88b705ebb: Update stopwatch granularity on change in settings (authored by gshah).
Update stopwatch granularity on change in settings
Jul 8 2019, 5:23 AM
shubham committed R136:43ea782724e5: Add .arcconfig file for Kronometer (authored by shubham).
Add .arcconfig file for Kronometer
Jul 8 2019, 5:15 AM
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Authenticate org.kde.kpmcore.externalcommand.init action inside ExternalCommand::startHelper() using Polkit Backend
@stikonas Below error is troubling me for sometime.

Jul 8 2019, 5:01 AM · KDE Partition Manager

Jul 7 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove unneded function

Jul 7 2019, 8:00 AM · KDE Partition Manager

Jul 5 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

More cleanup and remove unneded commented code

Jul 5 2019, 2:59 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Add function to stop action inside the polkit backend

Jul 5 2019, 8:02 AM · KDE Partition Manager

Jun 29 2019

shubham committed R954:47cd9d708e32: Add my blog to Planet kde (authored by shubham).
Add my blog to Planet kde
Jun 29 2019, 3:07 PM

Jun 26 2019

shubham reopened D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 26 2019, 4:38 PM · KDE Partition Manager
shubham committed R16:6e659ac6ac11: [WIP]: Implement PolkitQt1 Authorization backend (authored by shubham).
[WIP]: Implement PolkitQt1 Authorization backend
Jun 26 2019, 4:37 PM
shubham closed D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 26 2019, 4:37 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove Q_PLUGIN_METADATA

Jun 26 2019, 2:07 PM · KDE Partition Manager

Jun 22 2019

shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Properly handle reply from Authentication agent

Jun 22 2019, 5:49 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

More code cleanup.
Remove unnecessary includes.

Jun 22 2019, 5:27 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

some more changes

Jun 22 2019, 9:41 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Remove unneeded functions

Jun 22 2019, 9:36 AM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Lay basic outline of executing and revoking actions from inside ExternalCommand

Jun 22 2019, 9:27 AM · KDE Partition Manager

Jun 21 2019

shubham updated the summary of D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 21 2019, 5:55 PM · KDE Partition Manager
shubham updated the diff for D21970: [WIP]: Implement PolkitQt1 Authorization backend.

Correct documentation error.
@stikonas I will be making more changes to it and will implement those Q_SLOTS soon.
(sendProgressStep())

Jun 21 2019, 5:52 PM · KDE Partition Manager
shubham updated the test plan for D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 21 2019, 5:50 PM · KDE Partition Manager
shubham added a project to D21970: [WIP]: Implement PolkitQt1 Authorization backend: KDE Partition Manager.
Jun 21 2019, 5:50 PM · KDE Partition Manager
shubham requested review of D21970: [WIP]: Implement PolkitQt1 Authorization backend.
Jun 21 2019, 5:48 PM · KDE Partition Manager

Jun 20 2019

shubham updated the diff for D21773: [WIP]: QDBus communication from helper towards Application.

A bit cleanup

Jun 20 2019, 2:00 PM · KDE Partition Manager

Jun 19 2019

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.
Jun 19 2019, 4:41 PM · KDE Partition Manager
shubham abandoned D18563: Don't create directory tree when a new folder has a '/' in the name.
Jun 19 2019, 4:35 PM · Frameworks
shubham abandoned D18599: Use specific error message if file/folder name contains '/'.
Jun 19 2019, 4:34 PM · Frameworks
shubham abandoned D18384: Allow creating directory named '~' and throw a warning before creating it..
Jun 19 2019, 4:34 PM · Frameworks

Jun 16 2019

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Use correct signal

Jun 16 2019, 7:47 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Add documentation

Jun 16 2019, 7:37 PM · KDE Partition Manager

Jun 15 2019

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.
  1. Use synchronous versions of register and unregistering authentication agents
  2. Call authenticationAgentResponseSync() on successfull authentication by the user
Jun 15 2019, 7:13 PM · KDE Partition Manager
shubham added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Jun 15 2019, 6:47 PM · Frameworks

Jun 12 2019

shubham retitled D21773: [WIP]: QDBus communication from helper towards Application from [WIP] :QDBus communication from helper towards Application to [WIP]: QDBus communication from helper towards Application.
Jun 12 2019, 7:57 PM · KDE Partition Manager
shubham updated the summary of D21773: [WIP]: QDBus communication from helper towards Application.
Jun 12 2019, 7:57 PM · KDE Partition Manager
shubham added a project to D21773: [WIP]: QDBus communication from helper towards Application: KDE Partition Manager.
Jun 12 2019, 7:56 PM · KDE Partition Manager
shubham requested review of D21773: [WIP]: QDBus communication from helper towards Application.
Jun 12 2019, 7:56 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Rebase on master

Jun 12 2019, 4:54 PM · KDE Partition Manager
shubham committed R16:6ea88cc737e0: Add QString include (authored by shubham).
Add QString include
Jun 12 2019, 4:48 PM
shubham committed R16:d1a82f65d4e0: Revert "Remove redundant includes and refactor" (authored by shubham).
Revert "Remove redundant includes and refactor"
Jun 12 2019, 4:42 PM
shubham added a reverting change for R16:4229b02fd2fe: Remove redundant includes and refactor: R16:d1a82f65d4e0: Revert "Remove redundant includes and refactor".
Jun 12 2019, 4:42 PM

Jun 10 2019

shubham committed R16:4229b02fd2fe: Remove redundant includes and refactor (authored by shubham).
Remove redundant includes and refactor
Jun 10 2019, 5:37 PM
shubham added inline comments to D10859: Improve layout of annotation configuration dialogs.
Jun 10 2019, 4:54 PM · Okular
shubham added inline comments to D21730: Pass gridLayout pointer to createStyleWidget.
Jun 10 2019, 4:51 PM · Okular
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Add more functions

Jun 10 2019, 4:22 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Do not include PolkitQt5 directories

Jun 10 2019, 2:51 PM · KDE Partition Manager

Jun 9 2019

shubham closed D21696: Create a timer to wait for system to free resources.
Jun 9 2019, 5:11 PM
shubham committed R16:2627d476f4a7: Create a timer to wait for system to free resources (authored by shubham).
Create a timer to wait for system to free resources
Jun 9 2019, 5:11 PM
shubham updated the diff for D21696: Create a timer to wait for system to free resources.

Remove timer from run(), it is being called in start() nonetheless

Jun 9 2019, 5:08 PM
shubham retitled D21696: Create a timer to wait for system to free resources from Create a timer to Create a timer to wait for system to free resources.
Jun 9 2019, 5:00 PM
shubham updated the diff for D21696: Create a timer to wait for system to free resources.

USe new signal slot syntax

Jun 9 2019, 5:00 PM
shubham added a reviewer for D21696: Create a timer to wait for system to free resources: stikonas.
Jun 9 2019, 4:41 PM
shubham requested review of D21696: Create a timer to wait for system to free resources.
Jun 9 2019, 4:40 PM
shubham added a comment to D21692: [DocumentUrlDB] Remove unused 'rename' method.

Does this function had any use when it was first implemented? Or may it come to use later?

Jun 9 2019, 2:31 PM · Baloo, Frameworks

Jun 8 2019

shubham committed R17:7c8e8f18e5be: Add Minix Filesystem (authored by shubham).
Add Minix Filesystem
Jun 8 2019, 6:32 PM
shubham closed D21653: Add Minix Filesystem.
Jun 8 2019, 6:32 PM · KDE Partition Manager
shubham committed R16:ef20244be55a: Add support for Minix(Mini Unix) Filesystem (authored by shubham).
Add support for Minix(Mini Unix) Filesystem
Jun 8 2019, 6:31 PM
shubham closed D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 8 2019, 6:31 PM · KDE Partition Manager
shubham updated the summary of D21653: Add Minix Filesystem.
Jun 8 2019, 6:30 PM · KDE Partition Manager
shubham updated the diff for D21653: Add Minix Filesystem.

Fix copy paste error

Jun 8 2019, 6:24 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Make requested changes

Jun 8 2019, 6:13 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Correct tool name and website

Jun 8 2019, 5:11 PM · KDE Partition Manager
shubham committed R16:6f7cea6b2759: Quit application if bus is not connected, interface not registered (authored by shubham).
Quit application if bus is not connected, interface not registered
Jun 8 2019, 10:14 AM
shubham closed D21616: Quit application if bus is not connected, interface not registered.
Jun 8 2019, 10:14 AM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Made suggested changes

Jun 8 2019, 10:00 AM · KDE Partition Manager
shubham added a comment to D21616: Quit application if bus is not connected, interface not registered.

This is seprate from the patch sitter had made. Here, application quitting is inside if.

Jun 8 2019, 9:42 AM · KDE Partition Manager
shubham added a comment to D21652: Add support for Minix(Mini Unix) Filesystem.

Thread 8 "m_DeviceScanner" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffca6df700 (LWP 4074)]
0x00007ffff5934148 in vtable for QTreeWidgetItem () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
(gdb) bt
#0 0x00007ffff5934148 in vtable for QTreeWidgetItem () at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#1 0x00007ffff447e9d2 in QObject::connect(QObject const*, char const*, QObject const*, char const*, Qt::ConnectionType) () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#2 0x00007ffff7b85d85 in ExternalCommand::copyBlocks(CopySource const&, CopyTarget&) (this=this@entry=0x7fffca6de8b0, source=..., target=...) at /home/aryan/kde/src/kpmcore/src/util/externalcommand.cpp:185
#3 0x00007fffddf01e0e in SfdiskBackend::updateDevicePartitionTable(Device&, QJsonObject const&) (this=this@entry=0x5555558fe8d0, d=..., jsonPartitionTable=...)

at /home/aryan/kde/src/kpmcore/src/plugins/sfdisk/sfdiskbackend.cpp:364

#4 0x00007fffddf04a4e in SfdiskBackend::scanDevice(QString const&) (this=0x5555558fe8d0, deviceNode=...) at /home/aryan/kde/src/kpmcore/src/plugins/sfdisk/sfdiskbackend.cpp:212
#5 0x00007fffddf017e7 in SfdiskBackend::scanDevices(QFlags<ScanFlag>) (this=0x5555558fe8d0, scanFlags=...) at /home/aryan/kde/src/kpmcore/src/plugins/sfdisk/sfdiskbackend.cpp:115
#6 0x00007ffff7b37106 in DeviceScanner::scan() (this=0x5555558f6920) at /home/aryan/kde/src/kpmcore/src/core/devicescanner.cpp:66
#7 0x00007ffff4270bc2 in () at /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#8 0x00007ffff04a46db in start_thread (arg=0x7fffca6df700) at pthread_create.c:463
#9 0x00007ffff3b7088f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) thread 0
Invalid thread ID: 0
(gdb) thread 1
[Switching to thread 1 (Thread 0x7ffff7fa5840 (LWP 4005))]
#0 0x00007ffff3b5f0b4 in GI_libc_read (fd=5, buf=0x7fffffffd850, nbytes=16) at ../sysdeps/unix/sysv/linux/read.c:27

Jun 8 2019, 6:06 AM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Add mkfs.minix and fsck.minix to externalcommand_whitelist.h

Jun 8 2019, 5:34 AM · KDE Partition Manager

Jun 7 2019

shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Remove redundant include

Jun 7 2019, 8:09 PM · KDE Partition Manager
shubham updated the summary of D21653: Add Minix Filesystem.
Jun 7 2019, 7:42 PM · KDE Partition Manager
shubham updated the diff for D21653: Add Minix Filesystem.

Rebase

Jun 7 2019, 7:34 PM · KDE Partition Manager
shubham added a comment to D21653: Add Minix Filesystem.

@cjlcarvalho Did you see minix added to the menu? Can you please try applying the patch?

Jun 7 2019, 7:01 PM · KDE Partition Manager
shubham updated the diff for D21653: Add Minix Filesystem.

Whitespace consistency

Jun 7 2019, 6:47 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Whitespace consistency

Jun 7 2019, 6:38 PM · KDE Partition Manager
shubham added a project to D21653: Add Minix Filesystem: KDE Partition Manager.
Jun 7 2019, 6:36 PM · KDE Partition Manager
shubham requested review of D21653: Add Minix Filesystem.
Jun 7 2019, 6:35 PM · KDE Partition Manager
shubham added a project to D21652: Add support for Minix(Mini Unix) Filesystem: KDE Partition Manager.
Jun 7 2019, 5:59 PM · KDE Partition Manager
shubham updated the diff for D21652: Add support for Minix(Mini Unix) Filesystem.

Remove redundant includes

Jun 7 2019, 5:58 PM · KDE Partition Manager
shubham requested review of D21652: Add support for Minix(Mini Unix) Filesystem.
Jun 7 2019, 5:57 PM · KDE Partition Manager
shubham updated the diff for D21617: Handle action authorization inside helper.

Rebase

Jun 7 2019, 2:25 PM · KDE Partition Manager
shubham added inline comments to D21617: Handle action authorization inside helper.
Jun 7 2019, 2:21 PM · KDE Partition Manager
shubham updated the diff for D21617: Handle action authorization inside helper.

Remove FindPolkitQt1.cmake

Jun 7 2019, 4:21 AM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Made suggested changes

Jun 7 2019, 4:17 AM · KDE Partition Manager
shubham committed R16:67795a08ab62: Fix uninitialized variable warning (authored by shubham).
Fix uninitialized variable warning
Jun 7 2019, 4:09 AM
shubham added a reviewer for D21637: Display BLAKE2 file checksums for RAR files: elvisangelaccio.
Jun 7 2019, 4:01 AM · Ark

Jun 6 2019

shubham added a dependency for D21617: Handle action authorization inside helper: D21564: [WIP]: Implement Authentication Agent/Listener.
Jun 6 2019, 10:05 AM · KDE Partition Manager
shubham added a dependent revision for D21564: [WIP]: Implement Authentication Agent/Listener: D21617: Handle action authorization inside helper.
Jun 6 2019, 10:05 AM · KDE Partition Manager
shubham updated the diff for D21617: Handle action authorization inside helper.

diff relative to D21564

Jun 6 2019, 10:04 AM · KDE Partition Manager
shubham requested review of D21617: Handle action authorization inside helper.
Jun 6 2019, 10:02 AM · KDE Partition Manager
shubham added a project to D21616: Quit application if bus is not connected, interface not registered: KDE Partition Manager.
Jun 6 2019, 9:07 AM · KDE Partition Manager
shubham requested review of D21616: Quit application if bus is not connected, interface not registered.
Jun 6 2019, 9:06 AM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Some more cleanup

Jun 6 2019, 8:44 AM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Remove unneded includes and use Q_UNUSED() variables

Jun 6 2019, 8:40 AM · KDE Partition Manager

Jun 5 2019

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Unregistration of the auth agent

Jun 5 2019, 5:01 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Proper rebase

Jun 5 2019, 3:55 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Move FindPolkitQt1.cmake to cmake/modules/

Jun 5 2019, 3:52 PM · KDE Partition Manager

Jun 4 2019

shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Remove extra variable

Jun 4 2019, 3:29 PM · KDE Partition Manager
shubham updated the diff for D21564: [WIP]: Implement Authentication Agent/Listener.

Use authority instance to register the listener

Jun 4 2019, 7:56 AM · KDE Partition Manager
shubham reopened D21564: [WIP]: Implement Authentication Agent/Listener.
Jun 4 2019, 7:56 AM · KDE Partition Manager