[DocumentUrlDB] Remove unused 'rename' method
ClosedPublic
Actions

Authored by bruns on Jun 9 2019, 2:22 PM.

Details

Reviewers

Group Reviewers

Baloo

Commits

Summary

It is not used anywhere, so remove it.

Test Plan

still compiles

Repository

R293 Baloo

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

bruns requested review of this revision.Jun 9 2019, 2:22 PM

Does this function had any use when it was first implemented? Or may it come to use later?

In D21692#476804, @shubham wrote:

Does this function had any use when it was first implemented? Or may it come to use later?

Problem with it is it only copes with renames, not moves (i.e. changing the parent).

Also see D21694.

bye bye

This revision is now accepted and ready to land.Jun 10 2019, 4:27 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/engine/documenturldb.h (2 lines)
M			src/engine/documenturldb.cpp (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59448	ec1baef		Jun 9 2019, 2:22 PM	★	★
Diff 2	59538	b54f8ec	R293:4883ac516d5f69a17f3ba8848f868a53ba341da8	Jun 10 2019, 5:39 PM	★	★