Differential D18599

Use specific error message if file/folder name contains '/'
AbandonedPublic
Actions

Authored by shubham on Jan 29 2019, 5:49 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Frameworks
Dolphin
Summary

Depends on D18563

Diff Detail

Repository
R241 KIO
Branch
err
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7662
Build 7680: arc lint + arc unit
shubham created this revision.Jan 29 2019, 5:49 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 29 2019, 5:49 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
shubham requested review of this revision.Jan 29 2019, 5:49 PM
shubham updated this revision to Diff 50494.Jan 29 2019, 5:51 PM

Remove unintentionally included header

ngraham requested changes to this revision.Jan 29 2019, 5:54 PM
ngraham added inline comments.
src/filewidgets/knewfilemenu.cpp
905 ↗(On Diff #50494)

You don't need to duplicate the diff from D18563 here.

src/ioslaves/file/file.cpp
286

This should not be evaluated on Windows, since as you pointed out, Windows does allow slashes so there's no error here.

This revision now requires changes to proceed.Jan 29 2019, 5:54 PM
shubham updated this revision to Diff 50495.EditedJan 29 2019, 6:02 PM

#ifndef Q_OS_WIN for the error message

shubham marked an inline comment as done.Jan 29 2019, 6:02 PM
shubham marked an inline comment as done.
ngraham added inline comments.Jan 29 2019, 6:06 PM
src/core/global.h
251

There's a trailing space here

src/core/job_error.cpp
1083

No spaces on line breaks

1088

Trailing space

src/ioslaves/file/file.cpp
285

No spaces on line breaks

shubham updated this revision to Diff 50496.Jan 29 2019, 6:12 PM
shubham marked an inline comment as done.

Fix trailing spaces

shubham marked 2 inline comments as done.Jan 29 2019, 6:13 PM
shubham marked an inline comment as done.
ngraham accepted this revision.Jan 29 2019, 6:15 PM

Works great, thanks.

This revision is now accepted and ready to land.Jan 29 2019, 6:15 PM
shubham abandoned this revision.Jun 19 2019, 4:34 PM

Revision Contents
Changeset List

PathPackages
Msrc/core/global.h (1 line)
Msrc/core/job_error.cpp (9 lines)
Msrc/ioslaves/file/file.cpp (8 lines)

Diff 50496

View Options

src/core/global.h

Loading...
View Options

src/core/job_error.cpp

Loading...
View Options

src/ioslaves/file/file.cpp

Loading...