Ouch thx 🙈

Reverted

ah ok, I thought it was linked without your code change

Hi, wile adding snoretoast as dep is correct, removing phonon might break existing releases.

I tried to reproduce your issue and failed with the latest version of craft.

I think we should wait until the code was released and then only version dependant.

In D21661#476607, @sredman wrote:

In D21661#476571, @pino wrote:

In D21661#476156, @pino wrote:

how is snoretoast actually used here? you are requiring the library for building and linking, but then:

• snoretoastactions.h, which is part of the headers of snoretoast, is copied here
• the snoretoast library is never used, as the utilities of it are invoked instead If the library does all the work already, then I'd prefer to use it directly instead of spawning executables all the time...

Piyush, what about this? It seems the snoretoast library provides a SnoreToasts class to do this instead of spawning an helper tool, what about using it instead?

@vonreth can probably explain better, but basically the situation as I understand it is on Windows you need to be installed in a special place and registered with the OS in order to show notifications. Since KNotifications is a library, an app using it can't (feasibly) be properly registered with the OS. It is possible we could come up with some complicated solution which would require every KNotification-using app to do some special and probably difficult to understand change to support Windows. Or we can have SnoreNotify.exe take care of all that nonsense for us. Note that, up to this point, there have been no special KNotifications changes to the generic KDE Connect codebase to make this work, just some tweaks to the Windows installer to pull in SnoreToast.

looks good, if the section is does end up in the right place this looks perfect :)

we don't provide an option for custome uninstall icons and using the app icon would be confusing.

Some ideas, if I sound grumpy... I'm tired, good night :)