Disable broken and no longer needed workaround code with msvc2019
ClosedPublic

Authored by vonreth on Apr 29 2019, 8:12 PM.

Details

Summary

See:

int main() {
        const auto inf = std::numeric_limits<double>::infinity();
        print(_MSC_VER);
        print(atan2(inf, inf));
        print(atan2(-inf, -inf));
        print(atan2(inf, -inf));
        print(fmod(10.0, inf));
        print(fmod(10.0, -inf));

        return 0;
}

->

_MSC_VER: 1920
atan2(inf, inf): 0.785398
atan2(-inf, -inf): -2.35619
atan2(inf, -inf): 2.35619
fmod(10.0, inf): 10
fmod(10.0, -inf): 10

Diff Detail

Repository
R314 KJs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vonreth created this revision.Apr 29 2019, 8:12 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 29 2019, 8:12 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vonreth requested review of this revision.Apr 29 2019, 8:12 PM
vonreth retitled this revision from Disable boken and no longer needed workaround code to Disable broken and no longer needed workaround code with msvc2019.Apr 29 2019, 8:16 PM
vonreth edited the summary of this revision. (Show Details)
vonreth added reviewers: dfaure, arichardson.
vonreth edited the summary of this revision. (Show Details)
apol accepted this revision.Apr 30 2019, 2:33 AM
This revision is now accepted and ready to land.Apr 30 2019, 2:33 AM
This revision was automatically updated to reflect the committed changes.