remove phonon from deps if building for win32

Authored by brute4s99 on Jun 7 2019, 11:19 PM.



Phonon is not a dependency for Windows 32 KNotification builds.

Diff Detail

R877 Craft Blueprints for KDE
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
brute4s99 requested review of this revision.Jun 7 2019, 11:19 PM
brute4s99 created this revision.
brute4s99 edited the summary of this revision. (Show Details)Jun 7 2019, 11:21 PM
brute4s99 added reviewers: broulik, vonreth.
brute4s99 added a project: Craft.
albertvaka accepted this revision.Jun 9 2019, 4:17 PM
albertvaka added a subscriber: albertvaka.


This revision is now accepted and ready to land.Jun 9 2019, 4:17 PM
vonreth requested changes to this revision.Jun 9 2019, 4:42 PM

I think we should wait until the code was released and then only version dependant.

This revision now requires changes to proceed.Jun 9 2019, 4:42 PM

umm, phonon isn't used for Windows notifications with/without the upcoming notifybysnoretoast back-end. Can we not land this?

vonreth accepted this revision.Jun 18 2019, 8:55 AM

ah ok, I thought it was linked without your code change

This revision is now accepted and ready to land.Jun 18 2019, 8:55 AM

awesome! landing this! ๐ŸŽ‰

This revision was automatically updated to reflect the committed changes.