Disable valgrind detection when compiling with MSVC
ClosedPublic

Authored by bruns on Jun 5 2019, 12:49 PM.

Details

Summary

MSVC chokes on the inline assembly, use the stub macros there instead.

Test Plan

Valgrind detection on Linux/GCC still works
MSVC untested

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Jun 5 2019, 12:49 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptJun 5 2019, 12:49 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Jun 5 2019, 12:49 PM
alexeymin accepted this revision as: Windows.EditedJun 5 2019, 12:53 PM
alexeymin added a subscriber: alexeymin.

This should work.
I mean, msvc detection part...

bruns removed a reviewer: Baloo.Jun 5 2019, 1:00 PM
bruns added a subscriber: Baloo.
This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2019, 1:01 PM
This revision was automatically updated to reflect the committed changes.
vonreth added a subscriber: vonreth.Jun 5 2019, 1:44 PM
vonreth added inline comments.
src/engine/database.cpp
49

Id suggest to use Q_CC_MSVC but it looks ok