Feed Advanced Search

Today

vonreth committed R993:5c09b0b7de46: Prepare Qt 5.12.4 (authored by vonreth).
Prepare Qt 5.12.4
Wed, Jun 19, 10:55 AM
vonreth accepted D21889: fix header files destination for SnoreToast.

Ouch thx 馃檲

Wed, Jun 19, 6:44 AMWindows
vonreth accepted D21888: add .arcconfig to SnoreToast.
Wed, Jun 19, 6:43 AMWindows

Yesterday

vonreth committed R834:58235322d46f: add contact info (authored by vonreth).
add contact info
Tue, Jun 18, 7:04 PM
vonreth committed R877:1d6e51fc14a8: Reenable kdewebkit with mingw (authored by vonreth).
Reenable kdewebkit with mingw
Tue, Jun 18, 4:17 PM
vonreth committed R877:b895479229e4: Build qtwebkit with mingw in release mode by default (authored by vonreth).
Build qtwebkit with mingw in release mode by default
Tue, Jun 18, 4:17 PM
vonreth committed R877:79aa07d5a34d: Looks like qtwebkit was fixed for mingw (authored by vonreth).
Looks like qtwebkit was fixed for mingw
Tue, Jun 18, 12:20 PM
vonreth added inline comments to D21602: Add NSIS Script for KDE Connect.
Tue, Jun 18, 12:02 PMCraft, KDE Connect
vonreth added a comment to D21657: remove phonon from deps if building for win32.

Reverted

Tue, Jun 18, 9:09 AMCraft
vonreth added a reverting change for R877:ecdf72305258: remove phonon from deps if building for win32: R877:1365377232b8: Revert "remove phonon from deps if building for win32".
Tue, Jun 18, 9:08 AM
vonreth committed R877:1365377232b8: Revert "remove phonon from deps if building for win32" (authored by vonreth).
Revert "remove phonon from deps if building for win32"
Tue, Jun 18, 9:08 AM
vonreth accepted D21657: remove phonon from deps if building for win32.

ah ok, I thought it was linked without your code change

Tue, Jun 18, 8:55 AMCraft
vonreth committed R877:319e159d255c: Prepare Qt 5.12.4 (authored by vonreth).
Prepare Qt 5.12.4
Tue, Jun 18, 6:52 AM

Mon, Jun 17

vonreth committed R877:6d2bde3d38a5: Fix dep (authored by vonreth).
Fix dep
Mon, Jun 17, 12:09 PM
vonreth committed R877:3b0c2672418d: Fix perl on windows, readd the postInstall step where we fix the install prefix (authored by vonreth).
Fix perl on windows, readd the postInstall step where we fix the install prefix
Mon, Jun 17, 8:35 AM
vonreth committed R138:4d97f7ccc3e5: Move patchable file extensions to the static class members (authored by vonreth).
Move patchable file extensions to the static class members
Mon, Jun 17, 8:25 AM
vonreth added a comment to D21588: Add Snoretoast to Notifications.

Hi, wile adding snoretoast as dep is correct, removing phonon might break existing releases.

Mon, Jun 17, 7:48 AMCraft

Sat, Jun 15

vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jun 15, 8:03 PMFrameworks
vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jun 15, 2:00 PMFrameworks
vonreth committed R834:a53a6b733624: Extend doc for msvc2019 issue (authored by vonreth).
Extend doc for msvc2019 issue
Sat, Jun 15, 1:53 PM
vonreth committed R877:5893be145292: Fix sha, switch to tar.gz (authored by vonreth).
Fix sha, switch to tar.gz
Sat, Jun 15, 10:31 AM
vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jun 15, 10:15 AMFrameworks

Fri, Jun 14

vonreth committed R834:42fdbf5efa95: Update description (authored by vonreth).
Update description
Fri, Jun 14, 10:19 PM
vonreth committed R834:f7a609f024ff: Cleanup the example (authored by vonreth).
Cleanup the example
Fri, Jun 14, 10:19 PM
vonreth committed R877:14679a434d47: Build linux perl with threading (authored by vonreth).
Build linux perl with threading
Fri, Jun 14, 7:49 AM
vonreth committed R138:473931b875fb: Allow to additive change the patch level of a whole blueprint branch (authored by vonreth).
Allow to additive change the patch level of a whole blueprint branch
Fri, Jun 14, 7:35 AM

Thu, Jun 13

vonreth added a reverting change for R877:ae4ef21a1ed9: Build shared perl on linux: R877:0887773264af: Revert "Build shared perl on linux".
Thu, Jun 13, 4:24 PM
vonreth committed R877:0887773264af: Revert "Build shared perl on linux" (authored by vonreth).
Revert "Build shared perl on linux"
Thu, Jun 13, 4:24 PM
vonreth added a reverting change for R877:dae6ac377c59: Linux make shared perl cacheable (most of the time): R877:59b9a2aa9aa7: Revert "Linux make shared perl cacheable (most of the time)".
Thu, Jun 13, 4:24 PM
vonreth committed R877:59b9a2aa9aa7: Revert "Linux make shared perl cacheable (most of the time)" (authored by vonreth).
Revert "Linux make shared perl cacheable (most of the time)"
Thu, Jun 13, 4:24 PM
vonreth committed R877:9d89358c0010: Rebuild perl (authored by vonreth).
Rebuild perl
Thu, Jun 13, 2:50 PM
vonreth committed R877:dae6ac377c59: Linux make shared perl cacheable (most of the time) (authored by vonreth).
Linux make shared perl cacheable (most of the time)
Thu, Jun 13, 2:48 PM
vonreth committed R877:ae4ef21a1ed9: Build shared perl on linux (authored by vonreth).
Build shared perl on linux
Thu, Jun 13, 2:48 PM
vonreth committed R877:6706e9d2af47: No need to manually copy headers, perl installs them to lib/CORE (authored by vonreth).
No need to manually copy headers, perl installs them to lib/CORE
Thu, Jun 13, 2:48 PM
vonreth committed R138:1109602ba1a7: chrpath is linux only (authored by vonreth).
chrpath is linux only
Thu, Jun 13, 2:48 PM
vonreth committed R834:99eba52c99f2: Update readme (authored by vonreth).
Update readme
Thu, Jun 13, 12:07 PM
vonreth committed R834:549b7daf5e46: Update readme (authored by vonreth).
Update readme
Thu, Jun 13, 12:02 PM

Tue, Jun 11

vonreth committed R138:8dbd5951a775: Update the core before we update everything (authored by vonreth).
Update the core before we update everything
Tue, Jun 11, 12:44 PM
vonreth committed R877:0c035c776283: Forgot to merge patch upstream (authored by vonreth).
Forgot to merge patch upstream
Tue, Jun 11, 11:18 AM
vonreth added inline comments to D19903: Fix build with msvc.
Tue, Jun 11, 11:17 AMFrameworks
vonreth committed R314:57aacba17c66: Disable broken and no longer needed workaround code with msvc2019 (authored by vonreth).
Disable broken and no longer needed workaround code with msvc2019
Tue, Jun 11, 11:12 AM
vonreth closed D20907: Disable broken and no longer needed workaround code with msvc2019.
Tue, Jun 11, 11:12 AMFrameworks
vonreth committed R877:99030a2f175c: We still need this patch (authored by vonreth).
We still need this patch
Tue, Jun 11, 8:22 AM
vonreth added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

I tried to reproduce your issue and failed with the latest version of craft.

Tue, Jun 11, 8:13 AM
vonreth committed R877:2e73c766322f: KDE Applications 19.04.2 (authored by vonreth).
KDE Applications 19.04.2
Tue, Jun 11, 7:33 AM
vonreth committed R877:7216eb7f6e06: KDE Frameworks 5.59.0 (authored by vonreth).
KDE Frameworks 5.59.0
Tue, Jun 11, 7:33 AM
vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Tue, Jun 11, 7:22 AMFrameworks
vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Tue, Jun 11, 3:57 AMFrameworks

Mon, Jun 10

vonreth committed R834:8b3dc33a8112: Improve error logging (authored by vonreth).
Improve error logging
Mon, Jun 10, 10:28 AM

Sun, Jun 9

vonreth accepted D21658: add snoretoast for win32 builds to knotifs blueprint.
Sun, Jun 9, 4:59 PMCraft
vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sun, Jun 9, 4:47 PMFrameworks
vonreth requested changes to D21657: remove phonon from deps if building for win32.

I think we should wait until the code was released and then only version dependant.

Sun, Jun 9, 4:42 PMCraft
vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sun, Jun 9, 10:59 AMFrameworks
vonreth added a comment to D21661: add snoretoast backend for KNotifications on Windows.
In D21661#476571, @pino wrote:
In D21661#476156, @pino wrote:

how is snoretoast actually used here? you are requiring the library for building and linking, but then:

  • snoretoastactions.h, which is part of the headers of snoretoast, is copied here
  • the snoretoast library is never used, as the utilities of it are invoked instead If the library does all the work already, then I'd prefer to use it directly instead of spawning executables all the time...

Piyush, what about this? It seems the snoretoast library provides a SnoreToasts class to do this instead of spawning an helper tool, what about using it instead?

@vonreth can probably explain better, but basically the situation as I understand it is on Windows you need to be installed in a special place and registered with the OS in order to show notifications. Since KNotifications is a library, an app using it can't (feasibly) be properly registered with the OS. It is possible we could come up with some complicated solution which would require every KNotification-using app to do some special and probably difficult to understand change to support Windows. Or we can have SnoreNotify.exe take care of all that nonsense for us. Note that, up to this point, there have been no special KNotifications changes to the generic KDE Connect codebase to make this work, just some tweaks to the Windows installer to pull in SnoreToast.

Sun, Jun 9, 10:38 AMFrameworks

Sat, Jun 8

vonreth added inline comments to D21661: add snoretoast backend for KNotifications on Windows.
Sat, Jun 8, 5:34 PMFrameworks

Fri, Jun 7

vonreth committed R834:647fb9fcf4c0: Don't fail if we couldn't retreive notification settings (authored by vonreth).
Don't fail if we couldn't retreive notification settings
Fri, Jun 7, 7:40 PM
vonreth accepted D21602: Add NSIS Script for KDE Connect.
Fri, Jun 7, 6:33 PMCraft, KDE Connect
vonreth committed R834:bed3b5d6e122: Fix error message and include line number (authored by vonreth).
Fix error message and include line number
Fri, Jun 7, 5:30 PM
vonreth committed R138:d96614da6910: Cleanup (authored by vonreth).
Cleanup
Fri, Jun 7, 9:40 AM
vonreth committed R138:fcd45b20fd4f: Handle each occurence of a path separately in patchInstallPrefix (authored by vonreth).
Handle each occurence of a path separately in patchInstallPrefix
Fri, Jun 7, 9:19 AM
vonreth committed R138:ac591e206a16: Only create shortcut install dir if we have shortcuts (authored by vonreth).
Only create shortcut install dir if we have shortcuts
Fri, Jun 7, 7:30 AM
vonreth committed R138:ca58925512c2: Nowadays the context should be correct, don't mess with it (authored by vonreth).
Nowadays the context should be correct, don't mess with it
Fri, Jun 7, 7:30 AM
vonreth committed R138:19aefc83ae7f: Simplify msbuild invocation (authored by vonreth).
Simplify msbuild invocation
Fri, Jun 7, 6:59 AM
vonreth committed R138:7d5ca10d5e54: Update jom to 1.1.3 (authored by vonreth).
Update jom to 1.1.3
Fri, Jun 7, 6:59 AM

Thu, Jun 6

vonreth added inline comments to D21615: Context - aware shortcuts for NSIS based installers.
Thu, Jun 6, 12:58 PMCraft
vonreth committed R834:8ced0b083d39: Allow to pass absolute paths for the shortcut (authored by vonreth).
Allow to pass absolute paths for the shortcut
Thu, Jun 6, 11:36 AM
vonreth added inline comments to D21602: Add NSIS Script for KDE Connect.
Thu, Jun 6, 10:24 AMCraft, KDE Connect
vonreth added inline comments to D21602: Add NSIS Script for KDE Connect.
Thu, Jun 6, 10:21 AMCraft, KDE Connect

Wed, Jun 5

vonreth accepted D21612: Add Un.Sections to NSIS Template.

looks good, if the section is does end up in the right place this looks perfect :)

Wed, Jun 5, 8:40 PMCraft
vonreth committed R138:a5141db1a071: Make otool -L less verbose (authored by vonreth).
Make otool -L less verbose
Wed, Jun 5, 7:36 PM
vonreth added inline comments to D21612: Add Un.Sections to NSIS Template.
Wed, Jun 5, 7:20 PMCraft
vonreth committed R138:3e190128e370: Allow loader path in mac deps (authored by vonreth).
Allow loader path in mac deps
Wed, Jun 5, 5:38 PM
vonreth committed R138:f9e2a3f4965a: Cleanup mac bundler (authored by vonreth).
Cleanup mac bundler
Wed, Jun 5, 5:30 PM
vonreth added a comment to D21602: Add NSIS Script for KDE Connect.

we don't provide an option for custome uninstall icons and using the app icon would be confusing.

Wed, Jun 5, 5:06 PMCraft, KDE Connect
vonreth committed R138:97dd05a182b6: Fix issue in replaceSymlinksWithCopies (authored by vonreth).
Fix issue in replaceSymlinksWithCopies
Wed, Jun 5, 1:52 PM
vonreth added inline comments to D21599: Disable valgrind detection when compiling with MSVC.
Wed, Jun 5, 1:44 PMBaloo, Frameworks
vonreth committed R877:9cf65a039e02: We will ship snoretoast soon so move it to the root (authored by vonreth).
We will ship snoretoast soon so move it to the root
Wed, Jun 5, 11:09 AM
vonreth committed R138:39325471852e: Modernise GitSource (authored by vonreth).
Modernise GitSource
Wed, Jun 5, 11:03 AM
vonreth committed R138:46e6e69093e3: Allow to hardcode a revision (authored by vonreth).
Allow to hardcode a revision
Wed, Jun 5, 9:49 AM
vonreth committed R877:431dc92e8ca8: Update qtc (authored by vonreth).
Update qtc
Wed, Jun 5, 9:32 AM

Tue, Jun 4

vonreth added a comment to R289:ecefe97572ef: plugin but with actions suppressed.

Some ideas, if I sound grumpy... I'm tired, good night :)

Tue, Jun 4, 9:36 PM
vonreth committed R834:706c19688e86: Cleanup (authored by vonreth).
Cleanup
Tue, Jun 4, 1:55 PM
vonreth committed R834:c0f25869f72f: Always wait for the notifications to ensure the string data keeps availible (authored by vonreth).
Always wait for the notifications to ensure the string data keeps availible
Tue, Jun 4, 9:12 AM
vonreth committed R834:8aa0f8a98100: Make sure stringsa 0 terminated (authored by vonreth).
Make sure stringsa 0 terminated
Tue, Jun 4, 9:02 AM
vonreth committed R834:9e4069cac5ef: Remove string reference wrapper and use standard one (authored by vonreth).
Remove string reference wrapper and use standard one
Tue, Jun 4, 8:55 AM
vonreth committed R834:44eafba15b7a: Always check settings (authored by vonreth).
Always check settings
Tue, Jun 4, 8:55 AM
vonreth committed R834:911dc538694d: Fix macro (authored by vonreth).
Fix macro
Tue, Jun 4, 8:55 AM
vonreth committed R834:d38336486647: Remove outdated appveyor.yml (authored by vonreth).
Remove outdated appveyor.yml
Tue, Jun 4, 7:54 AM
vonreth committed R834:06b4d937a2e8: Use a macro to check the HRESULT (authored by vonreth).
Use a macro to check the HRESULT
Tue, Jun 4, 7:09 AM

Mon, Jun 3

vonreth committed R834:643d230fc0f3: -close removes notifications from the action center (authored by vonreth).
-close removes notifications from the action center
Mon, Jun 3, 9:46 AM

Sat, Jun 1

vonreth committed R834:b7182720b177: Use toStdWstring (authored by vonreth).
Use toStdWstring
Sat, Jun 1, 2:13 PM
vonreth committed R834:ddd4bd9a69f4: Fix cmake install target (authored by vonreth).
Fix cmake install target
Sat, Jun 1, 2:03 PM

Fri, May 31

vonreth committed R834:3a595cbdefb3: Clang format (authored by vonreth).
Clang format
Fri, May 31, 1:55 PM
vonreth committed R834:9905e244edc4: Cmake cleanup (authored by vonreth).
Cmake cleanup
Fri, May 31, 1:55 PM
vonreth committed R834:1afe23082f04: Set hr to error if one occures (authored by vonreth).
Set hr to error if one occures
Fri, May 31, 1:41 PM
vonreth committed R834:dc12175b39bb: Use cmake targets in examples (authored by vonreth).
Use cmake targets in examples
Fri, May 31, 1:41 PM
vonreth committed R834:bdb913683ce5: Install cmake config (authored by vonreth).
Install cmake config
Fri, May 31, 1:41 PM
vonreth committed R834:52936b732550: Make examples optional (authored by vonreth).
Make examples optional
Fri, May 31, 1:41 PM

Thu, May 30

vonreth committed R138:eeea064881d7: fix appx version (authored by vonreth).
fix appx version
Thu, May 30, 7:00 PM
vonreth committed R138:1c5172d57d1c: Always override default for appx version (authored by vonreth).
Always override default for appx version
Thu, May 30, 5:26 PM