- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Oct 9 2017
Nope, since you can still specify a build order within a single project (by adding multiple different targets to the build sequence) -- though this is broken at the moment, too...
Oct 8 2017
In D8207#153510, @mpyne wrote:I support the idea, but I think there's a few more spots where we can convert http:// to https://. I ran ag --only-matching --no-heading 'http:.*k.*\.org' in the kcoreaddons source directory, with the current version of this patch already applied, and got the following output:
src/lib/kaboutdata.h:811:http://". "http://kate.kde.org
Changed the casing of the KDEVELOP_FULL_VERSION_STRING define to make it consistent with the defines from kdevelop_version.h
In D8158#153441, @rjvbb wrote:https://bugs.kde.org/enter_bug.cgi?format=guided&product=kdevelop&version=5.1.80-foo => pre-selects 'unspecified'Not for me, I get 5.1.2 preselected for anything that's not known. So logically when I tried 5.1.2-10-gaga I also got 5.1.2 . I concluded that BKO does simple pattern matching...
My suggestion:
<kfunk> milian: re. https://phabricator.kde.org/D8202 okay to let 5.2 require Qt 5.5 (merge this patch), and make master require Qt 5.6 (revert it again here)?
<kfunk> so I can tell 16.04 LTS users to use 5.2 as a fallback
<milian> kfunk: sure, this was just my suggestion
In D8158#153432, @mwolff wrote:I personally think it's useless to have this, but if others want to have it, fair enough. I just hate that this means a partial rebuild + relink when committing/rebasing without changing code.
Not sure what you tried. This logic is very simple.
Rename variable slightly
Note: Change now LGTM (though I have some local changes). We still have a problem, thus can't merge as-is: When reporting a bug via Help -> Report Bug, and when KAboutData's version is filled with a git-describe like string, the 'version' field on bugs.kde.org is no longer preselected properly.
Oct 6 2017
In D8158#152647, @rjvbb wrote:Does drkonqui still automatically select the right version in Bugzilla if we do this ...? (It does that, right?)
I haven't gone so far as to submit an actual bug report. I'd hope that some kind of pattern matching is done, either in DrKonqi or by the Bugzilla software itself. Which btw. only seems to know release versions.
Oct 5 2017
Rest LGTM
Oct 4 2017
Oct 2 2017
Remove all calls to git config
Yeah, I personally don't care. I can remove the other call to git config as well...
In D7975#151461, @vonreth wrote:But we should also remove the kde: part from the craft recipe.
Oct 1 2017
Done, right? Closing.
In D7975#151404, @alexeymin wrote:but why? :)
Note: f"{someVar}" == someVar -- I'll fix and then push the patch. Thanks!
Add one more fix
Sep 29 2017
Sep 28 2017
Sep 27 2017
@bcooksley I don't think so.
Can you try passing the command as a list?
Sep 26 2017
For my part: I think it's understandable that for some project maintainers, it's not feasible to use Craft (probably not even in future).