Feed Advanced Search

Oct 9 2017

kfunk committed R138:624e6e377b62: MacDMGPackager: Several fixes, complete it more (authored by kfunk).
MacDMGPackager: Several fixes, complete it more
Oct 9 2017, 2:11 PM
kfunk committed R138:942cea821262: mergeTree: Create path if it does not exist (authored by kfunk).
mergeTree: Create path if it does not exist
Oct 9 2017, 2:11 PM
kfunk committed R32:b2a1ee2673c0: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Oct 9 2017, 9:27 AM
kfunk committed R32:5c95479cee5a: Fully restore compat with Qt 5.5 (authored by kfunk).
Fully restore compat with Qt 5.5
Oct 9 2017, 9:19 AM
kfunk updated subscribers of D8217: projectmanagerview: Don't collapse children.

Nope, since you can still specify a build order within a single project (by adding multiple different targets to the build sequence) -- though this is broken at the moment, too...

Oct 9 2017, 9:00 AM
kfunk created D8217: projectmanagerview: Don't collapse children.
Oct 9 2017, 8:52 AM
kfunk added inline comments to D8216: Implement automatic module loading for singletons.
Oct 9 2017, 8:26 AM

Oct 8 2017

kfunk committed R32:fd60b4b6dee8: Another compile fix for Qt 5.5 (authored by kfunk).
Another compile fix for Qt 5.5
Oct 8 2017, 10:01 PM
kfunk committed R263:1ee609564a8f: Use https for KDE urls (authored by kfunk).
Use https for KDE urls
Oct 8 2017, 9:57 PM
kfunk closed D8209: Use https for KDE urls.
Oct 8 2017, 9:57 PM · Frameworks
kfunk added a comment to D8207: Use https for KDE urls.
In D8207#153510, @mpyne wrote:

I support the idea, but I think there's a few more spots where we can convert http:// to https://. I ran ag --only-matching --no-heading 'http:.*k.*\.org' in the kcoreaddons source directory, with the current version of this patch already applied, and got the following output:

src/lib/kaboutdata.h:811:http://". "http://kate.kde.org
Oct 8 2017, 9:55 PM · Frameworks
kfunk committed R244:3cc8b8f5ad26: Use https for KDE urls (authored by kfunk).
Use https for KDE urls
Oct 8 2017, 9:53 PM
kfunk closed D8207: Use https for KDE urls.
Oct 8 2017, 9:53 PM · Frameworks
kfunk added a comment to D8158: KDevelop: decorate patch version string in development builds.

Changed the casing of the KDEVELOP_FULL_VERSION_STRING define to make it consistent with the defines from kdevelop_version.h

Oct 8 2017, 8:56 PM · KDevelop
kfunk committed R32:c4a10dbbfded: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Oct 8 2017, 7:41 PM
kfunk committed R32:8da8d1d21e0a: Fix Qt 5.5 compatibility -- no constFirst/Last methods. (authored by kfunk).
Fix Qt 5.5 compatibility -- no constFirst/Last methods.
Oct 8 2017, 7:38 PM
kfunk closed D8202: Fix Qt 5.5 compatibility -- no constFirst/Last methods..
Oct 8 2017, 7:38 PM
kfunk committed R32:0a29544fcc06: Filter out warnings as error from parser's compile flags (authored by gracicot).
Filter out warnings as error from parser's compile flags
Oct 8 2017, 7:26 PM
kfunk closed D7979: Filter out warnings as error from parser's compile flags.
Oct 8 2017, 7:26 PM · KDevelop
kfunk added a comment to D8158: KDevelop: decorate patch version string in development builds.
In D8158#153441, @rjvbb wrote:
https://bugs.kde.org/enter_bug.cgi?format=guided&product=kdevelop&version=5.1.80-foo => pre-selects 'unspecified'

Not for me, I get 5.1.2 preselected for anything that's not known. So logically when I tried 5.1.2-10-gaga I also got 5.1.2 . I concluded that BKO does simple pattern matching...

Oct 8 2017, 7:23 PM · KDevelop
kfunk added a comment to D8202: Fix Qt 5.5 compatibility -- no constFirst/Last methods..

My suggestion:
<kfunk> milian: re. https://phabricator.kde.org/D8202 okay to let 5.2 require Qt 5.5 (merge this patch), and make master require Qt 5.6 (revert it again here)?
<kfunk> so I can tell 16.04 LTS users to use 5.2 as a fallback
<milian> kfunk: sure, this was just my suggestion

Oct 8 2017, 7:09 PM
kfunk added a comment to D8158: KDevelop: decorate patch version string in development builds.

I personally think it's useless to have this, but if others want to have it, fair enough. I just hate that this means a partial rebuild + relink when committing/rebasing without changing code.

Oct 8 2017, 7:03 PM · KDevelop
kfunk created D8209: Use https for KDE urls.
Oct 8 2017, 7:00 PM · Frameworks
kfunk added a comment to D8158: KDevelop: decorate patch version string in development builds.

Not sure what you tried. This logic is very simple.

Oct 8 2017, 6:42 PM · KDevelop
kfunk created D8207: Use https for KDE urls.
Oct 8 2017, 6:38 PM · Frameworks
kfunk updated the diff for D8158: KDevelop: decorate patch version string in development builds.

Rename variable slightly

Oct 8 2017, 5:48 PM · KDevelop
kfunk added a comment to D8158: KDevelop: decorate patch version string in development builds.

Note: Change now LGTM (though I have some local changes). We still have a problem, thus can't merge as-is: When reporting a bug via Help -> Report Bug, and when KAboutData's version is filled with a git-describe like string, the 'version' field on bugs.kde.org is no longer preselected properly.

Oct 8 2017, 5:47 PM · KDevelop
kfunk added inline comments to D8158: KDevelop: decorate patch version string in development builds.
Oct 8 2017, 12:02 PM · KDevelop
kfunk committed R32:9b226d072c7f: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Oct 8 2017, 9:58 AM
kfunk requested changes to D8158: KDevelop: decorate patch version string in development builds.
Oct 8 2017, 9:08 AM · KDevelop

Oct 6 2017

kfunk added a comment to D8158: KDevelop: decorate patch version string in development builds.
In D8158#152647, @rjvbb wrote:

Does drkonqui still automatically select the right version in Bugzilla if we do this ...? (It does that, right?)

I haven't gone so far as to submit an actual bug report. I'd hope that some kind of pattern matching is done, either in DrKonqi or by the Bugzilla software itself. Which btw. only seems to know release versions.

Oct 6 2017, 5:00 PM · KDevelop
kfunk requested changes to D8158: KDevelop: decorate patch version string in development builds.
Oct 6 2017, 4:58 PM · KDevelop

Oct 5 2017

kfunk added a comment to D8108: Introduce CraftCore to manage singletons. Cleanup CraftStandardDirs..

Rest LGTM

Oct 5 2017, 8:17 AM

Oct 4 2017

kfunk committed R32:73f2759f5e85: Revert "cmake: Degrade warning to normal debug msg" (authored by kfunk).
Revert "cmake: Degrade warning to normal debug msg"
Oct 4 2017, 9:36 AM
kfunk added a reverting change for R32:7c4e09c29ba5: cmake: Degrade warning to normal debug msg: R32:73f2759f5e85: Revert "cmake: Degrade warning to normal debug msg".
Oct 4 2017, 9:36 AM
kfunk committed R32:a1869f3a9e0a: cmake: Remove spammy debug messages (authored by kfunk).
cmake: Remove spammy debug messages
Oct 4 2017, 8:24 AM
kfunk committed R32:7c4e09c29ba5: cmake: Degrade warning to normal debug msg (authored by kfunk).
cmake: Degrade warning to normal debug msg
Oct 4 2017, 8:24 AM

Oct 2 2017

kfunk committed R68:a91f3ac813dd: Make tests optional (authored by kfunk).
Make tests optional
Oct 2 2017, 10:06 AM
kfunk updated the diff for D8099: craft-core: Don't setup Git kde: prefix.

Remove all calls to git config

Oct 2 2017, 8:30 AM
kfunk added a comment to D8099: craft-core: Don't setup Git kde: prefix.

Yeah, I personally don't care. I can remove the other call to git config as well...

Oct 2 2017, 8:29 AM
kfunk added reviewers for D8099: craft-core: Don't setup Git kde: prefix: vonreth, Windows.
Oct 2 2017, 8:12 AM
kfunk added a comment to D7975: Don't depend on kde: Git prefix being around.

But we should also remove the kde: part from the craft recipe.

Oct 2 2017, 8:11 AM
kfunk created D8099: craft-core: Don't setup Git kde: prefix.
Oct 2 2017, 8:11 AM
kfunk committed R138:25af919f41a0: Don't depend on kde: Git prefix in recipes (authored by kfunk).
Don't depend on kde: Git prefix in recipes
Oct 2 2017, 8:10 AM
kfunk committed R53:2f6f832e6cd3: kdevpdb: Fixup human-readable name (authored by kfunk).
kdevpdb: Fixup human-readable name
Oct 2 2017, 8:09 AM
kfunk committed R68:47dd0b6eee55: json: Set category to 'Debugging' (authored by kfunk).
json: Set category to 'Debugging'
Oct 2 2017, 8:01 AM

Oct 1 2017

kfunk closed D7887: cleanup cmake executable preferences.

Done, right? Closing.

Oct 1 2017, 9:43 PM · KDevelop
kfunk added a comment to D7975: Don't depend on kde: Git prefix being around.

but why? :)

Oct 1 2017, 9:42 PM
kfunk committed R138:956bc51042f2: Put quotes around pip executable to allow for spaces in paths (authored by kfunk).
Put quotes around pip executable to allow for spaces in paths
Oct 1 2017, 9:40 PM
kfunk closed D8003: Put quotes around pip executable to allow for spaces in paths.
Oct 1 2017, 9:40 PM · Windows, Craft
kfunk accepted D8003: Put quotes around pip executable to allow for spaces in paths.
Oct 1 2017, 9:38 PM · Windows, Craft
kfunk added a comment to D8003: Put quotes around pip executable to allow for spaces in paths.

Note: f"{someVar}" == someVar -- I'll fix and then push the patch. Thanks!

Oct 1 2017, 9:38 PM · Windows, Craft
kfunk updated the diff for D7975: Don't depend on kde: Git prefix being around.

Add one more fix

Oct 1 2017, 9:24 PM
kfunk added reviewers for D7975: Don't depend on kde: Git prefix being around: vonreth, Windows.
Oct 1 2017, 9:24 PM
kfunk requested changes to D8079: [PATCH] Windows: Fix compile after build system changed to cmake..
Oct 1 2017, 10:20 AM · Falkon, Windows

Sep 29 2017

kfunk committed R68:f1e0876e06bd: Restore compat with KDevelop 5.1 (authored by kfunk).
Restore compat with KDevelop 5.1
Sep 29 2017, 10:26 PM
kfunk committed R32:e5c4120a7292: Revert "app: Add 'Switch Application Language' button" (authored by kfunk).
Revert "app: Add 'Switch Application Language' button"
Sep 29 2017, 5:28 PM
kfunk added a reverting change for R32:f7764b706c3c: app: Add 'Switch Application Language' button: R32:e5c4120a7292: Revert "app: Add 'Switch Application Language' button".
Sep 29 2017, 5:28 PM
kfunk committed R32:f7764b706c3c: app: Add 'Switch Application Language' button (authored by kfunk).
app: Add 'Switch Application Language' button
Sep 29 2017, 5:23 PM
kfunk committed R68:dd03a91de376: Format sources (authored by kfunk).
Format sources
Sep 29 2017, 4:01 PM
kfunk committed R32:6e5f3fdf1b05: Remove outdated documentation (authored by kfunk).
Remove outdated documentation
Sep 29 2017, 2:12 PM
kfunk committed R68:986bf393e374: connectiontest: Fix more crashes (authored by kfunk).
connectiontest: Fix more crashes
Sep 29 2017, 2:09 PM
kfunk committed R68:53b2e0bd5aaa: connectiontest: Fix double-frees (authored by kfunk).
connectiontest: Fix double-frees
Sep 29 2017, 2:09 PM
kfunk committed R68:b7c434fe81c2: connectiontest: Speed up test execution (authored by kfunk).
connectiontest: Speed up test execution
Sep 29 2017, 2:09 PM
kfunk committed R32:845aa073731a: Streamline .categories files (authored by kfunk).
Streamline .categories files
Sep 29 2017, 12:01 PM
kfunk committed R32:1e723d29b85c: Use KDevelop version in kdevplatform/ (authored by kfunk).
Use KDevelop version in kdevplatform/
Sep 29 2017, 11:39 AM
kfunk committed R32:61c6fc881f90: platform: Make SOVERSION explicit (authored by kfunk).
platform: Make SOVERSION explicit
Sep 29 2017, 11:33 AM
kfunk committed R32:b1793437e29b: platform: Make SOVERSION explicit (authored by kfunk).
platform: Make SOVERSION explicit
Sep 29 2017, 11:33 AM
kfunk committed R32:7443911e3284: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Sep 29 2017, 11:13 AM
kfunk committed R32:8554e94926d3: Minor: Do not pass undefined variable in CMake (authored by kfunk).
Minor: Do not pass undefined variable in CMake
Sep 29 2017, 11:10 AM
kfunk committed R32:624802bbd906: platform: Cleanup SOVERSION handling (authored by kfunk).
platform: Cleanup SOVERSION handling
Sep 29 2017, 11:09 AM
kfunk committed R32:affee52f10dd: Bump patch version to complete SOVERSION update (authored by kfunk).
Bump patch version to complete SOVERSION update
Sep 29 2017, 11:09 AM
kfunk committed R68:8eb0df6d79a7: Modernize: Use nullptr where possible (authored by kfunk).
Modernize: Use nullptr where possible
Sep 29 2017, 9:42 AM
kfunk committed R68:22b2bf800744: Make compile (authored by kfunk).
Make compile
Sep 29 2017, 9:22 AM
kfunk committed R68:11677a4916eb: Don't install kdevxdebug.so twice (authored by kfunk).
Don't install kdevxdebug.so twice
Sep 29 2017, 9:04 AM
kfunk committed R32:ffee4672af87: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Sep 29 2017, 9:00 AM
kfunk committed R499:2b2f49f2db2d: kdev-xdebug: Ported to KF5 (authored by kfunk).
kdev-xdebug: Ported to KF5
Sep 29 2017, 8:58 AM
kfunk committed R68:abfa155f4805: Kill FindKDevPlatform.cmake, no longer needed (authored by kfunk).
Kill FindKDevPlatform.cmake, no longer needed
Sep 29 2017, 8:47 AM
kfunk committed R68:e4c50b8e4c53: Cleanup: Remove version info (authored by kfunk).
Cleanup: Remove version info
Sep 29 2017, 8:45 AM
kfunk committed R68:3c9ad396c152: More CMake fixes (authored by kfunk).
More CMake fixes
Sep 29 2017, 8:41 AM
kfunk committed R68:ac4797f99ff7: Skip tests if php-xdebug is not installed (authored by kfunk).
Skip tests if php-xdebug is not installed
Sep 29 2017, 8:36 AM
kfunk committed R68:ce38b64731f5: Modernize: Depend on CMake AUTOMOC (authored by kfunk).
Modernize: Depend on CMake AUTOMOC
Sep 29 2017, 8:36 AM
kfunk committed R68:555cb13504de: Initial (rough) port to KF5 (authored by kfunk).
Initial (rough) port to KF5
Sep 29 2017, 8:36 AM
kfunk committed R68:b7afe8240fa7: Modernize: Use override where possible (authored by kfunk).
Modernize: Use override where possible
Sep 29 2017, 8:36 AM
kfunk committed R32:af3d968aa020: cmake: Code cleanup (authored by kfunk).
cmake: Code cleanup
Sep 29 2017, 7:09 AM
kfunk committed R32:3de6e1a36576: cmake: Minor speed improvements (authored by kfunk).
cmake: Minor speed improvements
Sep 29 2017, 7:09 AM
kfunk committed R32:6004c8fb46c3: cmListFileLexer: Update from CMake v3.9.3 (authored by kfunk).
cmListFileLexer: Update from CMake v3.9.3
Sep 29 2017, 7:09 AM
kfunk committed R32:11bc71c177fa: plugins: Unify category names (authored by kfunk).
plugins: Unify category names
Sep 29 2017, 7:09 AM
kfunk closed D8045: plugins: Unify category names.
Sep 29 2017, 7:09 AM

Sep 28 2017

kfunk committed R32:514036de3149: platform: Set SOVERSION to 52 (authored by kfunk).
platform: Set SOVERSION to 52
Sep 28 2017, 8:41 PM
kfunk created D8045: plugins: Unify category names.
Sep 28 2017, 8:40 PM
kfunk committed R32:0cbacfb61aea: welcomepage: Cleanup CMake code (authored by kfunk).
welcomepage: Cleanup CMake code
Sep 28 2017, 8:09 PM
kfunk committed R32:903789c9a74f: welcomepage: Introduce categorized logging (authored by kfunk).
welcomepage: Introduce categorized logging
Sep 28 2017, 8:09 PM
kfunk committed R32:973033da2fe7: Merge remote-tracking branch 'origin/5.2' (authored by kfunk).
Merge remote-tracking branch 'origin/5.2'
Sep 28 2017, 7:26 PM
kfunk committed R32:47df49efb4fb: welcomepage: Fixup time related settings (authored by kfunk).
welcomepage: Fixup time related settings
Sep 28 2017, 7:09 PM
kfunk committed R32:1164e44fef49: welcomepage: Do not use BusyIndicator (authored by kfunk).
welcomepage: Do not use BusyIndicator
Sep 28 2017, 7:09 PM
kfunk committed R32:88da78897ba7: welcomepage: Add CMake option for qmljs debugging (authored by kfunk).
welcomepage: Add CMake option for qmljs debugging
Sep 28 2017, 7:09 PM

Sep 27 2017

kfunk added a comment to T7064: Setup Krita builds for Windows on the Binary Factory.

@bcooksley I don't think so.

Sep 27 2017, 8:35 AM · Sysadmin
kfunk requested changes to D8003: Put quotes around pip executable to allow for spaces in paths.

Can you try passing the command as a list?

Sep 27 2017, 7:28 AM · Windows, Craft

Sep 26 2017

kfunk added a comment to T7064: Setup Krita builds for Windows on the Binary Factory.

For my part: I think it's understandable that for some project maintainers, it's not feasible to use Craft (probably not even in future).

Sep 26 2017, 11:39 AM · Sysadmin