For now, at each level, we delete the existing elements (walls, holes...) and create them again for a new level.
It takes time to create and delete the elements (especially with slow computers/tablets). The aim is to have a pool of elements that will be created at start of the activity and that we can use to do the elements instead of creating all of them at each level.
We have to find a compromise between the number of elements created at start (no need to create 100 walls at the beginning, it will take too much time too) and the number of elements we may need for the next level to avoid to have to wait too much for the creation of the level.

Thank you,
merged in:
https://cgit.kde.org/gcompris.git/commit/?id=c7a267ace1e820d0a7b58e0c3d6fc7b87436a211
https://cgit.kde.org/gcompris.git/commit/?id=040e1d61ef2f5e02e8dcc9943c9a779572b2bed3
https://cgit.kde.org/gcompris.git/commit/?id=7d3b8ecf5c37552d03391d9427ef959de6c8a17d

Merged in with small changes: https://commits.kde.org/gcompris/863b5856e5dd0f96b7a19b11040cab5e538297d3

Thank you (and Yuri for the explanation), it's commited in https://cgit.kde.org/gcompris.git/commit/?id=930060c5810b0b5004ef561829b3891e0909641a

Can you please provide your email so I can set you as author of the commit?

Thank you! Seems good to me, I'll test it tonight and push it if it works fine

You can publish a new diff in phabricator directly: https://phabricator.kde.org/differential/diff/create/ once you have cloned the code and done the patch.

Hi Christophe. Thanks for the report. Would you like to work on it or is it open to fix?

In D18230#450369, @echarruau wrote:

Hi,
I am working from a fresh version of master and get the same problem when I want to apply diff for both D18230.diff

and D18600.diff.

error: patch failed: src/activities/activities.txt:119
Could you on your side apply your patch to see if it is working?
Thanks

In D20245#447012, @dekumar wrote:

With reference to @echarruau question on irc. This is how the json strucuture will be maintained and loaded to the cktsim() library https://pastebin.com/JkmhVR9x

Here 'g' : ground, 'w': wire, 'r', resistor of the components is also stored in form of json with them. I ran the cktsim library with this json and gives the output "The json strucuture loaded is valid". The result will be computed in the same way, as there is a result dictionary maintain for every node in cktsim() of the library.

Thanks!

In D20245#443257, @dekumar wrote:

I have done the following piece of work:

1. Created the whole activity base.
2. Checked whether the way of loading the dataset file can be kept similar to digital_electricity or not. The same dataset format used was same as one in the digital electricity and there is no issue.
3. The ListWidget.qml, terminalpoint.qml and DragListItem.qml files were used from the digital elctricity and it works fine.
4. Level was created using bulb and battery which is not fully working, still needs to be integrated with the external library.
5. Function to zoomin, zoomout the components were used and it works fine.
6. Taken few resources from the Gtk+ version.
   
   I will work on the next part of this activity now, the work of integrating the external library. The external library code needs to remodeled, mainly the schematic part so I will need some time to complete this one:) Thanks!

A few notes:

• The selected question should have a visual feedback
• There should be scroll buttons on the side to tell there are questions outside the visual zone
• The tab button does not give focus in an intuitive order (not from left to right or top to bottom)
• For text answers, the text area should contain multiple lines. Having only one line prevents knowing what has been written before.
• Questions are outside panel range and answer area can override answer: https://pasteboard.co/I7XcMoO6.png

Just a quick note, can you please fix those:
questions_answers.diff:740: trailing whitespace.

implicitHeight: Math.max(grid.cellHeight / 2, 40)

questions_answers.diff:981: trailing whitespace.

for( var i = 0; i < items.questions.length; i++){

questions_answers.diff:1166: trailing whitespace.

https://commits.kde.org/krusader/c6db82bcb2d61e34e1c8bfb87aade25c7fed9093

I'm not planning on being an active contributor, this PR is just to fix the CI. I let the Krusader handle the minimal required Qt version :)

WIP: https://cgit.kde.org/gcompris.git/log/?h=QtControls2
Missing:

• main.cpp (StackView)
• calendar (Calendar, no equivalent in QuickControls 2.0)

@dekumar, @echarruau: Please take a look at these changes: https://pastebin.com/1TMefRZ9 and check if it still works and what's expected.
On code side, the last change that could be required would be to use a Repeater for handling the AnswerButton more cleanly but it's not mandatory...

Committed in https://cgit.kde.org/websites/gcompris-net.git/commit/?id=a26db701760123d4a46f4864c598d34547deeed1

Merged in https://cgit.kde.org/gcompris.git/commit/?id=ac177e6538e46b923abc272b456935e21f26ef96

@dekumar there is a list above, feel free to test the activity and see what is still left to do. Then, feel free to add any improvements that can be useful for the children to learn about