In D24276#548330, @mart wrote:

this only affects the old standalone executable, right?

• Add speech synthesis engine selection combobox to general klipper settings page.

Yep, Abandoning.

In D24102#541529, @whiting wrote:

In D24102#539859, @sander wrote:

Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui). I agree that you probably do want them changed, but please do so in a separate patch.

Besides, can you please post your patch as a merge request on https://invent.kde.org/kde/okular/ ? That is not purely cosmetic -- invent.kde.org has a CI system.

Besides that: I like the patch!

Ok, I'll fix the whitespace and move it to the other review tool, no problem.

In D24102#539859, @sander wrote:

Sorry for being a pain, but your patch contains lots of whitespace changes again (in conf/dlgaccessibilitybase.ui). I agree that you probably do want them changed, but please do so in a separate patch.

Besides, can you please post your patch as a merge request on https://invent.kde.org/kde/okular/ ? That is not purely cosmetic -- invent.kde.org has a CI system.

Besides that: I like the patch!

Does anyone have any opinion on this change?

• Add speech synthesis engine selection combobox to general klipper settings page.

• Fix building okular without QTextToSpeech by adding ifdefs.

In D24102#537832, @aacid wrote:

Sounds sensible, what about the TODO you have on the top?

• When tts engine is changed via okular settings recreate tts object.

• Only enable Pause or Resume when speaking or paused.

Changed engines stringlist to const and use for instead of foreach.

Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard instead of the 3 it has now (Modifier Keys, Keyboard Filters and Activation Gestures) The top groupbox of Activation Gestures items could be moved to their respective groupboxes also so there are less groupboxes on the Keyboard tab than before on these 3 tabs.

• Add user okular user setting for which QtSpeech engine to use.

Removed whitespace changes.

Awesome, k, I nuked my branch when I modified it. I'll just push the commit on the 5.0 branch and close this revision, makes sense.

Wow, so looking forward to gitlab. So after a revision has been accepted what's the preferred way to land it? merge? cherry-pick? just rebase on the 5.0 branch and push?

Changed logic to match review comments.

I'm open to having this option also hide asset accounts with zero balance, though that might be better as a separate option. Personally I'd like to continue to see my zero balance assets to be reminded I need to put something in them at some point (or close them if they are not being useful, etc.)

Looks good to me. Thanks for doing that fix.

Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting the url with the KUrlComboBox we give to the KUrlRequester via it's setUrl method. Looking at KUrlComboBox::setUrl it's blocking signals in the body of setUrl and since we are not connecting to the QLineEdit anymore we never get that signal.

Looks good to me. thanks again.

Looks good to me except for the flite bits. I'll go remind my self how to tell QtSpeech to use the flite backend/plugin, but it's definitely optional.

Looks good to me. Thank you for taking this on.

Yes, this should go in the frameworks branch, I'll see if I can get the frameworks branch merged to master this week.

Hmm QScreen::grabWindow is already grabbing pixmap data from both screens here. I wonder why it needs the QScreen object at all. At any rate it seems to work fine.

Looks like this is already in kmag master. I'll see if I can sort out how to decide which screen to grab from.