Put it down to a mixture of exhaustion and NLD (an honorary member of the autism spectrum).
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Mar 10 2020
In D27925#624073, @ognarb wrote:I don't knwo there you read this, but in the Frameworks Coding Style there is a whitespace between if and (. See https://techbase.kde.org/Policies/Frameworks_Coding_Style#Whitespace
Fixed copyright statements.
Compiles and works for me.
On a related note, I uploaded another patch that reformats the rest of Yakuake's if statements to match the ones here.
Added copyright statement
Mar 8 2020
In D27925#624022, @trmdi wrote:Look weird. Don't you misunderstand it?
Fixed formatting and added comments
- Merge branch 'master' into 154686-Resize_on_title_drag
- * Now conforms to KDE style guidelines
- * C++ dynamic cast instead of C cast
- * renamed parent to window in TitleBar::mouseMoveEvent()
- Merge branch 'master' into 154686-Resize_on_title_drag
- Merge branch 'master' into 154686-Resize_on_title_drag
- TitleBar now uses the vertical-resize cursor
- Fixed titlebar buttons using vertical-size cursor
Fixed menu buttons using vertical-size cursor.
The Title Bar now indicates it is resizeable with a vertical size cursor.
In D22227#620201, @ngraham wrote:@ryanmccoskrie sorry this got lost. Would you be interested in finishing it up so we can get it landed?
Aug 14 2019
In D22227#495177, @hein wrote:The resize should happen in the same steps as the config allows (and reads/writes), otherwise the UI will end up being confused, in particular the menu.
Switched from C style cast to dynamic cast.
Jul 7 2019
Works nicely for me.
Adjusted formatting to fit KDE style guidelines.
Jul 5 2019
Jul 4 2019
Works with foreground tab. Will you consider modifying this to work with background tabs as well?
Jul 3 2019
Submitted by accident.
Got the whole change into request, not just a one-line touch up.