Feed Advanced Search

Mar 10 2020

ryanmccoskrie abandoned D27925: Reformatted all if statements.

Put it down to a mixture of exhaustion and NLD (an honorary member of the autism spectrum).

Mar 10 2020, 3:11 AM
ryanmccoskrie added a comment to D27925: Reformatted all if statements.

I don't knwo there you read this, but in the Frameworks Coding Style there is a whitespace between if and (. See https://techbase.kde.org/Policies/Frameworks_Coding_Style#Whitespace

Mar 10 2020, 2:55 AM
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Fixed copyright statements.

Mar 10 2020, 2:48 AM · Yakuake
ryanmccoskrie added a comment to D26744: Support opening new sessions in current working dir.

Compiles and works for me.

Mar 10 2020, 2:01 AM
This is a test notification, sent at Tue, Mar 10, 2:39 PM.
Mar 10 2020, 1:39 AM
ryanmccoskrie added a comment to D22227: Add support for resizing by dragging the title bar.

On a related note, I uploaded another patch that reformats the rest of Yakuake's if statements to match the ones here.

Mar 10 2020, 1:33 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Added copyright statement

Mar 10 2020, 1:30 AM · Yakuake

Mar 8 2020

ryanmccoskrie added a comment to D27925: Reformatted all if statements.

Look weird. Don't you misunderstand it?

Mar 8 2020, 10:21 AM
ryanmccoskrie requested review of D27925: Reformatted all if statements.
Mar 8 2020, 3:21 AM
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Fixed formatting and added comments

Mar 8 2020, 2:59 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.
  • Merge branch 'master' into 154686-Resize_on_title_drag
  • * Now conforms to KDE style guidelines
  • * C++ dynamic cast instead of C cast
  • * renamed parent to window in TitleBar::mouseMoveEvent()
  • Merge branch 'master' into 154686-Resize_on_title_drag
  • Merge branch 'master' into 154686-Resize_on_title_drag
  • TitleBar now uses the vertical-resize cursor
  • Fixed titlebar buttons using vertical-size cursor
Mar 8 2020, 2:46 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Fixed menu buttons using vertical-size cursor.

Mar 8 2020, 1:37 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

The Title Bar now indicates it is resizeable with a vertical size cursor.

Mar 8 2020, 1:03 AM · Yakuake
ryanmccoskrie added a comment to D22227: Add support for resizing by dragging the title bar.

@ryanmccoskrie sorry this got lost. Would you be interested in finishing it up so we can get it landed?

Mar 8 2020, 12:22 AM · Yakuake

Aug 14 2019

ryanmccoskrie added a comment to D22227: Add support for resizing by dragging the title bar.
In D22227#495177, @hein wrote:

The resize should happen in the same steps as the config allows (and reads/writes), otherwise the UI will end up being confused, in particular the menu.

Aug 14 2019, 10:24 PM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Switched from C style cast to dynamic cast.

Aug 14 2019, 10:21 PM · Yakuake

Jul 7 2019

ryanmccoskrie added a comment to D21631: Raise the active session after renaming a tab.

Works nicely for me.

Jul 7 2019, 7:43 AM
ryanmccoskrie added inline comments to D22227: Add support for resizing by dragging the title bar.
Jul 7 2019, 3:55 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Adjusted formatting to fit KDE style guidelines.

Jul 7 2019, 3:51 AM · Yakuake

Jul 5 2019

ryanmccoskrie added a member for Amarok: ryanmccoskrie.
Jul 5 2019, 6:53 AM
ryanmccoskrie added a watcher for Amarok: ryanmccoskrie.
Jul 5 2019, 6:53 AM
ryanmccoskrie added a member for Kile: ryanmccoskrie.
Jul 5 2019, 6:49 AM
ryanmccoskrie added a watcher for Kile: ryanmccoskrie.
Jul 5 2019, 6:49 AM

Jul 4 2019

ryanmccoskrie added a comment to D21631: Raise the active session after renaming a tab.

Works with foreground tab. Will you consider modifying this to work with background tabs as well?

Jul 4 2019, 3:27 AM

Jul 3 2019

ryanmccoskrie abandoned D22226: PLEASE IGNORE: Inital work towards resizing by dragging on the title bar..

Submitted by accident.

Jul 3 2019, 3:00 AM
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.

Got the whole change into request, not just a one-line touch up.

Jul 3 2019, 2:58 AM · Yakuake
ryanmccoskrie updated the diff for D22227: Add support for resizing by dragging the title bar.
Jul 3 2019, 2:55 AM · Yakuake
ryanmccoskrie updated the summary of D22226: PLEASE IGNORE: Inital work towards resizing by dragging on the title bar..
Jul 3 2019, 2:48 AM
ryanmccoskrie added a reviewer for D22227: Add support for resizing by dragging the title bar: Yakuake.
Jul 3 2019, 2:45 AM · Yakuake
ryanmccoskrie requested review of D22227: Add support for resizing by dragging the title bar.
Jul 3 2019, 2:24 AM · Yakuake
ryanmccoskrie requested review of D22226: PLEASE IGNORE: Inital work towards resizing by dragging on the title bar..
Jul 3 2019, 1:47 AM

Jun 25 2019

ryanmccoskrie added a member for Yakuake: ryanmccoskrie.
Jun 25 2019, 11:08 PM
ryanmccoskrie added a watcher for Yakuake: ryanmccoskrie.
Jun 25 2019, 11:08 PM