Reformatted all if statements
AbandonedPublic
Actions

Authored by ryanmccoskrie on Mar 8 2020, 3:21 AM.

Details

Reviewers

trmdi
ognarb

Group Reviewers

Yakuake

Summary

Replaced all instances of

if (

with

if(

To comply with current KF5 style guidelines

Diff Detail

Repository

R369 Yakuake

Lint

Lint Skipped

Unit

Unit Tests Skipped

ryanmccoskrie requested review of this revision.Mar 8 2020, 3:21 AM

ryanmccoskrie created this revision.

Look weird. Don't you misunderstand it?

trmdi requested changes to this revision.Mar 8 2020, 4:39 AM

This revision now requires changes to proceed.Mar 8 2020, 4:39 AM

In D27925#624022, @trmdi wrote:

Look weird. Don't you misunderstand it?

Apparently my titlebar resize patch shouldn't have a space between "if" and "(" so I changed the rest of Yakuake to match.

In D27925#624066, @ryanmccoskrie wrote:

In D27925#624022, @trmdi wrote:

Look weird. Don't you misunderstand it?

Apparently my titlebar resize patch shouldn't have a space between "if" and "(" so I changed the rest of Yakuake to match.

The spaces are needed. Do not remove them.

I don't knwo there you read this, but in the Frameworks Coding Style there is a whitespace between if and (. See https://techbase.kde.org/Policies/Frameworks_Coding_Style#Whitespace

In D27925#624073, @ognarb wrote:

I don't knwo there you read this, but in the Frameworks Coding Style there is a whitespace between if and (. See https://techbase.kde.org/Policies/Frameworks_Coding_Style#Whitespace

*Scrunches face up in confusion*

https://community.kde.org/Policies/Frameworks_Coding_Style#Whitespace says the opposite.

I actually prefer the techbase.kde.org policy over the community.kde.org policy but was told to follow the latter.

I think you may have misread the coding style or misinterpreted what you saw - both style documents specify a space between the if and the (

Put it down to a mixture of exhaustion and NLD (an honorary member of the autism spectrum).

Revision Contents
Changeset List

			Path	Packages
M			app/firstrundialog.cpp (4 lines)
M			app/mainwindow.cpp (222 lines)
M			app/session.cpp (126 lines)
M			app/sessionstack.cpp (226 lines)
M			app/skin.cpp (16 lines)
M			app/splitter.cpp (4 lines)
M			app/tabbar.cpp (194 lines)
M			app/terminal.cpp (46 lines)
M			app/titlebar.cpp (18 lines)
M			app/visualeventoverlay.cpp (46 lines)