Differential D21631

Raise the active session after renaming a tab
AbandonedPublic
Actions

Authored by mschiller on Jun 6 2019, 5:51 PM.

Details

Reviewers
hein
Group Reviewers
Yakuake
KDE Applications
Summary

When changing the name of a Tab the terminal is not focused afterwards.
This patch resolves this by raising the currently active session if the
tabs title of that session is changed.

BUG: 408374

Test Plan

Change the name of the active tab. The currently active session should be focued now.

Diff Detail

Repository
R369 Yakuake
Branch
raiseaftertabrename
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13605
Build 13623: arc lint + arc unit
mschiller requested review of this revision.Jun 6 2019, 5:51 PM
mschiller created this revision.
ryanmccoskrie added a subscriber: ryanmccoskrie.Jul 4 2019, 3:27 AM

Works with foreground tab. Will you consider modifying this to work with background tabs as well?

mschiller updated this revision to Diff 61143.Jul 4 2019, 2:05 PM
  • Reraise the session also if a other tab has been renamed
ryanmccoskrie added a comment.Jul 7 2019, 7:43 AM

Works nicely for me.

mschiller abandoned this revision.Jun 3 2020, 6:39 PM

moved to invent.kde.org

Revision Contents
Changeset List

PathPackages
Mapp/mainwindow.cpp (3 lines)
Mapp/tabbar.h (1 line)
Mapp/tabbar.cpp (2 lines)

Diff 61143

View Options

app/mainwindow.cpp

Loading...
View Options

app/tabbar.h

Loading...
View Options

app/tabbar.cpp

Loading...