I think you need to check quadraticEquation() function. It might be that the check for discriminant is too severe and you might need to change that to D <= 1e-14 or something. If it helps, then just change it and move your rectangle check into fillHalfBrushDiff() as a sanity check.

Mar 20 2019, 2:04 PM · Krita

dkazakov requested changes to D19881: Fix Sequential Iterator assert on invalid rectangles.

I have checked the code and I'm not sure if it okay to make such manual checks for the rects to workaround the problem. It would be better to fix the original problem and find out why such invalid rect is generated at all?

Mar 20 2019, 1:47 PM · Krita

dkazakov updated the title for P350 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.

Mar 20 2019, 1:36 PM

dkazakov added a reviewer for D19906: Krita crashes when selecting transform tool while using a colorize mask: dkazakov.

Mar 20 2019, 1:13 PM · Krita

dkazakov committed R37:05d988b3f922: Fix compilation on Windows (authored by dkazakov).

Fix compilation on Windows

Mar 20 2019, 1:04 PM

dkazakov committed R37:feee48f529d7: Add a unittest for memory fragmentation caused by tile manager (authored by dkazakov).

Add a unittest for memory fragmentation caused by tile manager

Mar 20 2019, 11:40 AM

dkazakov added a comment to D19881: Fix Sequential Iterator assert on invalid rectangles.

I will check the patch today

Mar 20 2019, 8:58 AM · Krita

Mar 19 2019

dkazakov committed R37:c475ecbea807: Fix infinite growing of selection when applying move tool multiple times (authored by dkazakov).

Fix infinite growing of selection when applying move tool multiple times

Mar 19 2019, 3:02 PM

dkazakov committed R37:823e916c2e6c: Recover clearing of selection that is placed outside canvas (authored by dkazakov).

Recover clearing of selection that is placed outside canvas

Mar 19 2019, 3:02 PM

dkazakov committed R37:d33b5213dd9d: Add barrier for initialization of MoveSelectionStrokeStrategy (authored by dkazakov).

Add barrier for initialization of MoveSelectionStrokeStrategy

Mar 19 2019, 3:02 PM

dkazakov committed R37:125337bee17a: Fix move tool to handle selection that is completely outside canvas (authored by dkazakov).

Fix move tool to handle selection that is completely outside canvas

Mar 19 2019, 3:02 PM

dkazakov committed R37:237db89620e6: Finally fix building on Qt 5.9... (authored by dkazakov).

Finally fix building on Qt 5.9...

Mar 19 2019, 2:27 PM

dkazakov committed R37:83672cff6a78: Fix build on Qt 5.9 (authored by dkazakov).

Fix build on Qt 5.9

Mar 19 2019, 11:29 AM

dkazakov committed R37:cdc0c044fb9d: Rebase HDR patch on Qt 5.12.2 (authored by dkazakov).

Rebase HDR patch on Qt 5.12.2

Mar 19 2019, 8:55 AM

dkazakov committed R37:7ed4cc490934: Try harder fixing building on Qt 5.9 (authored by dkazakov).

Try harder fixing building on Qt 5.9

Mar 19 2019, 8:05 AM

Mar 18 2019

dkazakov committed R37:2924b7b976e3: Make Krita compile on Qt 5.9 (authored by dkazakov).

Make Krita compile on Qt 5.9

Mar 18 2019, 2:12 PM

dkazakov accepted D19776: Better pointer handling in KisMirrorManager and KisMirrorAxis.

Looks perfect! Please push! :)

Mar 18 2019, 1:59 PM · Krita

dkazakov committed R37:91963c577fad: Update Qt patches to support tablet in HiDPI mode on X11 (authored by dkazakov).

Update Qt patches to support tablet in HiDPI mode on X11

Mar 18 2019, 12:09 PM

Mar 17 2019

dkazakov updated the title for P345 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.

Mar 17 2019, 6:15 PM

dkazakov accepted D19776: Better pointer handling in KisMirrorManager and KisMirrorAxis.

The patch looks fine, please push it!

Mar 17 2019, 4:22 PM · Krita

dkazakov committed R37:44cd9e8d08bc: Add sanity checks for debugging tile releasing (authored by dkazakov).

Add sanity checks for debugging tile releasing

Mar 17 2019, 4:08 PM

dkazakov committed R37:da26d46c7767: Fix race condition in projection cache in KisLayer (authored by dkazakov).

Fix race condition in projection cache in KisLayer

Mar 17 2019, 4:08 PM

dkazakov committed R37:195d84258630: Fix incorrect tile access in KisPaintDevice::clearSelection() (authored by dkazakov).

Fix incorrect tile access in KisPaintDevice::clearSelection()

Mar 17 2019, 4:08 PM

dkazakov committed R37:f61672b78fbf: Fix a race condition in the lockfree hash table (authored by dkazakov).

Fix a race condition in the lockfree hash table

Mar 17 2019, 4:08 PM

dkazakov committed R37:9b827396e718: Remove a dedicated counter for the amount of objects in the garbage collector (authored by dkazakov).

Remove a dedicated counter for the amount of objects in the garbage collector

Mar 17 2019, 4:08 PM

Mar 15 2019

dkazakov committed R37:062813134de4: Fix to Modulo Shift Continuous (authored by Reptorian).

Fix to Modulo Shift Continuous

Mar 15 2019, 10:11 PM

dkazakov closed D19640: Fix to Modulo Shift Continuous.

Mar 15 2019, 10:11 PM · Krita

dkazakov accepted D16438: Add textures for experiment brush .

The patch looks perfectly fine now! Please push :)

Mar 15 2019, 9:36 PM · Krita

Mar 13 2019

dkazakov updated the title for P344 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.

Mar 13 2019, 6:11 PM

dkazakov committed R37:5c0ca4e3d681: Possibly fix an assert in KisTiledExtentManager (authored by dkazakov).

Possibly fix an assert in KisTiledExtentManager

Mar 13 2019, 5:26 PM

dkazakov committed R37:2e5ee146289a: Fix a memory leak on data manager deletion (authored by dkazakov).

Fix a memory leak on data manager deletion

Mar 13 2019, 5:26 PM

dkazakov committed R37:0f4bcc3c9d12: Possibly fix lockfree hash table threading problems (authored by dkazakov).

Possibly fix lockfree hash table threading problems

Mar 13 2019, 5:26 PM

Mar 12 2019

dkazakov committed R37:b3ec22593c96: Allow to export animation to PNG sequence using commandline (authored by KonstantinDmitriev).

Allow to export animation to PNG sequence using commandline

Mar 12 2019, 1:42 PM

dkazakov closed D19706: Allow to export animation to PNG sequence using commandline.

Mar 12 2019, 1:42 PM · Krita

dkazakov accepted D19706: Allow to export animation to PNG sequence using commandline.

It should be fine now :)

Mar 12 2019, 1:35 PM · Krita

dkazakov added a comment to D19706: Allow to export animation to PNG sequence using commandline.

In D19706#429652, @KonstantinDmitriev wrote:

In the future the functionality of this option can be extended to export video files as well. So, I am proposing to keep current name to avoid having two options for exporting animation in the future.

Mar 12 2019, 12:50 PM · Krita

dkazakov added a comment to D19706: Allow to export animation to PNG sequence using commandline.

The patch works fine. The only concern I have is the naming of the option. This very option exports "sequence", not "animation". Actually, we can either export a "video" or a "sequence". We have no term "animation" in the main dialog :)

Mar 12 2019, 12:20 PM · Krita

dkazakov added a comment to D19706: Allow to export animation to PNG sequence using commandline.

Does it mean that the animation is exported with the "lastly used configuration"?

Mar 12 2019, 11:22 AM · Krita

dkazakov committed R37:c8a555d0dab2: Remove unused pointers to KisImage (authored by dkazakov).

Remove unused pointers to KisImage

Mar 12 2019, 9:51 AM

dkazakov committed R37:f75244da91dc: Fix openGL resource leakage on destruction of small color selector (authored by dkazakov).

Fix openGL resource leakage on destruction of small color selector

Mar 12 2019, 9:33 AM

dkazakov committed R37:a537fe40d480: Fix loading of a shader for Small Color Selector on Linux (authored by dkazakov).

Fix loading of a shader for Small Color Selector on Linux

Mar 12 2019, 8:20 AM

Mar 11 2019

woltherav awarded R37:af13a646ad31: [FEATURE] Implement mirroring for Quick Brush a Love token.

Mar 11 2019, 5:27 PM

dkazakov committed R37:ec417d6c8217: Remove our own fork of Qt's tablet support on X11 (authored by dkazakov).

Remove our own fork of Qt's tablet support on X11

Mar 11 2019, 4:22 PM

dkazakov committed R37:af13a646ad31: [FEATURE] Implement mirroring for Quick Brush (authored by dkazakov).

[FEATURE] Implement mirroring for Quick Brush

Mar 11 2019, 3:22 PM

dkazakov accepted D19597: Make a staggered second row of preset icons in the popup palette for large values..

The patch looks and works fine. I'm okay with pushing it into master.

Mar 11 2019, 1:58 PM · Krita

dkazakov committed R37:a3193fe273c3: Add a hacky patch that ensures QTabletEvents to be ignored in distribution… (authored by dkazakov).

Add a hacky patch that ensures QTabletEvents to be ignored in distribution…

Mar 11 2019, 1:50 PM

dkazakov committed R37:62495eaad79c: Restore proper tablet event compression (authored by dkazakov).

Restore proper tablet event compression

Mar 11 2019, 1:50 PM

dkazakov updated the title for P342 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.

Mar 11 2019, 11:00 AM

Mar 10 2019

dkazakov requested changes to D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.

Did you try to compile your patch before uploading for review? It looks like it doesn't compile.

Mar 10 2019, 7:18 PM · Krita

dkazakov committed R37:2e037a98fd7e: Fix tablet support in Qt's XCB (on X11 and OSX) (authored by dkazakov).

Fix tablet support in Qt's XCB (on X11 and OSX)

Mar 10 2019, 6:35 PM

dkazakov accepted D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.

Mar 10 2019, 1:28 PM · Krita

Mar 9 2019

dkazakov added a comment to T8623: Sprint for onboarding goal.

Hi, all! I'm sorry, I found out that I will not manage to come to the sprint this time :( If you happen to gather next winter, I might try to join though.

Mar 9 2019, 5:44 PM · Goal Setting

Mar 2 2019

dkazakov committed R37:917d6980fce6: Fix minimum frame grid size on Windows (authored by dkazakov).

Fix minimum frame grid size on Windows

Mar 2 2019, 3:19 PM

Feb 28 2019

dkazakov committed R37:366731e1b2ee: Fix crash when rendering animation with a lot of frames on Windows (authored by dkazakov).

Fix crash when rendering animation with a lot of frames on Windows

Feb 28 2019, 3:27 PM

dkazakov requested changes to D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.

Sorry, but not all the changes are fixed yet

Feb 28 2019, 3:03 PM · Krita

dkazakov committed R37:3308396d1c72: Try to fix EXR-free build harder (authored by dkazakov).

Try to fix EXR-free build harder

Feb 28 2019, 2:18 PM

dkazakov added inline comments to D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.

Feb 28 2019, 1:48 PM · Krita

dkazakov added a comment to D19412: Ported Q_ASSERT to KIS_ASSERT in Selection Tools.

It would be preferable to use KIS_ASSERT_RECOVER and KIS_ASSERT_RECOVER_RETURN (and their _SAFE counterparts) here :)

Feb 28 2019, 12:29 PM · Krita

dkazakov committed R37:3c33fea930ef: Disable Float16 versions of LcmsRGBP2020PQColorSpace when OpenEXR is not present (authored by dkazakov).

Disable Float16 versions of LcmsRGBP2020PQColorSpace when OpenEXR is not present

Feb 28 2019, 9:45 AM

Feb 27 2019

dkazakov committed R37:d585de6b8631: Fixed: Using color picker while using Multibrush tool cause Krita to freeze (authored by ashwind).

Fixed: Using color picker while using Multibrush tool cause Krita to freeze

Feb 27 2019, 3:36 PM

dkazakov closed D19261: Fixed: Using color picker while using Multibrush tool cause Krita to freeze.

Feb 27 2019, 3:35 PM · Krita

dkazakov committed R37:b047a4677a71: Restore error dialog when the resulting image size is not even (authored by dkazakov).

Restore error dialog when the resulting image size is not even

Feb 27 2019, 3:27 PM

dkazakov committed R37:9740249011e2: Make relative file fetching in animation renderer a bit more robust (authored by dkazakov).

Make relative file fetching in animation renderer a bit more robust

Feb 27 2019, 3:27 PM

dkazakov committed R37:cbf812208bd9: Merge remote-tracking branch 'origin/master' into kazakov/hdr-support (authored by dkazakov).

Merge remote-tracking branch 'origin/master' into kazakov/hdr-support

Feb 27 2019, 8:18 AM

Feb 26 2019

dkazakov committed R37:c0f34663aea5: Implemented HDR metadata editing when rendering video files (authored by dkazakov).

Implemented HDR metadata editing when rendering video files

Feb 26 2019, 9:00 PM

dkazakov committed R37:fce99ed16715: Add forgotten license header (authored by dkazakov).

Add forgotten license header

Feb 26 2019, 9:00 PM

dkazakov committed R37:d205dbe95856: Make getPropertyLazy() work for strings (authored by dkazakov).

Make getPropertyLazy() work for strings

Feb 26 2019, 9:00 PM

dkazakov committed R37:f9154f5b463f: Remove saving of the FFMpeg path from KisConfig (authored by dkazakov).

Remove saving of the FFMpeg path from KisConfig

Feb 26 2019, 9:00 PM

dkazakov committed R37:0e76ca67ee15: Make KisConfig create KisPropertiesConfiguration itself (authored by dkazakov).

Make KisConfig create KisPropertiesConfiguration itself

Feb 26 2019, 9:00 PM

dkazakov committed R37:06bec48fe3fe: Refactor Animation Export rendering code and HDR video support (authored by dkazakov).

Refactor Animation Export rendering code and HDR video support

Feb 26 2019, 9:00 PM

dkazakov committed R37:1e91e0bfb07f: Force PNG files to be converted into Rec 2020 PQ when HDR option is active (authored by dkazakov).

Force PNG files to be converted into Rec 2020 PQ when HDR option is active

Feb 26 2019, 9:00 PM

dkazakov created P337 (An Untitled Masterwork) in the S1 KDE Community space.

Feb 26 2019, 11:15 AM

Feb 25 2019

dkazakov committed R37:60275ee178ac: Merge remote-tracking branch 'origin/master' into HEAD (authored by dkazakov).

Merge remote-tracking branch 'origin/master' into HEAD

Feb 25 2019, 3:07 PM

dkazakov added a reviewer for D19261: Fixed: Using color picker while using Multibrush tool cause Krita to freeze: dkazakov.

Feb 25 2019, 8:29 AM · Krita

Feb 19 2019

dkazakov updated the diff for D19155: Add HDR painting mode to Krita.

bb2a943350 Fix crash when the small color selector has zero size
4f47eca44e Cleanup some forgotten lines
05d5915a5a Remove pure virtual from KisColorSelectorComponent::setColor()
98f0a51d62 Add GPL2+ license to new files
4181901f1c PNG converter doesn't need half.h anymore
0347350087 Enable HDR mode in the autobuild script