Feed Advanced Search

Yesterday

dkazakov committed R37:d82899b0d67e: Fix loading of pre-krita-4.0 transform masks (authored by dkazakov).
Fix loading of pre-krita-4.0 transform masks
Tue, Apr 23, 8:54 PM
dkazakov committed R37:59b7e838dc5c: Fix TIFF export filter to flatten images with group layers (authored by dkazakov).
Fix TIFF export filter to flatten images with group layers
Tue, Apr 23, 7:47 PM
dkazakov committed R37:a0f462da8501: Fix memory leak in QGIFLibHandler (authored by dkazakov).
Fix memory leak in QGIFLibHandler
Tue, Apr 23, 5:23 PM
dkazakov committed R37:4443c7065791: Fix line length in GIF export (authored by dkazakov).
Fix line length in GIF export
Tue, Apr 23, 5:23 PM
dkazakov committed R37:033fd2814482: Remove unused variable in SvgUtil::parseViewBox (authored by dkazakov).
Remove unused variable in SvgUtil::parseViewBox
Tue, Apr 23, 4:47 PM
dkazakov committed R37:779589e5afd7: Try to estimate SVG document size by reading toplevel 'viewBox' tag (authored by dkazakov).
Try to estimate SVG document size by reading toplevel 'viewBox' tag
Tue, Apr 23, 4:47 PM
dkazakov committed R37:18dfc4d8ee25: Fix loading SVG with omitted commands (authored by dkazakov).
Fix loading SVG with omitted commands
Tue, Apr 23, 4:47 PM
dkazakov added a comment to D20759: Add gitlab workflow to Untranslatable Pages.

The text looks very nice, detailed and precise! :) I don't see any problems in it. If we find any problems/inconsistencies, we can always adjust it on the fly :)

Tue, Apr 23, 10:07 AM · Krita: Manual

Mon, Apr 22

dkazakov committed R37:741608695618: Add sanity check for the image being idle after cloning (authored by dkazakov).
Add sanity check for the image being idle after cloning
Mon, Apr 22, 7:42 PM
dkazakov committed R37:f984eab0aa72: Fix artifacts when saving vector layers into PNG files (authored by dkazakov).
Fix artifacts when saving vector layers into PNG files
Mon, Apr 22, 7:42 PM
dkazakov committed R37:d47ece40309f: Fix crash when merging back split alpha (authored by dkazakov).
Fix crash when merging back split alpha
Mon, Apr 22, 8:06 AM

Sat, Apr 20

dkazakov committed R37:dd3746f67dba: Fix ASAN crash when creating a guide (authored by dkazakov).
Fix ASAN crash when creating a guide
Sat, Apr 20, 5:02 PM
dkazakov committed R37:217074f353bf: BUG:404975 Fix hard to select color in vector objects (authored by dkazakov).
BUG:404975 Fix hard to select color in vector objects
Sat, Apr 20, 2:04 PM
dkazakov committed R37:c2c5fdcca5bd: BUG:404975 Fix hard to select color in vector objects (authored by scottpetrovic).
BUG:404975 Fix hard to select color in vector objects
Sat, Apr 20, 2:04 PM
dkazakov committed R37:2239e9550e35: Fix undo merging a layer that is cloned (authored by tusooaw).
Fix undo merging a layer that is cloned
Sat, Apr 20, 12:31 PM
dkazakov closed D20314: Fix for bug 397836 - undo merging a layer that is cloned.
Sat, Apr 20, 12:31 PM · Krita
dkazakov added a comment to D20591: B376086 Shift + Clicking a layer eye icon does not hide other layers.

Perhaps, you could highlight the eye icon somehow, when there is something in stasis? Or gray-out all hidden layers? Because right now the behavior looks really crazy. I couldn't understand how it works before I read the explanation at least three times.

Sat, Apr 20, 9:47 AM · Krita
dkazakov added a comment to D20680: BUG: 368587, Fix minimal shade selection.

Well, I couldn't reproduce the problem before the patch. And neither I could reproduce it after the patch. At least it doesn't do any regressions :)

Sat, Apr 20, 9:33 AM · Krita
dkazakov added inline comments to D20573: Fix 404615: Dimensions of Images output by "Export Layers" vary wildly depending on the layers alpha.
Sat, Apr 20, 9:27 AM · Krita
dkazakov accepted D20314: Fix for bug 397836 - undo merging a layer that is cloned.

The patch works perfectly fine now and does exactly what is declared! Please push! :)

Sat, Apr 20, 9:02 AM · Krita
dkazakov added a comment to T10819: Better UI for dealing with Clone Layers.

I think a separate dialog for selecting would be the most convenient for the users. And @vanyossi's idea about merging this dialog with the layer properties is very good. Actually, properties dialog is the most obvious place for the users to search for this option. Though it might be not very easy to add switchable options to it. I guess we could add a pager-widget to it and add pages for custom options like for clone layers and file layers. Though it will be quite a bit of work.

Sat, Apr 20, 8:54 AM · Krita: Abyss

Thu, Apr 18

dkazakov accepted D20653: Allow Clone Brush to reset origin after every stroke.

The patch works perfectly fine! Please push! :)

Thu, Apr 18, 3:30 PM · Krita
dkazakov committed R37:4e602f7aaa64: Add a GUI settings for useRightMiddleTabletButtonWorkaround (authored by dkazakov).
Add a GUI settings for useRightMiddleTabletButtonWorkaround
Thu, Apr 18, 2:52 PM
dkazakov committed R37:1d21ae2113fb: Fix updating tablet pressure resolution on every proximity enter event (authored by dkazakov).
Fix updating tablet pressure resolution on every proximity enter event
Thu, Apr 18, 12:47 PM
dkazakov committed R37:fc272a507ecf: Fix build (authored by dkazakov).
Fix build
Thu, Apr 18, 12:47 PM
dkazakov accepted D20657: Fix fullscreen mode on Windows with OpenGL.

The patch looks perfectly fine, please push! :)

Thu, Apr 18, 12:24 PM · Krita
dkazakov committed R37:24479fd31531: Workaround Krita canvas cursor update when application has no input focus (authored by dkazakov).
Workaround Krita canvas cursor update when application has no input focus
Thu, Apr 18, 10:11 AM

Wed, Apr 17

dkazakov committed R37:fb089519cdae: Fix hiccups when using wheel on the Wacom's tablets (authored by dkazakov).
Fix hiccups when using wheel on the Wacom's tablets
Wed, Apr 17, 7:29 PM
dkazakov committed R37:c30c6f424c42: Implement a hack for right- and middle-buttons on weird tablet devices (authored by dkazakov).
Implement a hack for right- and middle-buttons on weird tablet devices
Wed, Apr 17, 5:31 PM
dkazakov committed R37:714c9aaed2fe: Switch stylus pointer type when the tablet is in the tablet proximity (authored by dkazakov).
Switch stylus pointer type when the tablet is in the tablet proximity
Wed, Apr 17, 5:31 PM
dkazakov updated the title for P374 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Wed, Apr 17, 4:57 PM
dkazakov added a comment to T10751: Oddities with the WinInk API and side buttons when using a Wacom Intuos pen tablet.

I can confirm, Windows Pointer API doesn't support more than one (right) button. Just by-design. Theoretically, drivers might try to add a hack to report more (and breaking the protocol), but none of the drivers I tested do that. So I'm not sure what we can discuss here :)

Wed, Apr 17, 11:44 AM · Krita
dkazakov added a comment to T10751: Oddities with the WinInk API and side buttons when using a Wacom Intuos pen tablet.

Could you please test the very latest nightly build with WinTab setting? I've implemented auto-update of the desktop resolution. It should kind of work now.

Wed, Apr 17, 9:58 AM · Krita
dkazakov committed R37:2fda2ecd6017: Properly include private QPA headers (authored by dkazakov).
Properly include private QPA headers
Wed, Apr 17, 8:34 AM

Tue, Apr 16

dkazakov committed R37:9cf5c8661372: Fix setting custom tablet mapping (authored by dkazakov).
Fix setting custom tablet mapping
Tue, Apr 16, 4:20 PM
dkazakov requested changes to D20563: Luminosity to Alpha patch.

The patch doesn't build here. But I have a feeling that changing key colro in color-to-alpha from white to grey will do what you want.

Tue, Apr 16, 2:23 PM · Krita
dkazakov added a comment to D20591: B376086 Shift + Clicking a layer eye icon does not hide other layers.

Ooooooh... we have a feature like that. I guess we still have leftovers of it in KisBaseNode::Property::stateInStasis. The feature never worked as expected by the users and gave us a lot of pain. E.g.

Tue, Apr 16, 2:11 PM · Krita
dkazakov committed R37:71371bbc48f5: Implement a dialog passing Qt forced tablet mapping (authored by dkazakov).
Implement a dialog passing Qt forced tablet mapping
Tue, Apr 16, 10:20 AM

Mon, Apr 15

dkazakov added a comment to D15577: add move to top/bottom of parent layer functionality to layer docker.

Just for reference:

Mon, Apr 15, 3:13 PM · Krita
dkazakov added a comment to D15577: add move to top/bottom of parent layer functionality to layer docker.

@razvanr! I'm sorry that we seem to forget about this patch. I asked painters' opinion on that, so we should get feedback soonish.

Mon, Apr 15, 3:09 PM · Krita
dkazakov added a comment to D15577: add move to top/bottom of parent layer functionality to layer docker.

Here is a version of this patch rebased against the current master (with PNG files fixed): d228719365f789045fc7ba01b4db4acd91b1d0f5

Mon, Apr 15, 3:08 PM · Krita
dkazakov committed R37:d228719365f7: Add move to top/bottom of parent layer functionality to layer docker (authored by dkazakov).
Add move to top/bottom of parent layer functionality to layer docker
Mon, Apr 15, 3:06 PM
dkazakov requested changes to D20475: High Pass Filter.

Please check the inlined comments. It might also be nice to name the files according top the new naming convention, like HighPassFilter.cpp (without Kis prefix and in BigCamelCase).

Mon, Apr 15, 2:32 PM · Krita
dkazakov added inline comments to D20573: Fix 404615: Dimensions of Images output by "Export Layers" vary wildly depending on the layers alpha.
Mon, Apr 15, 1:45 PM · Krita
dkazakov requested changes to D20500: BUG: 404975 Really hard to choose color in tool options.

The patch seem to fix the original problem, but it introduces a crash (with ASAN enabled). When you switch to gradient fill/stroke and the shape doesn't have gradient yet, it crashes with invalid memory access:

Mon, Apr 15, 1:43 PM · Krita
dkazakov accepted D20097: Fix OpenGL canvas under fractional DPI scaling.
Mon, Apr 15, 1:30 PM · Krita
dkazakov added a comment to D20097: Fix OpenGL canvas under fractional DPI scaling.

The patch works fine now! Please push! :)

Mon, Apr 15, 1:30 PM · Krita
dkazakov added a comment to D20314: Fix for bug 397836 - undo merging a layer that is cloned.

Just an idea:

Mon, Apr 15, 1:03 PM · Krita
dkazakov committed R37:31c48ac7bf2a: Fetch tablet mapping from Wintab instead virtual screen geometry (authored by dkazakov).
Fetch tablet mapping from Wintab instead virtual screen geometry
Mon, Apr 15, 11:01 AM
dkazakov added a comment to D20563: Luminosity to Alpha patch.

As far as I can see, this patch just hardcodes functionality of Color to Alpha filter with white color selected as a reference. Why do we need this as a separate filter?

Mon, Apr 15, 7:39 AM · Krita

Sat, Apr 13

dkazakov committed R37:083659885653: Implement a custom variable for overriding Wintab's desktop area (authored by dkazakov).
Implement a custom variable for overriding Wintab's desktop area
Sat, Apr 13, 8:30 PM
dkazakov committed R37:6806b44ec212: Disable relative mode for the tablet in Qt (authored by dkazakov).
Disable relative mode for the tablet in Qt
Sat, Apr 13, 5:32 PM
dkazakov committed R37:7c7becc740a1: Add patch for Qt to support stylus button remapping (authored by dkazakov).
Add patch for Qt to support stylus button remapping
Sat, Apr 13, 3:27 PM

Thu, Apr 11

dkazakov added a comment to D20097: Fix OpenGL canvas under fractional DPI scaling.

Speaking truly, I don't understand, what bug this huge refactoring is intended to fix. Please list the problems you are trying to resolve.

Thu, Apr 11, 9:11 AM · Krita

Wed, Apr 10

dkazakov accepted D20416: KisCompositionBenchmark proposed update.

The patch looks fine, please push!

Wed, Apr 10, 5:01 PM · Krita
dkazakov updated the title for P366 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Wed, Apr 10, 5:00 PM
dkazakov committed R37:f8e338074772: Add GUI switch for disabling AVX optimization on Widnows (authored by dkazakov).
Add GUI switch for disabling AVX optimization on Widnows
Wed, Apr 10, 9:48 AM
dkazakov committed R37:da5d38cbe3b2: Add a patch for VC to workaround GCC unaligned stack bug (authored by dkazakov).
Add a patch for VC to workaround GCC unaligned stack bug
Wed, Apr 10, 9:48 AM

Tue, Apr 9

dkazakov requested changes to D20314: Fix for bug 397836 - undo merging a layer that is cloned.

The patch looks fine, though there are two issues. See the attached video to see illustration of these issues:

Tue, Apr 9, 7:44 PM · Krita
dkazakov committed R37:4bab45a28bac: Fix memory leaks caused by KisPaintDevice::convertTo() (authored by dkazakov).
Fix memory leaks caused by KisPaintDevice::convertTo()
Tue, Apr 9, 11:22 AM

Mon, Apr 8

dkazakov accepted D20271: Take care of 'unused parameter' build warnings..

The patch looks fine. Please update the comment I noted inline and push

Mon, Apr 8, 1:21 PM · Krita
dkazakov added a comment to D20141: Allow compilation of Vc 1.3.3 on macOS.

If you have any problems with building the test, please just try to update to 1.4.1 and try to paint on 8-bit image and on 32-bit-float image. If both types of painting work, then it should be fine to use it

Mon, Apr 8, 1:04 PM · Krita
dkazakov committed R37:38175ae5b1ef: Fix crash in Split Alpha (authored by dkazakov).
Fix crash in Split Alpha
Mon, Apr 8, 8:57 AM

Thu, Apr 4

woltherav awarded R37:0cf7c069e3dc: Fix swizzling when rendering QPainter on QOpenGLWidget with Angle a Love token.
Thu, Apr 4, 4:42 PM
dkazakov committed R37:0cf7c069e3dc: Fix swizzling when rendering QPainter on QOpenGLWidget with Angle (authored by dkazakov).
Fix swizzling when rendering QPainter on QOpenGLWidget with Angle
Thu, Apr 4, 4:41 PM
dkazakov committed R37:77ee7214d172: Detect presence of HDR code in Qt automatically by CMake (authored by dkazakov).
Detect presence of HDR code in Qt automatically by CMake
Thu, Apr 4, 4:41 PM
dkazakov committed R37:2c92f588e833: Keep image BG color when flattening the image (authored by dkazakov).
Keep image BG color when flattening the image
Thu, Apr 4, 12:49 PM
dkazakov committed R37:bf4cbcbf3bbd: Fix an assert when resizing image with a shape layer (authored by dkazakov).
Fix an assert when resizing image with a shape layer
Thu, Apr 4, 12:09 PM
dkazakov accepted D20246: Fix results of Nearest Neighbour filter.

The patch looks and works fine, please push! :)

Thu, Apr 4, 10:23 AM · Krita

Wed, Apr 3

dkazakov committed R37:d8abbc50a7c2: Fix hangup on changing image's color space (authored by dkazakov).
Fix hangup on changing image's color space
Wed, Apr 3, 4:29 PM
dkazakov added a comment to D20141: Allow compilation of Vc 1.3.3 on macOS.

Is it possible to run KisCompositionBenchmark on your system? (it is commented out in the build system atm). If it runs the same on both versions, I guess it should be okay just to update the version of Vc on OSX

Wed, Apr 3, 4:01 PM · Krita
dkazakov committed R37:13181cd88e13: Implement a switch for Tablet API in Qt (authored by dkazakov).
Implement a switch for Tablet API in Qt
Wed, Apr 3, 3:54 PM
dkazakov committed R37:5215befc243d: Fix activation of Isolate Mode when merging the layers down (authored by dkazakov).
Fix activation of Isolate Mode when merging the layers down
Wed, Apr 3, 9:41 AM

Tue, Apr 2

dkazakov committed R37:0dd0cfd8dab8: Revert "Fix activation of Isolate Mode when merging the layers down" (authored by dkazakov).
Revert "Fix activation of Isolate Mode when merging the layers down"
Tue, Apr 2, 4:49 PM
dkazakov added a reverting change for R37:759ecacbacdf: Fix activation of Isolate Mode when merging the layers down: R37:0dd0cfd8dab8: Revert "Fix activation of Isolate Mode when merging the layers down".
Tue, Apr 2, 4:49 PM
dkazakov committed R37:759ecacbacdf: Fix activation of Isolate Mode when merging the layers down (authored by dkazakov).
Fix activation of Isolate Mode when merging the layers down
Tue, Apr 2, 4:43 PM
dkazakov added a comment to D18792: Automatically create transform masks on layer types that cannot be transformed.

Where my changes start overlapping with @gdquest's idea is it has to do with layer changing.

Tue, Apr 2, 4:20 PM · Krita
dkazakov added a comment to D18792: Automatically create transform masks on layer types that cannot be transformed.

Here is video illustration:

Tue, Apr 2, 3:42 PM · Krita
dkazakov added a comment to D18792: Automatically create transform masks on layer types that cannot be transformed.

For point 1 and "finishing" the transform. This might need some discussion with artists. We might need to change our definition of what "finishing" a transform means. I think some people are not expecting the transform tool to finish until they move to another tool. I didn't even think about this until I saw a @gdquest video on how he is switching layers and doing multiple transform while staying in the transform tool. Right now he has to click on the canvas again to "re-activate" the transform handles...which for him is a limitation. Here is the video at the time... https://youtu.be/33Hym2srxpo?t=238

Tue, Apr 2, 3:31 PM · Krita
dkazakov updated the title for P359 Masterwork From Distant Lands from untitled to Masterwork From Distant Lands.
Tue, Apr 2, 2:56 PM
dkazakov committed R37:64481503fa4c: Fix copying of the correct cache when cloning a layer (authored by dkazakov).
Fix copying of the correct cache when cloning a layer
Tue, Apr 2, 12:27 PM
dkazakov committed R37:9dac9dc1c9f3: fix build (authored by dkazakov).
fix build
Tue, Apr 2, 10:35 AM
dkazakov requested changes to D18792: Automatically create transform masks on layer types that cannot be transformed.

Now there are two severe regressions :(

Tue, Apr 2, 10:33 AM · Krita
dkazakov committed R37:3f8e7bb414a5: Refactor KisLayerManager not to use undoLastCommand() (authored by dkazakov).
Refactor KisLayerManager not to use undoLastCommand()
Tue, Apr 2, 10:16 AM

Mon, Apr 1

dkazakov accepted D20171: Fix wrong DPI when moving window across screens.

The patch seems to work! I don't know we didn't use it before. perhaps it was not present in older versions of Qt :)

Mon, Apr 1, 9:51 PM · Krita
dkazakov committed R37:b10a1bbb6d66: Fix a hangup when starting painting too quickly after changing opacity (authored by dkazakov).
Fix a hangup when starting painting too quickly after changing opacity
Mon, Apr 1, 1:55 PM
dkazakov accepted D20131: Fix for bug "lost frames if you add too many hold frames".

The patch works fine, please push it without further review :)

Mon, Apr 1, 10:17 AM · Krita
dkazakov requested changes to D18792: Automatically create transform masks on layer types that cannot be transformed.

There are two very small issues still:

Mon, Apr 1, 9:55 AM · Krita
dkazakov added a comment to D18792: Automatically create transform masks on layer types that cannot be transformed.

Just a note about that "work recursive" toggle on the tool options for the transform tool.

That property seems to be forcing its value on and off with every start stroke...which is making using it kind of confusing.

if (m_optionsWidget) {
    m_workRecursively = m_optionsWidget->workRecursively() ||
        !currentNode->paintDevice();
}

I am not sure why this logic is there in the startStroke(), but maybe there is a better way to manage the state of that bool

Mon, Apr 1, 9:44 AM · Krita

Sat, Mar 30

dkazakov committed R37:0f66ae41d673: Add patches for Qt's WinInk implementation and make it activated by default (authored by dkazakov).
Add patches for Qt's WinInk implementation and make it activated by default
Sat, Mar 30, 9:46 PM
dkazakov committed R37:bf535aef44dd: Fix popup palette on Qt's implementation of the tablet support (authored by dkazakov).
Fix popup palette on Qt's implementation of the tablet support
Sat, Mar 30, 9:46 PM

Fri, Mar 29

dkazakov requested changes to D18792: Automatically create transform masks on layer types that cannot be transformed.

From a quick glance, it seems like point 2 is not fixed yet:

Fri, Mar 29, 2:42 PM · Krita

Wed, Mar 27

dkazakov committed R37:0f736a3d2e36: Clean-up system-wide default kritarc settings (authored by dkazakov).
Clean-up system-wide default kritarc settings
Wed, Mar 27, 4:51 PM
dkazakov committed R37:44337c52c090: Add sanity checks to KisProjectionLeaf::Private::node (authored by dkazakov).
Add sanity checks to KisProjectionLeaf::Private::node
Wed, Mar 27, 9:12 AM

Tue, Mar 26

dkazakov committed R37:1db77fe77265: Allow openGL renderer "Auto" selection handle blacklists (authored by dkazakov).
Allow openGL renderer "Auto" selection handle blacklists
Tue, Mar 26, 4:08 PM
dkazakov committed R37:5699be5ac06b: Fix semi-transparent bug properly on Windows (authored by dkazakov).
Fix semi-transparent bug properly on Windows
Tue, Mar 26, 3:51 PM
dkazakov committed R37:e1d56f30d513: Make sure Krita doesn't request alpha-enabled texture buffers (authored by dkazakov).
Make sure Krita doesn't request alpha-enabled texture buffers
Tue, Mar 26, 10:26 AM

Mon, Mar 25

dkazakov added a comment to D20038: Add HEIF dependencies to 3rdparty builds.

Should this 3rdparty dependency be available only on OSX? Or it is intended to be built on all the platforms?

Mon, Mar 25, 7:12 PM · Krita
dkazakov requested changes to D16009: Fixed Bug 396528.
Mon, Mar 25, 7:10 PM · Krita
dkazakov added a comment to D16009: Fixed Bug 396528.

The patch has a lot of commented out code and doesn't do what it is intended to do: the widget is not scaled:

Mon, Mar 25, 7:10 PM · Krita