Bug 315079
Added option to select "Solid Color" or "Pattern" to experimental brush.
Before:
After:
After with mirror:
After with solid color:
Details
Details
- Reviewers
rempt dkazakov albertoefg - Group Reviewers
Krita
Compiled and tested.
- Works with solid color or pattern
- Works with mirror or without it
- Saved different copies of the brush, all keep the appropriate fill selected option.
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Hi, @albertoefg!
The patch works almost fine, but there are a few little things that should be fixed before pushing it:
- [BUG] After starting Krita and opening brush editor the radio button has nothing set. It is incorrect. The radio button should have the value of the current brush.
- Use enum instead of the two booleans (see inlined comment)
- In brush format use literal enum as well.
Bug in point one is a direct sequence of not using a enum actually :)
| plugins/paintops/experiment/kis_experimentop_option.cpp | ||
|---|---|---|
| 119 | That is actually the reason of the bug | |
| plugins/paintops/experiment/kis_experimentop_option.h | ||
| 32 | See a comment about two booleans. Basically, we need a field that might have two options: "patter" or "color" | |
| 73 | That is really a bad idea to use two booleans to state that has only two options :) What does it mean if both booleans are false? And what does it mean if both booleans are true? Such state is undefined in this code. Please change it to some enum. Something like: enum FillType {
FillSolidColor,
FillPattern
};It will avoid the problem of undefined state | |
| 85 | Don't forget about the default values! | |
Comment Actions
@albertoefg - Are you still working on this. If not, would you be ok if I took this patch over and finished it off. I think the patch is still pretty much yours, so you can still get the credit for it.
Comment Actions
I talked with @albertoefg about this ticket. He is ok with me finishing this guy off.