In D19561#425879, @apol wrote:

Cool, thanks! remember to land in 5.15.

Cool, thanks! remember to land in 5.15.

Submit when kns is ready.

Don't search fallback locations - we're trying to avoid crashes, so unless people update their installation locations, they don't get Discovered:tm: ;)

We already have UrlButton for that.

Slightly different (and more central) approach. This ensures that resources are parented on creation rather than later (such as when being added to the updates list)

I'd actually like to be sure that it's fixing any issues before backporting to 5.12.

Is this a good candidate for going into 5.14 too? Or even 5.12?

In D18760#405894, @apol wrote:

Good, now I just wonder why KNS would give us poised entries...

Good, now I just wonder why KNS would give us poised entries...

Actually use the filtered list of entries

👍 Shipit!

Hmm... yes, it does seem just perhaps a little more, hmm, pleasing i guess, for lack of a more technical way to say "it looks nice" ;) and most of the time that string will be a little bit shorter than it is, so... yup, updated patch, swapped enormous for huge :)

Awesome, almost there! I tried with the icon size huge instead of enormousand I think it might look a bit better. What do you think?

In fact, don't need that outer item, so removing that

Try and pop the the icon above the text, and just use iconsize enormous rather than a hardcoded one, and also raise the whole thing just a bit. And since the plan is to not use a similar layout on the updates page in short order, let's just not componentise this just yet, so now it just looks kind of nice all 'round :)

Nice! Now the icon is still too big, especially with color. For these error pages, can we experiment with using a smaller size? I bet half as big would look good. Now that I thin of it, the icon should probably go above the text, too.

Changes as discussed: The component is now all nice and centered, and the icon is fully opaque. Yup, much prettier all 'round, and would be nice and easy to turn into a full-on component :)

In D18318#395986, @ngraham wrote:

+1 for always showing the search field. But that icon looks a bit big. I might make it smaller and lose the opacity.

Also, while we're prettifying the error page, how about vertically centering everything too?

BTW due to a silly Phabricator bug, group members/watchers don't get notified when you tag a task with the group. You have to actually add the group as a subscriber too! [shakes head]

+1 for always showing the search field. But that icon looks a bit big. I might make it smaller and lose the opacity.

Cherry-picked onto the Plasma/5.15 branch since it's a bugfix that doesn't introduce any string changes.

In D18320#395251, @ngraham wrote:

Thanks for the copious code comments. Definitely makes things easier to understand in the future.

Yes, quite, of course :D Was going to post one and got sidetracked ;)

Thanks for the copious code comments. Definitely makes things easier to understand in the future.

When submitting a patch that involves UI changes, it's always appreciated to include a screenshot. Bonus points for both before-and-after screenshots. :)

In D18246#393094, @ngraham wrote:

Nice catch. Looks like this might fix 401334?

(redudant) rebase

Nice catch. Looks like this might fix 401334?

rebase

rebase

rebase

rebase

rebase

rebase

rebase

rebase

move snapd-glib also

rebase

minor corrections

Not needed any more

rebase

rebase

remove wrapper script

@apol I don't have development account, so probably I can't.
I would be gratitude if you land it then. Thanks

Can you land the patches or you need me to?