Fix premature firing of allInitialized signal
ClosedPublic

Authored by leinir on Jan 14 2019, 3:34 PM.

Details

Summary

In case this is in fact the first backend to be added, and also happens to be pre-filled, we still need for the rest of the backends to be added before trying to send out the initialized signal. To ensure this happens, this patch schedules it for the start of the next run of the event loop, and ensures that it only happens if there are no more backends to initialise.

Specifically, this happens if e.g. the fwupd backend is the first to be initialised, and results in (amongst other things) that the application loads up and insists that there are no application backends.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Jan 14 2019, 3:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 14 2019, 3:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Jan 14 2019, 3:34 PM
davidedmundson accepted this revision.Jan 14 2019, 4:51 PM
This revision is now accepted and ready to land.Jan 14 2019, 4:51 PM
ngraham accepted this revision.EditedJan 14 2019, 4:57 PM

Nice catch. Looks like this might fix 401334?

apol accepted this revision.Jan 15 2019, 12:46 AM

Nice catch. Looks like this might fix 401334?

i think that is precisely what's going on there, yes - the symptoms certainly match :)

This revision was automatically updated to reflect the committed changes.