Using the search location getter added in D19338, ensure we get all locations which KNSCore::Engine will search for knsrc files, without making assumptions about where that might be.
Details
Details
- Reviewers
apol ngraham - Group Reviewers
Discover Software Store - Commits
- R134:d617dd8e6a1e: Search new knsrc locations
Diff Detail
Diff Detail
- Repository
- R134 Discover Software Store
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| libdiscover/backends/KNSBackend/KNSBackend.cpp | ||
|---|---|---|
| 69 | Discover should probably not fallback, i.e. pass false as an argument. This is Plasma 5.16 and by then we should have all applications within KDE ported. This can be an incentive for the rest to install in the right place. | |
| libdiscover/backends/KNSBackend/KNSBackend.cpp | ||
|---|---|---|
| 69 | Hmm! Very good point indeed, we're far enough away for this to be a thing we can sort for the majority of things, and yup, definitely avoids a very great amount of headaches :) i shall swap that and update the patch shortly | |
Comment Actions
Don't search fallback locations - we're trying to avoid crashes, so unless people update their installation locations, they don't get Discovered:tm: ;)
| libdiscover/backends/KNSBackend/KNSBackend.cpp | ||
|---|---|---|
| 68 | Needs to be 57 now (we'll get all of this landed soon, not to worry!) Also, should the second one be KNEWSTUFFCORE_VERSION_MINOR? Seems weird that both conditions are checking the major version. | |
| libdiscover/backends/KNSBackend/KNSBackend.cpp | ||
|---|---|---|
| 68 | It does indeed! Good catch before landing time, too :) wwwwoooow... yes, yes it should, not sure how i missed that :D | |
Comment Actions
Update to require 5.57, and also actually inspect the minor version rather than two instances of the major version.
Comment Actions
Nice. So do we need to change KNS providers/apps to install their files in the new location now?
Comment Actions
We'll need to wait until the next time the CI system gets updated for dependencies, otherwise it'll start being all red and angry - same for this one, incidentally, as what's there now will already report 5.57, but of course won't actually have the function being called... i've got patches under way for it all, though, but as we have to wait for the CI anyway, i've not stuck them up yet :)
Comment Actions
All right, since the app dependency freeze is passed, it looks like any changes to apps will need to go into 19.08.0. Changes to anything on the Plasma release cycle can go in immediately since the next Plasma release will depend on Frameworks 5.58.