Add a timeout for KNS backends
ClosedPublic

Authored by leinir on Feb 4 2019, 2:04 PM.

Details

Summary

This patch will mark as invalid any KNS backend that takes longer than sixty seconds.

This is supposed to go into the 5.14 branch, but may also be useful in general (perhaps with a longer timeout to avoid issues in parts of the world with particularly slow internet connections).

BUG:399981

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Feb 4 2019, 2:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 4 2019, 2:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leinir requested review of this revision.Feb 4 2019, 2:04 PM
davidedmundson accepted this revision.Feb 4 2019, 3:45 PM
davidedmundson added inline comments.
libdiscover/backends/KNSBackend/KNSBackend.cpp
143

this already calls setFetching(false).

This revision is now accepted and ready to land.Feb 4 2019, 3:45 PM
ngraham accepted this revision.Feb 4 2019, 8:30 PM
apol accepted this revision.Feb 4 2019, 8:53 PM
leinir marked an inline comment as done.Feb 5 2019, 11:14 AM
leinir added inline comments.
libdiscover/backends/KNSBackend/KNSBackend.cpp
143

Good spot, i'll just swipe that and get it in :)

This revision was automatically updated to reflect the committed changes.
leinir marked an inline comment as done.