This has been effectively done for Discover 5.27! See https://invent.kde.org/plasma/discover/-/merge_requests/398.

1. Drawer background should be inverted like in the other apps.

So I am trying to implement some of this mockup and I have stumbled on some issues.

The sidebar should not utilise text below iconography, because that is significantly less consistent, and is additionally less sensibly adaptive if the constituents of the text that is beneath it are more than approximately 4 letters.

I think it would be a good idea to show a short description of each app in the short cards because lots of people won't know what an app does just by looking at the name or icon.

Awesome, I'll try to implement somethin that closely follows this mockup this weekend :)

Yep, that MR is going to me merged into 5.23 and implements a fairly similar design. I think these mockups have more or less done their job. :)

I forgot the mockups and started something in this direction: https://invent.kde.org/plasma/discover/-/merge_requests/81. I probably could take more inspirations from the mockups.

I saw the new post about the redesign of GNOME Software seen here: https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1111 and would like to see how the designers would implement context tiles because I think it's a good idea to have. I also think having a link to the App's addon page, if we put addons in a separate category could help connect the two sections of the app.

I just want to add an alternative mockup for the sidebar and the app installation list. Some widgets may not be possible - I'm not sure.

I think as long as we don't do a nested sidebar thing like with the current implementation it would still be a good option. Putting the categories in the toolbar might work but it's probably too much to fit and not look squashed together.

Ping! This is an important thing to have overall; could you please submit it as a Merge Request at https://invent.kde.org/plasma/discover/-/merge_requests?

I agree that the Home page looks very good but that it would be good to make it a bit more dynamic as well. Maybe simply rotating around the images of the singular apps on different times for different apps would do the trick (as opposed to rotating around apps, which is IMHO mostly not a good idea except in preview panels like on the top).

Hey,
I went through the review, the patch looks good. There's some fairly important bits missing:

• un/installing
• running
• state of resources. Currently it searches only on the server but doesn't check if it's installed locally.
• detecting if the runtime is available

Discover already allows you to upvote/downvote reviews FWIW.

In T12668#220624, @ngraham wrote:

Things I like:

• Pretty much everything about the new Home page. Looks much more attractive than what we have right now. I'm coming to believe it's important to either regularly rotate the content, or else add dynamic items, so the ecosystem doesn't look static and dead.
• Making the list into a grid with rectangular cards. It looks really good IMO.
• Expanding the apps category so you can see its child items on the first level of navigation in the sidebar.
• Putting add-ons in a whole separate category.
  
  Things I'm neutral on:
• Adding a second sidebar. I don't hate it, but I'm not in love with it either. Maybe if we put these category items on the tools area, it wouldn't look so empty.
• The gigantic colored rectangle header on the app pages. Maybe it it were a bit smaller, it wouldn't seem wasteful and attention-getting.
  
  Things I don't like:
• Hiding the search field behind a button. It needs to be visible by default, since it has keyboard focus by default.
• The tools area now looks huge, barren, and empty. This might be better if there was a visible search field in it though.

The following opinions/suggestions are to be aligned with "What Discover Is" and "What Discover Isn't" at Discover Page.

Very nice patch! May it be the first of many. :)

On the off-chance it's me you're asking - sure :)
(First time contributor, not sure how the process works...)

Do you want me to land the change?

Things I like:

• Pretty much everything about the new Home page. Looks much more attractive than what we have right now. I'm coming to believe it's important to either regularly rotate the content, or else add dynamic items, so the ecosystem doesn't look static and dead.
• Making the list into a grid with rectangular cards. It looks really good IMO.
• Expanding the apps category so you can see its child items on the first level of navigation in the sidebar.
• Putting add-ons in a whole separate category.

I like the idea behind this but I'm not sure this is the right way to do it. Instead of changing the strings in the backend, we should add the new text (plus icons, preferably) on the UI side, in the QML files. See discover/qml/ApplicationDelegate.qml

This seem had already been fixed : https://phabricator.kde.org/R256:03011c6e3c689c3e13c91e964000fd66fbb80daf

LGTM otherwise

Remove unnecessary (very noisy) debug messages

Ping? :)

We now assume that an AdoptionCommand is set. This reduces the code overhead, which is always nice.

Remove some future-leftovers

Address various comments, and also fix one issue discovered while addressing those

In D19837#433343, @ngraham wrote:

Can you edit the test plan to indicate the name of an app from the store that now appears in Discover's Applications section? A quick test of this patch didn't reveal ExeQt or Treeline in Discover, which are visible on http://opendesktop.org.

Can you edit the test plan to indicate the name of an app from the store that now appears in Discover's Applications section? A quick test of this patch didn't reveal ExeQt or Treeline in Discover, which are visible on http://opendesktop.org.

Er, whoops.

All right, since the app dependency freeze is passed, it looks like any changes to apps will need to go into 19.08.0. Changes to anything on the Plasma release cycle can go in immediately since the next Plasma release will depend on Frameworks 5.58.

In D19340#430964, @ngraham wrote:

Nice. So do we need to change KNS providers/apps to install their files in the new location now?

Nice. So do we need to change KNS providers/apps to install their files in the new location now?

Update to require 5.57, and also actually inspect the minor version rather than two instances of the major version.