Guys, please don't forget to support the "Computers" section as well (on the same level as "My Drive", "Shared with me" etc.)!

Closing, see https://invent.kde.org/network/kio-gdrive/-/commit/6d7456fde9762bf76007388d17b7367b20160ac4

I agree with @barchiesi this directory structure align perfectly with the WebUI version of the Google Drive.

In D28363#638317, @feverfew wrote:

@elvisangelaccio Done. I don't know how you choose for fixes in release branches to get into master so I'll let you sort that out (and what is it, for future reference)?

@elvisangelaccio Done. I don't know how you choose for fixes in release branches to get into master so I'll let you sort that out (and what is it, for future reference)?

Please push to the 1.3 branch. Thanks!

In T11560#217073, @ryanrsmith wrote:

Hi, I get the message,

Sign in with Google temporarily disabled for this app
This app has not yet been verified by Google in order to use Google Sign in.

When I use Dolphin on Manjaro Linux to access GDrive after signing in to Google.

kio-gdrive 1.2.7-1

Is this related?

Hi, I get the message,

Update: Google still hasn't verified my app after months, but I noticed that the libkgapi's embedded web browser fails to meet Google's security standards anyway (too old webengine?):

As of now, the first UDS_EXTRA is used to store the alternateLink of a Drive file. This is necessary for providing an url to the 'Copy Google URL to clipboard' action.

LGTM now. Ship it! :)

moved translation of Shared Drive label to kio_gdrive.cpp
ordered kio_gdrive.cpp includes
const and ref fixes

Feel free to push after fixing the last two nitpicks.

Remove unnecessary includes, use QGuiApplication instead of QApplication, use QLatin1String for string comparison, fix name in service descriptor.

Almost there!

Remove deprecated Q_FOREACH and use enum in fetchSharedDrivesRootEntry() arguments.

First round of fixes.

@martijnschmidt Ping. What's the status of this patch?

Here are some screenshots:

Fixed above

Note that the commit message will need BUG: (with the colons) in order to automagically close the bug report.

Adapted according to changes to LibKGAPI in D22787

I just created the branch named drives. Most if not all Shared Drives operations have been implemented if I'm not mistaken. I'm not convinced with the permission handling, I couldn't find a way to instruct Dolphin regarding special specific permissions (i.e. disable deleting a Shared Drive but allow adding files).

Reworded log messages for fileSystemFreeSpace() as noted in D22462.

Added dash in temporary file template.

Can you expland a bit the commit message explaining how does libkgapi use the filename?

Please push to master. Thanks!

Yeah :D

Added doxygen for runJob() method.

Removed debug output changes.

The change around runJob() looks good, but all the changes in logging should go in separately since they are unrelated to the main part of the change.

Sure!

As per Google's new naming, Team Drives have been renamed to Shared Drives.

Fixed

Yes I did

Updated after changes to D20064

You are correct, fixed those issues

Please don't forget to bump kio-gdrive's KGAPI_MIN_VERSION to the new libkgapi's KGAPI_VERSION_STRING.

You should be able to apply the last missing patch on top of libkgapi master (I've merged all the previous ones just now)

Hmm, I can't apply this patch because arc complains about the missing patches on libkgapi.

@elvisangelaccio can you review this patch, please? I'll be merging @barchiesi's LibKGAPI patches that affect the API, so I would merge this at the same time and bump the KIO GDrive dependency so everything keeps compiling.

Add commit to revision.

Add commit to revision.

Maybe this time

Got it.

No, I meant to split this patch into 2 commits (resulting in 2 different Phabricator revisions), to make it easier to review. One commit for the new GDriveUrl api and the other one for the code refactoring in kio_gdrive.cpp (which got much bigger than it was).

I'm still new to phabricator, I hope this is what you meant.