Use mimeType from metadata instead of blindly re-determining it during uploads
ClosedPublic
Actions

Authored by barchiesi on Jul 28 2019, 6:27 PM.

Details

Reviewers

Commits

R477:db302e1bdc31: Merge branch 'Applications/19.08'
R477:f77a7391c1e8: Use mimeType from metadata instead of blindly re-determining it during uploads

Summary

LibKGAPI uses a files name and data when determining content type. If the File upload mime-type is specified, don't re-determine it.
This avoids having to expose the upload filename while using temporary files.

Diff Detail

Repository

R477 KGAPI Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

barchiesi created this revision.Jul 28 2019, 6:27 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 28 2019, 6:27 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

barchiesi requested review of this revision.Jul 28 2019, 6:27 PM

Harbormaster completed remote builds in B14502: Diff 62688.Jul 28 2019, 6:27 PM

barchiesi mentioned this in D22628: Fix mimeType loss during file creation or update..Jul 28 2019, 6:31 PM

barchiesi added a dependent revision: D22628: Fix mimeType loss during file creation or update..Jul 28 2019, 6:37 PM

This change was inspired by D22628.

Nice! I was afraid we might have to introduce a new method for this, but this is great - I think it's OK to land this onto Applications/19.08, if you can do it before the Thursday freeze.

This way KIO GDrive depending on 19.08 can make use of this feature.

This revision is now accepted and ready to land.Jul 29 2019, 8:10 AM

Closed by commit R477:f77a7391c1e8: Use mimeType from metadata instead of blindly re-determining it during uploads (authored by barchiesi). · Explain WhyJul 29 2019, 8:46 AM

This revision was automatically updated to reflect the committed changes.

barchiesi mentioned this in D24301: Fix null pointer dereference, keep FileModifyJob metadata and serialize with options..Sep 29 2019, 6:24 PM

barchiesi mentioned this in R477:2cbbdda75227: Fix null pointer dereference, keep FileModifyJob metadata and serialize with….Oct 1 2019, 12:10 PM

Revision Contents
Changeset List

			Path	Packages
M			src/drive/fileabstractuploadjob.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62688	bd50237		Jul 28 2019, 6:27 PM	★	★
Diff 2	62716	d71a6e5	R477:f77a7391c1e897264e121ee91af159dbfed39853	Jul 29 2019, 8:46 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
59ae54b79df2	2460ef43458e	bd50237f7f90	David Barchiesi	Use mimeType from metadata instead of blindly re-determining it during uploads (Show More…)	Jul 28 2019, 6:13 PM

	Status	Author	Revision
	Closed	barchiesi	D22628 Fix mimeType loss during file creation or update.
	Closed	barchiesi	D22787 Use mimeType from metadata instead of blindly re-determining it during uploads

Diff 62716

View Options

src/drive/fileabstractuploadjob.cpp