In the next release, LibKGAPI has changed the way it sets fields in FileFetchJob and in general allows setting response fields for all Jobs (see D20886 Add fields standard query parameter to Job and use it in FileFetchJob).
This patch adjusts KIO Gdrive to this change and limits the response in AboutFetchJobs.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
@elvisangelaccio can you review this patch, please? I'll be merging @barchiesi's LibKGAPI patches that affect the API, so I would merge this at the same time and bump the KIO GDrive dependency so everything keeps compiling.
Hmm, I can't apply this patch because arc complains about the missing patches on libkgapi.
Anyway the code change looks sane. It's missing the KGAPI_MIN_VERSION variable bump in the main CMakeLists.txt file though.
| src/kio_gdrive.cpp | ||
|---|---|---|
| 465–470 | Is it possible to merge these 2 lines in a single one and make it a const variable? | |
You should be able to apply the last missing patch on top of libkgapi master (I've merged all the previous ones just now)
EDIT: or just use --skip-dependencies with arc patch
| src/kio_gdrive.cpp | ||
|---|---|---|
| 465–470 | Plus can be turned into an initializer list, I'll fix that before merge. | |
Please don't forget to bump kio-gdrive's KGAPI_MIN_VERSION to the new libkgapi's KGAPI_VERSION_STRING.