Differential D24366

Allow stat()ing new-account link.
ClosedPublic
Actions

Authored by barchiesi on Oct 2 2019, 3:06 PM.

Tags

Subscribers

Details

Reviewers

elvisangelaccio

Commits

R219:8e2b3d3d759b: Allow stat()ing new-account link.

Summary

When stat()ing 'gdrive:/new-account', the slave was actually stat()ing the UDS entry for the account root path.
This patch fixes the issue by not having GDriveUrl::isAccountRoot() return true for 'gdrive:/new-account' and also moves the New Account label logic into GDriveUrl.

Diff Detail

Repository

R219 KIO GDrive

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

barchiesi requested review of this revision.Oct 2 2019, 3:06 PM

barchiesi created this revision.

Harbormaster completed remote builds in B17248: Diff 67199.Oct 2 2019, 3:06 PM

barchiesi added a reviewer: elvisangelaccio.Oct 2 2019, 3:07 PM

barchiesi added a project: KIO GDrive.

barchiesi added a subscriber: KIO GDrive.

elvisangelaccio accepted this revision.Oct 2 2019, 8:20 PM

elvisangelaccio added inline comments.

src/gdriveurl.cpp
61–66	How about `return m_components.length() == 1 && !isNewAccountPath();` ?

This revision is now accepted and ready to land.Oct 2 2019, 8:20 PM

Closed by commit R219:8e2b3d3d759b: Allow stat()ing new-account link. (authored by barchiesi). · Explain WhyOct 3 2019, 7:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/gdriveurl.h (3 lines)
M			src/gdriveurl.cpp (8 lines)
M			src/kio_gdrive.h (1 line)
M			src/kio_gdrive.cpp (38 lines)

Diff 67243

src/gdriveurl.h

Loading...

src/gdriveurl.cpp

Loading...

src/kio_gdrive.h

Loading...

src/kio_gdrive.cpp

Loading...