Differential D20941

Refactor kio_gdrive to make use of new GDriveUrl functionalities
ClosedPublic
Actions

Authored by barchiesi on May 1 2019, 5:24 PM.

Details

Reviewers
elvisangelaccio
Commits
R219:8188cc3c5d02: Refactor kio_gdrive to make use of new GDriveUrl functionalities
Summary

D20064 enhances GDriveUrl with new constants and some of the same logic used in KIOGDrive. This patch refactors KIOGDrive to make use of it.

Diff Detail

Repository
R219 KIO GDrive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
barchiesi requested review of this revision.May 1 2019, 5:24 PM
barchiesi created this revision.
barchiesi added a dependency: D20064: Add usefull functions to GDriveUrl..
barchiesi updated this revision to Diff 57335.May 1 2019, 5:29 PM

Add commit to revision.

barchiesi updated this revision to Diff 58311.May 19 2019, 4:58 PM

Updated after changes to D20064

barchiesi set the repository for this revision to R219 KIO GDrive.May 19 2019, 4:58 PM
elvisangelaccio added inline comments.May 19 2019, 8:54 PM
src/kio_gdrive.cpp
84

I wouldn't bother with this honestly. I think it's better to be explicit here (also to keep consistency with other kioslaves).

889

This variable is actually useless, we could just use destGDriveUrl.filename() in the setTitle() call below.

1056–1058

Same here, just use:

destFile->setTitle(destGDriveUrl.filename());
elvisangelaccio accepted this revision.May 25 2019, 5:05 PM
This revision is now accepted and ready to land.May 25 2019, 5:05 PM
Closed by commit R219:8188cc3c5d02: Refactor kio_gdrive to make use of new GDriveUrl functionalities (authored by barchiesi, committed by elvisangelaccio). · Explain WhyMay 25 2019, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kio_gdrive.cpp (41 lines)

Diff 58661

View Options

src/kio_gdrive.cpp

Loading...