Closing by lack of activity.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Aug 7 2019
Jan 30 2019
Jan 25 2019
Oct 4 2018
Feb 5 2018
Feb 1 2018
Nov 26 2017
Aug 20 2017
Aug 16 2017
Doesn't look like my comments are going to be addressed, closing it for now.
Doesn't look like my comments are going to be addressed, closing it for now.
Doesn't look like my comments are going to be addressed, closing it for now.
Apr 18 2017
This step is in the work in my local repository.
Revamped and rebased in my local repository, can be closed.
Revamped and rebased in my local repository, can be closed.
Revamped and rebased in my local repository, can be closed.
Mar 8 2017
Now we're talking! I can properly review now.
Correction to the first patch on HACKING D4225
I clicked on update patch.
Feb 28 2017
OK, I stopped reviewing mid-way...
Feb 25 2017
Sorry guys for the time to finally review it. I was very busy, on the road... Finally got to it now.
Feb 6 2017
Jan 21 2017
Thanks for looking at completing this. Indeed that's needed. Improvements still required on grammar and on how generic those advises are.
Jan 20 2017
Oct 27 2016
Sep 30 2016
Sep 29 2016
Sep 28 2016
Jul 26 2016
Jun 28 2016
Jun 8 2016
May 10 2016
I got a slightly more recent gcc but I doubt it is the issue. The "-std=gnu++11" on your compile line looks odd though, it likely overrides the "-std=c++14" which comes before. I think you should try to track that one down.
I use :
gcc (SUSE Linux) 5.3.1 20160301 [gcc-5-branch revision 233849]
cd /compile/kde5/zanshin/build/src/zanshin/kontact && /usr/bin/c++ -DKCOREADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_USE_FAST_CONCATENATION -DQT_USE_FAST_OPERATOR_PLUS -DQT_WIDGETS_LIB -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkontact_zanshinplugin_EXPORTS -I/compile/kde5/zanshin/build/src/zanshin/kontact -I/compile/kde5/zanshin/src/zanshin/kontact -I/compile/kde5/zanshin -I/compile/kde5/zanshin/build -I/compile/kde5/zanshin/3rdparty/kdepim -I/compile/kde5/zanshin/3rdparty/kdepim/libkdepim -I/compile/kde5/zanshin/src -isystem /opt/kde5-qt5.7/include/KF5/KParts -isystem /opt/kde5-qt5.7/include/KF5 -isystem /opt/kde5-qt5.7/include/KF5/KIOWidgets -isystem /opt/kde5-qt5.7/include/KF5/KIOCore -isystem /opt/kde5-qt5.7/include/KF5/KCoreAddons -isystem /opt/qt5.7/include -isystem /opt/qt5.7/include/QtCore -isystem /opt/qt5.7/./mkspecs/linux-g++ -isystem /opt/kde5-qt5.7/include/KF5/KService -isystem /opt/kde5-qt5.7/include/KF5/KConfigCore -isystem /opt/kde5-qt5.7/include/KF5/KJobWidgets -isystem /opt/qt5.7/include/QtWidgets -isystem /opt/qt5.7/include/QtGui -isystem /opt/qt5.7/include/QtNetwork -isystem /opt/kde5-qt5.7/include/KF5/KCompletion -isystem /opt/kde5-qt5.7/include/KF5/KWidgetsAddons -isystem /opt/kde5-qt5.7/include/KF5/KXmlGui -isystem /opt/qt5.7/include/QtDBus -isystem /opt/qt5.7/include/QtXml -isystem /opt/kde5-qt5.7/include/KF5/KConfigWidgets -isystem /opt/kde5-qt5.7/include/KF5/KCodecs -isystem /opt/kde5-qt5.7/include/KF5/KConfigGui -isystem /opt/kde5-qt5.7/include/KF5/KAuth -isystem /opt/kde5-qt5.7/include/KF5/KTextWidgets -isystem /opt/kde5-qt5.7/include/KF5/SonnetUi -isystem /opt/kde5-qt5.7/include/KF5/KI18n -isystem /opt/kde5-qt5.7/include/KF5/KontactInterface -std=c++0x -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -std=c++14 -fexceptions -fPIC -fexceptions -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=gnu++11 -o CMakeFiles/kontact_zanshinplugin.dir/kontact_plugin.cpp.o -c /compile/kde5/zanshin/src/zanshin/kontact/kontact_plugin.cpp
Compiles here and we pass -std=c++14 to gcc for that purpose, it should build without this patch. Looks like a wrong g++ version or such? Maybe we should be more picky about that in the CMakeLists.txt?
May 6 2016
Generate new template
May 1 2016
Apr 29 2016
Apr 27 2016
Apr 22 2016
Apr 14 2016
Apr 13 2016
Apr 9 2016
Use app_SRCS variable directly.
I can't confirm that kontact translation work so I remove changes from the moment.
Apr 8 2016
I also assume you tested it works as expected both for the standalone applications and the kontact plugins? I'd be in fact slightly surprised if it works for the kontact plugin case,
Apr 6 2016
Apr 5 2016
Apr 3 2016
Mar 30 2016
The dialog is still not working at that point since you don't produce a project list model yet as advised last week. Did you look at TaskListModel as I proposed? Really you simply need to write a ProjectListModel...
Mar 29 2016
First of all, there are not test at all to cover this up, do you guys plan to bring them in later ? should be pushed at the same time so It would be easier for me to grasp how your whole mechanism is supposed to work (test is a spec too!). I'll apply this patch later to see what it looks like tho.