Add Class Cache
AbandonedPublic
Actions

Authored by ervin on Oct 9 2015, 9:26 AM.

Details

Reviewers

bensi

Summary

The Cache is not yet attached to the CachingStorage. It listen the
monitor and store/update/remove informations.

Repository

R4 Zanshin

Lint

Lint Skipped

Unit

Unit Tests Skipped

bensi retitled this revision from to Add Class Cache.

bensi updated this object.

bensi edited the test plan for this revision. (Show Details)

bensi added a reviewer: ervin.

bensi set the repository for this revision to R4 Zanshin.

bensi added a project: Zanshin.

ervin requested changes to this revision.Oct 9 2015, 11:53 AM

ervin edited edge metadata.

ervin added inline comments.

src/akonadi/akonadicache.cpp
48	OK, now I understand the earlier inheritance from QObject... still you can't do that. You'll have to find another mean to react to the monitor signals. Probably with an internal QObject with trivial slots or such: delegate and don't inherit QObject.

This revision now requires changes to proceed.Oct 9 2015, 11:53 AM

bensi edited edge metadata.

ervin requested changes to this revision.Nov 1 2015, 1:01 PM

ervin edited edge metadata.

ervin added inline comments.

src/akonadi/akonadicache.cpp
32	Will need to be controlled via a ctor parameter. Otherwise you're making a hard dependency from Cache to MonitorImpl...
src/akonadi/akonadicache_p.h
36	Space before * not after.
107	Space before * not after.
src/akonadi/akonadimemorystore.h
41	Shouldn't be in that patch, but in the one introducing MemoryStore.

This revision now requires changes to proceed.Nov 1 2015, 1:01 PM

Revamped and rebased in my local repository, can be closed.

		Path
M		src/akonadi/CMakeLists.txt (1 line)
A	M	src/akonadi/akonadicache.h (59 lines)
A	M	src/akonadi/akonadicache.cpp (76 lines)
A	M	src/akonadi/akonadicache_p.h (111 lines)
M		src/akonadi/akonadimemorystore.h (1 line)