Add CachingStorage
AbandonedPublic

Authored by ervin on Oct 9 2015, 9:22 AM.

Details

Reviewers
bensi
Summary

The current implementation only forwards the call to the Storage.

Diff Detail

Repository
R4 Zanshin
Lint
Lint Skipped
Unit
Unit Tests Skipped
bensi updated this revision to Diff 954.Oct 9 2015, 9:22 AM
bensi retitled this revision from to Add CachingStorage.
bensi updated this object.
bensi edited the test plan for this revision. (Show Details)
bensi added a reviewer: ervin.
bensi set the repository for this revision to R4 Zanshin.
bensi added a project: Zanshin.
ervin requested changes to this revision.Oct 9 2015, 11:35 AM
ervin edited edge metadata.
ervin added inline comments.
src/akonadi/akonadicachingstorage.cpp
32

Probably needs to be controllable on the ctor. See my other comment on the why. ;-)

src/app/dependencies.cpp
58 ↗(On Diff #954)

You also need to make sure the acceptance tests use the CachingStorage on top of the storage implementation used there. It should be in this commit IMO to catch regressions early and not forget to adjust the acceptance tests later.

This revision now requires changes to proceed.Oct 9 2015, 11:35 AM
bensi updated this revision to Diff 1115.Oct 30 2015, 10:30 PM
bensi edited edge metadata.
ervin added a comment.Nov 1 2015, 12:47 PM

Slightly surprised that the changes to dependencies.cpp are completely gone now. Is it intented? Will they come back in a later patch?

ervin requested changes to this revision.Dec 15 2015, 5:55 PM
ervin edited edge metadata.

Long time with no reply, marking "Request Changes" just so that it doesn't appear on my backlog.

This revision now requires changes to proceed.Dec 15 2015, 5:55 PM
ervin commandeered this revision.Apr 18 2017, 10:08 AM
ervin edited reviewers, added: bensi; removed: ervin.

Revamped and rebased in my local repository, can be closed.

ervin abandoned this revision.Apr 18 2017, 10:08 AM