MemoryStore create cache information about collections, tags and items.
AkonadiFakeData inherit of MemoryStore.
Details
- Reviewers
bensi
Diff Detail
- Repository
- R4 Zanshin
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/akonadi/akonadicacheinterface.cpp | ||
---|---|---|
3 ↗ | (On Diff #955) | Same thing, re-add my copyright line. |
src/akonadi/akonadicacheinterface.h | ||
3 ↗ | (On Diff #955) | There's a sizeable code just being moved, you're supposed to keep my copyright line too. ;-) |
35 ↗ | (On Diff #955) | Missing space before ":", but I don't see why it would need to inherit from QObject in the first place. Also I'm not sure I like the name since a) it is not an interface and b) it is not only for caching. :-) MemoryStore? |
48–50 ↗ | (On Diff #955) | Try to avoid changing the signature of those and avoid making them virtual. It seems to be only about change notification, so I would propose something like:
|
54–56 ↗ | (On Diff #955) | ditto. |
62–64 ↗ | (On Diff #955) | ditto. |
tests/testlib/akonadifakedata.h | ||
46–48 | The virtual isn't needed here. |
src/akonadi/akonadimemorystore.h | ||
---|---|---|
38 | Space before & note after. | |
63–65 | No need to move that to MemoryStore. I think those method can (and should) stay in the fake data. Their implementation might need to be adjusted a tiny bit of course. | |
67–70 | Same for those, they shall not be in MemoryStore. | |
79 | Space before & not after. |