Generate new template
AbandonedPublic
Actions

Authored by ervin on Mar 29 2016, 7:44 AM.

Details

Reviewers

rottanaly
bensi
franckarrecot

Summary

Display the window which users can input the name and select the list of project in order to create new template

Diff Detail

Repository

R4 Zanshin

Lint

Lint Skipped

Unit

Unit Tests Skipped

rottanaly updated this revision to Diff 2992.Mar 29 2016, 7:44 AM

rottanaly retitled this revision from to Create new template.

rottanaly updated this object.

rottanaly edited the test plan for this revision. (Show Details)

rottanaly added reviewers: ervin, bensi, franckarrecot.

rottanaly set the repository for this revision to R4 Zanshin.

rottanaly added a project: Zanshin.

rottanaly added subscribers: rottanaly, dyhia, thuynguyen.

First of all, there are not test at all to cover this up, do you guys plan to bring them in later ? should be pushed at the same time so It would be easier for me to grasp how your whole mechanism is supposed to work (test is a spec too!). I'll apply this patch later to see what it looks like tho.

The dialog is still not working at that point since you don't produce a project list model yet as advised last week. Did you look at TaskListModel as I proposed? Really you simply need to write a ProjectListModel...

Also I think the whole part about TemplatePageModel has no place at this stage, you're still trying to create a template from a project (from the story you're working on), not to list a template content yet.

src/presentation/applicationmodel.h
34	This change is unneeded.
50	"availableProjectTemplates" would be a better name
62	Ditto.
78	Rename to m_availableProjectTemplates.
src/presentation/templatepagemodel.h
4–5	Copyright is wrong in this file, you wrote it, put the real authors.
45	Are you creating this TemplatePageModel to display the content of a template? If yes, then I would expect the first argument to be a "Domain::Template::Ptr", this type obviously doesn't exist yet. Up to you to turn it into reality.
46–49	Similarly those are probably the wrong queries and repositories... you would need to introduce your own to list templates and their content.
src/widgets/availablepagesview.cpp
63	Remove that empty line
293	m_projects is still a null pointer at that point. You need to initialize it with a model wrapping a list of projects. So you're missing a class inheriting from QAbstractItemModel for that... again TaskListModel would be a good inspiration for you to start from.
399	Remove that empty line.
src/widgets/availablepagesview.h
86	The name looks wrong, you're not providing a list here.
src/widgets/newtemplatedialog.cpp
4	I didn't write that file either.
src/widgets/newtemplatedialog.h
4	Fix the copyright line, I didn't write that file.
src/widgets/newtemplatedialoginterface.cpp
4	I didn't write that file.
src/widgets/newtemplatedialoginterface.h
4	I didn't write that file.

This revision now requires changes to proceed.Mar 30 2016, 8:59 PM

Generate new template

rottanaly updated this revision to Diff 4294.Jun 8 2016, 3:36 PM

rottanaly edited edge metadata.

ervin commandeered this revision.Jun 28 2016, 3:57 PM

ervin abandoned this revision.

ervin edited reviewers, added: rottanaly; removed: ervin.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (3 lines)
M		src/domain/CMakeLists.txt (3 lines)
A	M	src/domain/projecttemplate.h (62 lines)
A	M	src/domain/projecttemplate.cpp (50 lines)
A	M	src/domain/projecttemplatequeries.h (47 lines)
A	M	src/domain/projecttemplatequeries.cpp (36 lines)
A	M	src/domain/projecttemplaterepository.h (52 lines)
A	M	src/domain/projecttemplaterepository.cpp (36 lines)
M		src/presentation/CMakeLists.txt (1 line)
M		src/presentation/applicationmodel.h (1 line)
M		src/presentation/availablenotepagesmodel.h (6 lines)
M		src/presentation/availablenotepagesmodel.cpp (15 lines)
M		src/presentation/availablepagesmodelinterface.h (6 lines)
M		src/presentation/availabletaskpagesmodel.h (14 lines)
M		src/presentation/availabletaskpagesmodel.cpp (109 lines)
A	M	src/presentation/projectlistmodel.h (62 lines)
A	M	src/presentation/projectlistmodel.cpp (119 lines)
A	M	src/presentation/templatepagemodel.h (68 lines)
A	M	src/presentation/templatepagemodel.cpp (293 lines)
A	M	src/templatexml/CMakeLists.txt (15 lines)
A	M	src/templatexml/availableprojecttemplate.h (87 lines)
A	M	src/templatexml/availableprojecttemplate.cpp (136 lines)
A	M	src/templatexml/projecttemplatequeries.h (57 lines)
A	M	src/templatexml/projecttemplatequeries.cpp (62 lines)
M		src/widgets/CMakeLists.txt (6 lines)
M		src/widgets/availablepagesview.h (42 lines)
M		src/widgets/availablepagesview.cpp (93 lines)
A	M	src/widgets/newprojectfromtemplatedialog.h (71 lines)
A	M	src/widgets/newprojectfromtemplatedialog.cpp (86 lines)
A	M	src/widgets/newprojectfromtemplatedialog.ui (104 lines)
A	M	src/widgets/newprojectfromtemplatedialoginterface.h (55 lines)
A	M	src/widgets/newprojectfromtemplatedialoginterface.cpp (32 lines)
A	M	src/widgets/newtemplatedialog.h (71 lines)
A	M	src/widgets/newtemplatedialog.cpp (86 lines)
A	M	src/widgets/newtemplatedialog.ui (98 lines)
A	M	src/widgets/newtemplatedialoginterface.h (54 lines)
A	M	src/widgets/newtemplatedialoginterface.cpp (32 lines)
M		src/zanshin/app/CMakeLists.txt (1 line)
M		src/zanshin/app/dependencies.cpp (19 lines)
M		tests/CMakeLists.txt (2 lines)
M		tests/features/zanshin/features/step_definitions/CMakeLists.txt (1 line)
M		tests/units/presentation/applicationmodeltest.cpp (3 lines)
M		tests/units/presentation/availabletaskpagesmodeltest.cpp (75 lines)
M		tests/units/widgets/availablepagesviewtest.cpp (8 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	2992		Mar 29 2016, 7:40 AM	★	★
Diff 2	3678		May 6 2016, 3:03 PM	★	★
Diff 3	4294		Jun 8 2016, 3:36 PM	★	★

Generate new templateAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 4294

src/CMakeLists.txt

src/domain/CMakeLists.txt

src/domain/projecttemplate.h

src/domain/projecttemplate.cpp

src/domain/projecttemplatequeries.h

src/domain/projecttemplatequeries.cpp

src/domain/projecttemplaterepository.h

src/domain/projecttemplaterepository.cpp

src/presentation/CMakeLists.txt

src/presentation/applicationmodel.h

src/presentation/availablenotepagesmodel.h

src/presentation/availablenotepagesmodel.cpp

src/presentation/availablepagesmodelinterface.h

src/presentation/availabletaskpagesmodel.h

src/presentation/availabletaskpagesmodel.cpp

src/presentation/projectlistmodel.h

src/presentation/projectlistmodel.cpp

src/presentation/templatepagemodel.h

src/presentation/templatepagemodel.cpp

src/templatexml/CMakeLists.txt

src/templatexml/availableprojecttemplate.h

src/templatexml/availableprojecttemplate.cpp

src/templatexml/projecttemplatequeries.h

src/templatexml/projecttemplatequeries.cpp

src/widgets/CMakeLists.txt

src/widgets/availablepagesview.h

src/widgets/availablepagesview.cpp

src/widgets/newprojectfromtemplatedialog.h

src/widgets/newprojectfromtemplatedialog.cpp

src/widgets/newprojectfromtemplatedialog.ui

src/widgets/newprojectfromtemplatedialoginterface.h

src/widgets/newprojectfromtemplatedialoginterface.cpp

src/widgets/newtemplatedialog.h

src/widgets/newtemplatedialog.cpp

src/widgets/newtemplatedialog.ui

src/widgets/newtemplatedialoginterface.h

src/widgets/newtemplatedialoginterface.cpp

src/zanshin/app/CMakeLists.txt

src/zanshin/app/dependencies.cpp

tests/CMakeLists.txt

tests/features/zanshin/features/step_definitions/CMakeLists.txt

tests/units/presentation/applicationmodeltest.cpp

tests/units/presentation/availabletaskpagesmodeltest.cpp

tests/units/widgets/availablepagesviewtest.cpp

Generate new template
AbandonedPublic
Actions

Revision Contents
Changeset List