Load qm file
ClosedPublic

Authored by mlaurent on Apr 8 2016, 12:22 PM.

Details

Summary

As zanshin uses tr(...) macro we need to load qm file
So necessary to use specific macro

Test Plan

install fr language, (last version) with a zanshin_qt.qm

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent updated this revision to Diff 3216.Apr 8 2016, 12:22 PM
mlaurent retitled this revision from to Load qm file.
mlaurent updated this object.
mlaurent edited the test plan for this revision. (Show Details)
mlaurent added reviewers: ervin, bensi.
mlaurent set the repository for this revision to R4 Zanshin.
mlaurent added a project: Zanshin.
ervin requested changes to this revision.Apr 8 2016, 1:48 PM
ervin edited edge metadata.

I also assume you tested it works as expected both for the standalone applications and the kontact plugins? I'd be in fact slightly surprised if it works for the kontact plugin case,

src/renku/app/CMakeLists.txt
8

And then this line won't need changing anymore.

Please do that change for the other files as well.

13

Please move that line after the set(app_SRCS...) block and use app_SRCS as output variable for ecm_create_qm_loader.

This revision now requires changes to proceed.Apr 8 2016, 1:48 PM
mlaurent updated this revision to Diff 3229.Apr 9 2016, 5:08 AM
mlaurent edited edge metadata.
mlaurent removed R4 Zanshin as the repository for this revision.

Use app_SRCS variable directly.
I can't confirm that kontact translation work so I remove changes from the moment.

ervin accepted this revision.Apr 9 2016, 10:51 AM
ervin edited edge metadata.
This revision is now accepted and ready to land.Apr 9 2016, 10:51 AM
This revision was automatically updated to reflect the committed changes.