Yes i understand the scripts are shared between gitlab and jenkins and that lots of projects are not "very good" in keeping their tests clean, that's why i asked this to be opt-in for those projects that try to actually have passing tests :)

In D29826#674634, @aacid wrote:

oh i think i'm too late :D

oh i think i'm too late :D

It didn't really land on Qt 5.15 yet, so we may need to update the comment to say 5.15.1 or something

Potential solution, just drop CHM support https://tsdgeos.blogspot.com/2020/05/chmk-simple-chm-viewer.html

Personally I'm happy enough with this, i guess wait a few days and if noone disagrees, land it

Do you think we should mention something like

In D22488#673575, @poboiko wrote:

UPD: seems like it doesn't. I've added couple qDebug lines, to QIcon::fromTheme() method and near QIcon::setFallbackThemeName() with your patch, and then ran okular and dolphin.
By the time setFallbackThemeName() is called, almost all icons are already loaded :(

In D29826#673572, @poboiko wrote:

Thanks for looking into it! :)

In D29826#673543, @aacid wrote:

I don't think moving this code from KIconThemes to kmainwindow makes sense, what about all the apps that use KIconThemes but no KMainWindow?

I'm just not aware of any. I've looked at some of the most used (by me :]), noted that all of them use KMainWindow and thought it might be a good option.

Now i understand this is causing relatively several issues, sorry for dropping the ball, so we should probably fix for users before Qt 5.15.1

https://codereview.qt-project.org/c/qt/qtbase/+/301588

Not sure if you're subscribed to https://phabricator.kde.org/D22488 see my last comment there i think it's the way to go

Wouldn't it make more sense to fix in Qt?

I don't think moving this code from KIconThemes to kmainwindow makes sense, what about all the apps that use KIconThemes but no KMainWindow?