the patch is already applied to the "kube" branch of messagelib:
http://commits.kde.org/clones/messagelib/knauss/libotp/0a1801bb01599acce55a4d97e1fa65129075048a

patch for messagelib to only use QGpgme if version of gpgme >= 1.7.2

well the problem is that we want to release kube starting next year and we need messagelib for kube.
That's why I want messagelib ready with KDE/Applications 16.12.
But I can create a #ifdef to support boths versions. It is only one place where we use it, so not that much clutter.

In T4230#63020, @knauss wrote:

I like the approch, too. I also think it is not very obvious for any user, that you can change a setting in kleopatra that will affect kmail. But don't find this setting in kmail settings. We will see if anyone complains, about this missing feature.

Are there any releasetime for QGpgMe 1.7.2?

I like the approch, too. I also think it is not very obvious for any user, that you can change a setting in kleopatra that will affect kmail. But don't find this setting in kmail settings. We will see if anyone complains, about this missing feature.

libkleo patch as attachment.

To avoid having this on the stack and getting pushed down I just did it:

Without really knowing what Kleo::DN is; I like the approach aheinecke proposed. For Kube we don't care about kleopatras attribute order setting, and if we did we could easily apply it.
Being able to simply configure the library as a user of it is the right approach IMO.

I think the simple solution would be:

• Move Kleo::DN into QGpgME
• Add a Kleo::DN setAttributeOrder(const QStringList&)

Groundwork and a first working version was pushed to master now ( 8466330425f7dea442084b12cbbb0dd0073f7594 ). Now on to improve, fix it.

Some more changes are that the addressbook icon is gone now and the layouting will be a bit more ordered. The CertificateDialog now also allows multiple selection so that there should be no regression agains the old stuff.

To live with older GpgME versions the new automatic handling is only enabled if GpgME 1.7 is used. As a fallback and for older version the old wizard was left alone.

Commited to master with http://commits.kde.org/kleopatra/fe12ed2ac9061d75725289397525d005d5c03062

Emanuel: What do you think, you had objections imo that without the splashscreen the relation of Kleopatra to "Egypt and Sphinx" is not transported.

With attached patches this is how it looks like when a large keyring is feteched. Normally it should be quick enough not to be noticable but especially on Windows pubring access can be very slow (still <10s)

Current draft (Windows Screenshots)

I've tried this out a but. The Combo box with the line edit felt not good as it basically offers multiple places to select a certificate. To show the user that multiple files will be created when X509 and OpenPGP Certificates are selected and to make it possible to change the Output location I've moved the output file selection also in this dialog at the bottom.

Hurray, everything commited. And I think it's fairly clean. We still carry some patches in Gpg4win though to mess with the internal frameworks dependencies.

I've commited the Dialog with http://commits.kde.org/kleopatra/058406753a1e7ddd70b0388e1f0ce0186e613a69 bit ugly in that it has some copied code from KCMUtils but otherwise it is a good solution as we can keep the same code for the KCMs and acutually load the KCMs without requiring dbus.

I've created T2372 for me to keep a better, platform independent, solution in mind.

As an additional note: The "Remove unencrypted files after encryption" option will be removed. We do not want to have that option as this might cause critical data loss in case we fail to detect an error. The responsibility for removal should be with the user who might also want to use a dedicated removal tool that ensures that the plaintext is really removed from disk.

I've published some mockups and ideas part of: https://wiki.gnupg.org/KleopatraUi3

Pushed with: https://quickgit.kde.org/?p=kleopatra.git&a=commit&h=22719ea98c3f9b1f3d0d1703490c79398ce6243c

Pushed with: https://quickgit.kde.org/?p=kleopatra.git&a=commit&h=832d2c5676ea8d7f475887ad08e02e7b7da0743e

Looks good to me. Makes sense to interpret "Forced" as selected by default as we don't want to force the user to do anything.

I need to mention:

I've changed the GnuPGProcesscommand to expose the internal process so that it can be modified in a subclass.

Thanks for the Patch. Generally it's a bit much copy and paste in my opinion without questioning if the pasted code really makes sense for this. While we've talked about not basing it on Gnuprocesscommand I think some of that code is redundant and we should probably change gnupgprocesscommand that it's a useful base class for this. I'll take a look at it.