This adds a visual indication to show the direction of the copy/move..etc
operation pointing from source to destination.
See the screenshots.
BUG: 268600
dfaure | |
meven | |
ngraham |
Frameworks | |
Dolphin |
This adds a visual indication to show the direction of the copy/move..etc
operation pointing from source to destination.
See the screenshots.
BUG: 268600
No Linters Available |
No Unit Test Coverage |
Buildable 26160 | |
Build 26178: arc lint + arc unit |
I tried with Arabic, and the rename dialog had some Arabic text, but the layout was still LTR (can it switch to RTL?).
Maybe this helps for RTL?
https://doc.qt.io/qt-5.9/qtwidgets-tools-i18n-mainwindow-cpp.html
src/widgets/renamedialog.cpp | ||
---|---|---|
300 | If you figure out how to make it RTL aware, you could toggle between the go-next-symbolic and go-next-rtl-symbolic icons |
I meant it worked with Arabic, the direction was the same, just the text is translated, so the renamedialog and dolphin aren't RTL AFAICS.
src/widgets/renamedialog.cpp | ||
---|---|---|
142 | You don't need a member variable for this. |
src/widgets/renamedialog.cpp | ||
---|---|---|
142 | Indeed, it's only used in one place (too much copy/paste...). |
src/widgets/renamedialog.cpp | ||
---|---|---|
299 | this is not right-to-left aware; please use the layout direction of the widget to use "go-next" or "go-previous" |
src/widgets/renamedialog.cpp | ||
---|---|---|
299 | (go-next-rtl-symbolic, not go-previous; that would be semantically inaccurate.) |
src/widgets/renamedialog.cpp | ||
---|---|---|
299 | @pino, right; dolphin isn't rtl-aware (or if it is, I couldn't find out how to switch it to rtl). But I agree the code here should account for rtl anyway. @ngraham: I think we should stick to the icon naming spec[1], so that it works with themes other than breeze/oxygen; so it has to be go-previous. [1] https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html |
src/widgets/renamedialog.cpp | ||
---|---|---|
299 | dolphin --reverse |
src/widgets/renamedialog.cpp | ||
---|---|---|
299 |
$ dolphin --reverse it is provided directly by QApplication, it works also in Qt-only applications |
src/widgets/renamedialog.cpp | ||
---|---|---|
299 | you can use qApp->isRightToLeft() to check the rtl direction |
src/widgets/renamedialog.cpp | ||
---|---|---|
299 | The interface of Dolphin is RTL-aware, just the panels and the file view are not (for many usability reasons) |
Take RTL layout into consideration when setting the arrow icon by using
qApp->isRightToLeft()