Differential D21782

Add a warning dialog with details, continue, and cancel button
ClosedPublic
Actions

Authored by chinmoyr on Jun 13 2019, 4:05 PM.

Details

Reviewers
dfaure
ngraham
apol
Group Reviewers
VDG
Frameworks
Commits
R236:653192440bf8: Add a warning dialog with a collapsible details section.
Summary

Diff Detail

Repository
R236 KWidgetsAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13100
Build 13118: arc lint + arc unit
chinmoyr created this revision.Jun 13 2019, 4:05 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJun 13 2019, 4:05 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
chinmoyr requested review of this revision.Jun 13 2019, 4:05 PM
chinmoyr edited the summary of this revision. (Show Details)Jun 13 2019, 4:13 PM
ngraham added a subscriber: ngraham.Jun 13 2019, 6:35 PM
In D21782#479190, @GB_2 wrote:

I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/

+1, this seems like a perfect use of that widget in fact. Dolphin has an example in viewpropertiesdialog.cpp.

chinmoyr added a comment.Jun 13 2019, 6:39 PM
In D21782#479190, @GB_2 wrote:

I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/

Thanks! I'll give it a shot.

chinmoyr updated this revision to Diff 60264.Jun 21 2019, 5:12 PM

Updated the implementation.

ngraham accepted this revision.Jun 21 2019, 9:13 PM
This revision is now accepted and ready to land.Jun 21 2019, 9:13 PM
ngraham added a comment.Jul 11 2019, 1:43 PM

Can we get this in?

apol accepted this revision.Jul 11 2019, 6:38 PM
elvisangelaccio added a subscriber: elvisangelaccio.Jul 14 2019, 8:21 PM
elvisangelaccio added inline comments.
src/kmessagebox.h
329

Needs a bump to 5.61

chinmoyr edited the summary of this revision. (Show Details)Jul 19 2019, 8:42 AM
Closed by commit R236:653192440bf8: Add a warning dialog with a collapsible details section. (authored by chinmoyr). · Explain WhyJul 19 2019, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmessagebox.h (14 lines)
Msrc/kmessagebox.cpp (25 lines)

Diff 60264

View Options

src/kmessagebox.h

Loading...
View Options

src/kmessagebox.cpp

Loading...