Add a warning dialog with details, continue, and cancel button
ClosedPublic
Actions

Authored by chinmoyr on Jun 13 2019, 4:05 PM.

Details

Reviewers

dfaure
ngraham
apol

Group Reviewers

VDG
Frameworks

Commits

R236:653192440bf8: Add a warning dialog with a collapsible details section.

Summary

Diff Detail

Repository

R236 KWidgetsAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

chinmoyr created this revision.Jun 13 2019, 4:05 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJun 13 2019, 4:05 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

chinmoyr requested review of this revision.Jun 13 2019, 4:05 PM

Harbormaster completed remote builds in B12777: Diff 59735.Jun 13 2019, 4:05 PM

chinmoyr mentioned this in D21783: Show more details in warning dialog shown before starting a privileged operation.Jun 13 2019, 4:13 PM

chinmoyr edited the summary of this revision. (Show Details)Jun 13 2019, 4:13 PM

I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/

chinmoyr mentioned this in T8075: Fix security issues with KAuth support in KIO.Jun 13 2019, 6:21 PM

In D21782#479190, @GB_2 wrote:

I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/

+1, this seems like a perfect use of that widget in fact. Dolphin has an example in viewpropertiesdialog.cpp.

In D21782#479190, @GB_2 wrote:

I think a KCollapsibleGroupBox would fit here: http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/

Thanks! I'll give it a shot.

mreeves added a subscriber: mreeves.Jun 16 2019, 8:50 PM

Updated the implementation.

Harbormaster completed remote builds in B13100: Diff 60264.Jun 21 2019, 5:12 PM

ngraham accepted this revision.Jun 21 2019, 9:13 PM

This revision is now accepted and ready to land.Jun 21 2019, 9:13 PM

Can we get this in?

apol accepted this revision.Jul 11 2019, 6:38 PM

elvisangelaccio added a subscriber: elvisangelaccio.Jul 14 2019, 8:21 PM

elvisangelaccio added inline comments.

src/kmessagebox.h
329	Needs a bump to 5.61

chinmoyr edited the summary of this revision. (Show Details)Jul 19 2019, 8:42 AM

Closed by commit R236:653192440bf8: Add a warning dialog with a collapsible details section. (authored by chinmoyr). · Explain WhyJul 19 2019, 8:52 AM

This revision was automatically updated to reflect the committed changes.

chinmoyr mentioned this in R241:82aae02e2114: Show more details in warning dialog shown before starting a privileged operation.Dec 22 2019, 8:16 AM

Revision Contents
Changeset List

			Path	Packages
M			src/kmessagebox.h (14 lines)
M			src/kmessagebox.cpp (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	59735	d5cdd29		Jun 13 2019, 4:05 PM	★	★
Diff 2	60264	89606c1	Updated the implementation.	Jun 21 2019, 5:12 PM	★	★
Diff 3	62033	44f489f	R236:653192440bf8b5188b667a84010a61953b11348e	Jul 19 2019, 8:37 AM	★	★

Add a warning dialog with details, continue, and cancel buttonClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 62033

src/kmessagebox.h

src/kmessagebox.cpp

Add a warning dialog with details, continue, and cancel button
ClosedPublic
Actions

Revision Contents
Changeset List