Provides thumbnails for ODT, ODS, ODP, ODG, ODF files as well as their template counterparts
FEATURE: 375176
FIXED-IN: 18.12.0
ngraham | |
kossebau | |
jtamate | |
fvogt | |
wbauer |
Frameworks | |
VDG |
Provides thumbnails for ODT, ODS, ODP, ODG, ODF files as well as their template counterparts
FEATURE: 375176
FIXED-IN: 18.12.0
Some code I had written a while ago, not knowing there actually used to be an Open Document thumbnailer for kde4.
Lint Skipped |
Unit Tests Skipped |
I haven't tested it, therefore I ask: Does this thumbnailer ask for password for password protected files, like in https://bugs.kde.org/show_bug.cgi?id=394284 ?
Hmm, yeah, we need to make sure to not even try to generate thumbnails for password-protected files. Good catch, @jtamate
(Also, let's move that sweet MS Office document thumbnailer into kio-extras so everyone can benefit from it! https://bugs.kde.org/show_bug.cgi?id=398813)
Hmm, looks like Calligra already has code that does some of this: https://cgit.kde.org/calligra.git/tree/extras/thumbnail/calligracreator.cpp.
Ideally we would have the thumbnailer for these file formats in one place, here in kio-extras.
Adding @kossebau, who appears to have written the Calligra code, for the discussion regarding what should move where or be removed, as applicable.
Does this thumbnailer ask for password for password protected files,
No. I don't know how a password-protected document work but if it's encrypted like a ZIP file the file will just fail to open and generate, like you cannot open an encrypted file in zip:/ KIO, it's the same thing.
I just checked, LibreOffice doesn't even seem to generate a thumbnail picture for password-protected files, which is good.
, looks like Calligra already has code that does some of this
That's actually how I found out that those formats are so similar, there's a Krita thumbnailer in kio-extras already which was split from Calligra.
The Calligra thumnailer you liked actually uses KOffice classes and as such would add a huge dependency and cannot be put in here.
I'm trying to check if it works with password-protected files, but I can't install it.
The patch is missing opendocumentthumbnail.desktop.
I have a question: If you have calligra installed, which thumbnailer will do the work? This on, calligra or both, or depends on the last one being installed? Just for curiosity.
...that doesn't seem likely, that'd be like Plasma using Kicker classes from KDE3 times, which is the last time Calligra was called that ;)
and as such would add a huge dependency and cannot be put in here.
Agreed, it would be entirely nonsensical to do this. The thumbnails in the OpenDocument files are there specifically to make things like creating a thumbnailer like this both easy and (processing-wise) cheap :)
...that doesn't seem likely, that'd be like Plasma using Kicker classes from KDE3 times, which is the last time Calligra was called that ;)
I wanted to say Ko classes as that's what they're prefixed with but I didn't expect anyone to understand this, hence KOffice :)
The patch is missing opendocumentthumbnail.desktop.
Aw, crap, just noticed that I forgot to add it, will update the patch tomorrow.
Just FYI, as I was added, I currently have no time reserved for document related code work:
There is such a thumbnailer for OpenDocument Format document which exposes the preview/thumbnail picture from the data since ages on what now is store.kde.org, here my old bookmark:
https://www.opendesktop.org/p/1081271
IIRC it is packaged by a few, at least was for openSUSE.
The Calligra thumbnailer has an advantage over the simple thumbnail extracting one here: it actually understands the content of the file (when it comes to standard ODF) and can render to bigger previews, as much as needed, not just the max isze of the embedded thumbnail (IIRC 128x128 in the ODF specs). Or for OpenDocument Formats files which were generated with no preview/thumbnail added.
Sadly the KDE thumbnail system has no priority system, so more powerful thumbnailer if installed could overrule less powerful ones.
The Krita format spec has a preview picture in the full size IIRC, there scaling is no issue.