BUG: 389401
KIO model now provides Baloo URLs; we need to remove the old ones
created by Dolphin places model
BUG: 387888
Depends on D9332
mwolff | |
ngraham | |
elvisangelaccio |
Dolphin |
BUG: 389401
KIO model now provides Baloo URLs; we need to remove the old ones
created by Dolphin places model
BUG: 387888
Depends on D9332
unit test
Lint Skipped |
Unit Tests Skipped |
src/panels/places/placesitemmodel.h | ||
---|---|---|
171 | is -> are |
Looks fine to me, but I'm not a Dolphin expert so I'll let someone else more knowledgeable accept it.
src/panels/places/placesitemmodel.cpp | ||
---|---|---|
56 | Please fix this comment, it's a leftover of da6f8fe086 but now it doesn't make sense to start the sentence with "Hence". While at it, let's make AppNamePrefix a QStringLiteral ? | |
174 | please remove the space before the ++ |
src/panels/places/placesitemmodel.cpp | ||
---|---|---|
58–59 | hmm why not const QString AppNamePrefix = QStringLiteral("-places-panel"); ? |
src/panels/places/placesitemmodel.cpp | ||
---|---|---|
58–59 | One last nitpick: this is actually a suffix, so while at it I'd rename it AppNameSuffix |