Remove duplicate code.
Use static_cast when we don't test result from dynamic_cast
Remove unused variable
Depends on D8450
ervin | |
dfaure |
Frameworks |
Remove duplicate code.
Use static_cast when we don't test result from dynamic_cast
Remove unused variable
Depends on D8450
compile/test
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
src/filewidgets/kfileplacesview.cpp | ||
---|---|---|
66 | re-indent after the removal of "virtual" | |
68 | same here, please re-indent after the removal of "virtual" | |
737 | You use qobject_cast elsewhere, why not here too? Or even... you use static_cast for the delegate in 90% of the code, why two uses of qobject_cast? If it's mandatory for the delegate to be a KFilePlacesViewDelegate, it's mandatory everywhere, right? (too bad setItemDelegate isn't virtual, we could have caught it there...) |