Differential D9241

Emit 'groupHiddenChanged' signal.
ClosedPublic
Actions

Authored by renatoo on Dec 7 2017, 2:27 PM.

Details

Reviewers
franckarrecot
mwolff
mlaurent
Commits
R241:f1185dc10acf: Emit 'groupHiddenChanged' signal.
Summary

Emit 'groupHiddenChanged' when group hidden value change

Depends on D8450

Test Plan

Unit test created

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
renatoo created this revision.Dec 7 2017, 2:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 7 2017, 2:27 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
renatoo requested review of this revision.Dec 7 2017, 2:27 PM
mwolff accepted this revision.Dec 7 2017, 2:57 PM
mwolff added a subscriber: mwolff.
mwolff added inline comments.
autotests/kfileplacesmodeltest.cpp
1215

static_cast<int>() would be preferred, also below

This revision is now accepted and ready to land.Dec 7 2017, 2:57 PM
renatoo updated this revision to Diff 23617.Dec 7 2017, 3:08 PM

used static_cast<int>() for cast enums

renatoo marked an inline comment as done.Dec 7 2017, 3:08 PM
mlaurent accepted this revision.Dec 8 2017, 8:47 AM
mwolff accepted this revision.Dec 8 2017, 12:30 PM
Closed by commit R241:f1185dc10acf: Emit 'groupHiddenChanged' signal. (authored by Renato Araujo Oliveira Filho <renato.araujo@kdab.com>). · Explain WhyDec 8 2017, 12:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 23639

View Options

autotests/kfileplacesmodeltest.cpp

Loading...
View Options

src/filewidgets/kfileplacesmodel.h

Loading...
View Options

src/filewidgets/kfileplacesmodel.cpp

Loading...