Differential D8566

Add API to retrieve the screen id for a screen name
ClosedPublic
Actions

Authored by amantia on Oct 31 2017, 10:59 AM.

Details

Reviewers
ervin
dvratil
mlaurent
hein
davidedmundson
Group Reviewers
Plasma
Commits
R242:eab03787350a: Add signals indicating if a screen was added or removed
Summary

This is needed to implement https://phabricator.kde.org/D8493 , so applets can react to screen removal/addition and can make a relation between the changed screen and the screen id as stored by plasma.
The shellcorona implementation is in https://phabricator.kde.org/D8567

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
amantia created this revision.Oct 31 2017, 10:59 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 31 2017, 10:59 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
apol added a subscriber: apol.Oct 31 2017, 11:01 AM

Needs context?

amantia added a comment.Oct 31 2017, 11:02 AM

I will add, please be patient as there are 3 related commits :)

amantia edited the summary of this revision. (Show Details)Oct 31 2017, 11:09 AM
amantia added reviewers: Plasma, ervin, dvratil, mlaurent, hein.
ervin requested changes to this revision.Oct 31 2017, 2:09 PM
ervin added inline comments.
src/plasma/corona.h
223 ↗(On Diff #21617)

"if there is no such screen" I guess?

This revision now requires changes to proceed.Oct 31 2017, 2:09 PM
dhaumann added a subscriber: dhaumann.Nov 1 2017, 6:41 AM
dhaumann added inline comments.
src/plasma/corona.h
223 ↗(On Diff #21617)

And it is @return and not @returns.

amantia updated this revision to Diff 21679.Nov 1 2017, 8:41 AM

Fix API docs text

Restricted Application added a project: Plasma. · View Herald TranscriptNov 1 2017, 8:41 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Nov 1 2017, 9:21 AM

This class is exported, you cannot add a new virtual to it.

amantia added a comment.Nov 1 2017, 9:40 AM

@broulik Very good point, luckily I reworked it.

amantia updated this revision to Diff 21682.Nov 1 2017, 9:41 AM

Add signals instead of a new virtual method (that is not BIC). This also makes us not rely on screen name, but only on plasma-internal screen id.

davidedmundson accepted this revision.Nov 1 2017, 10:58 AM
ervin accepted this revision.Nov 2 2017, 12:06 PM
This revision is now accepted and ready to land.Nov 2 2017, 12:06 PM
Closed by commit R242:eab03787350a: Add signals indicating if a screen was added or removed (authored by amantia). · Explain WhyNov 14 2017, 1:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasma/corona.h (8 lines)
Msrc/plasma/corona.cpp (5 lines)

Diff 21679

View Options

src/plasma/corona.h

Loading...
View Options

src/plasma/corona.cpp

Loading...