This is the implementation of the new Plasma Corona API, as described in https://phabricator.kde.org/D8566
Details
Details
- Reviewers
ervin dvratil mlaurent hein davidedmundson - Group Reviewers
Plasma - Commits
- R120:9ab72a14a70d: Emit signals when a screen is added or removed
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
The only intended use is folderview, and there are some comments there about whether that's the right approach.
I don't want to have this pushed before we agree on that.
Other than that, code is fine.
Comment Actions
This is specially interesting and it would be important to make it right.
One of the features we lose in Wayland is that we know where to place each component. because of this number being 0 the primary screen, where the important components go. In Wayland there's not a concept of a primary screen and using multiscreen there is basically gambling. One thing we discussed with @mart at some point is to use the screen name to identify the configuration.
That's another use-case for the API.
That said, I think that it would be just better to slowly deprecate the integer id.
Comment Actions
Emit the screenRemoved/screenAdded signals. This needs a small rename of an internal method.
| shell/shellcorona.cpp | ||
|---|---|---|
| 1163 | shouldn't this be done from within removeDesktop? considering this duplicates the change above? | |
| shell/shellcorona.cpp | ||
|---|---|---|
| 1161 | now you can undo this hunk | |