Adds Bitrate to Dolphin's Additional information columns.
BUG: 368418
Details
Details
- Reviewers
broulik dfaure emmanuelp aacid - Group Reviewers
Dolphin KDE Applications - Commits
- R318:76698ff82cf5: Add Bitrate to Dolphin's Additional Information
Tested in KDE Neon. A bitrate column can be added and shows the bitrate in kb/s:
Works for audio as well as video files!
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/kitemviews/private/kbaloorolesprovider.cpp | ||
|---|---|---|
| 203 | It should be float(value) / 1000 or you will not get a float but an int. | |
| src/kitemviews/private/kbaloorolesprovider.cpp | ||
|---|---|---|
| 204 | Should this string (" kB/s") also be translated or not? :) | |
| src/kitemviews/private/kbaloorolesprovider.cpp | ||
|---|---|---|
| 204 | Please make use of KFormat as done in https://github.com/KDE/baloo-widgets/blob/master/src/widgetfactory.cpp#L125. | |
Comment Actions
Used the appropriate metricated and internationalized bitrate converter. Thanks, @emmanuelp and @alexeymin!
Comment Actions
I don't have time to test now, but i understand you rebased it so if it's good it's good :)
Comment Actions
Nnnope, patch fails to apply for me, on current dolphin master. 😆 https://paste.kde.org/ppx1r8xxl
Comment Actions
Diff 19425 and Diff 19660 are identical (save for a whitespace change). Maybe the wrong patch was uploaded?
I can only recommend investing a couple of minutes in setting up arc, as it will track and restore the base revisions for uploader as well as reviewer (let me know if you need help with that).