emmanuelp (Emmanuel Pescosta)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 30 2016, 6:25 AM (155 w, 1 d)
Availability
Available

Recent Activity

Jun 11 2019

emmanuelp added a comment to D17595: Upstream Dolphin's file rename dialog.

I guess we need now to reach to schwarzerf@gmail.com romaninflianskas mfuchs chinmoyr mitchell emateli emmanuelp freininghaus to have lgplv2+ approval.

Jun 11 2019, 12:04 PM · Frameworks
emmanuelp committed R230:e1dc8b07716e: Add myself (emmanuelp) to relicensecheck.pl (authored by emmanuelp).
Add myself (emmanuelp) to relicensecheck.pl
Jun 11 2019, 11:51 AM

Dec 4 2017

emmanuelp added a comment to D9094: Use a faster way to determine kio-stash isn't installed.

You shouldn't depend on the implementation details of ioslaves. KIO has a well-defined interface to determine if an protocol can be handled.
And if the implementation of this interface is not good enough, then it needs to be improved (e.g. decrease number of file system look-ups, better cache invalidation, ...).

Dec 4 2017, 7:34 PM

Oct 14 2017

emmanuelp added inline comments to D8273: Change window title when searching.
Oct 14 2017, 11:34 AM · Dolphin

Sep 21 2017

emmanuelp committed R318:3749b5552729: Select child folder when navigating to a parent folder (authored by gregormi).
Select child folder when navigating to a parent folder
Sep 21 2017, 2:10 PM
emmanuelp added a comment to D7914: Select and scroll to previous folder when going Up.

A better fix is https://git.reviewboard.kde.org/r/123253/

Sep 21 2017, 1:35 PM · Dolphin

Sep 15 2017

emmanuelp accepted D6312: Keep renamed file(s) in view.
Sep 15 2017, 6:26 PM · Dolphin

Sep 12 2017

emmanuelp accepted D7783: Create KToolTipWidget on demand.
Sep 12 2017, 3:13 PM
emmanuelp added inline comments to D7700: Show list of tags in PlacesView.
Sep 12 2017, 11:37 AM · Frameworks, Dolphin
emmanuelp added a comment to D7700: Show list of tags in PlacesView.

What do you think would be a reasonable number of tags? 5, 10, 20, ..? Make it configurable?

Sep 12 2017, 11:08 AM · Frameworks, Dolphin
emmanuelp accepted D7776: Add "Release Year" column to Dolphin's Details view.
Sep 12 2017, 10:58 AM

Sep 11 2017

emmanuelp accepted D7763: Add Bitrate to Dolphin's Additional Information.

(I'll commit your patches in the evening)

Sep 11 2017, 2:46 PM · Dolphin
emmanuelp added a comment to D7700: Show list of tags in PlacesView.

Thanks for the patch!

Sep 11 2017, 2:26 PM · Frameworks, Dolphin
emmanuelp accepted D7690: Add "Open in New Window to Dolphin's places context menu.

@emmanuelp Does this look commitable now?

Sep 11 2017, 2:19 PM · Dolphin
emmanuelp requested changes to D7763: Add Bitrate to Dolphin's Additional Information.
Sep 11 2017, 2:16 PM · Dolphin
emmanuelp requested changes to D7696: Add "Width" and "Height" separately to Additional Information -> Images.
Sep 11 2017, 2:05 PM · Dolphin
emmanuelp updated subscribers of D7440: Turn on Dolphin icon previews by default.

-1 Urgh. Can we perhaps have a static QStringList KIO::PreviewJob::defaultPlugins()? It's not just Dolphin that has a copy of this (file dialog et al). And this way we could have flip it around to whitelist all plugins (find them through KService) and then have a user blacklist and perhaps by default blacklist stupid thumbnailers like "plain text".

Sep 11 2017, 2:04 PM · Dolphin
emmanuelp accepted D7655: Make sure we always have Shift+Del as shortcut.
  1. This patch.
Sep 11 2017, 1:58 PM

Sep 6 2017

emmanuelp added a comment to D7571: Enable modifying root-owned files in Dolphin.

An application copying some config file in the background (or any other internal file operation) shouldn't bother the user with prompts.

Sep 6 2017, 9:55 PM · Dolphin
emmanuelp requested changes to D7690: Add "Open in New Window to Dolphin's places context menu.
Sep 6 2017, 9:18 PM · Dolphin
emmanuelp added a comment to D7655: Make sure we always have Shift+Del as shortcut.

Hmm I don't think that we should add additional shortcuts to user-defined shortcuts. What if the user assigned {Shift, Del} to something different?

Sep 6 2017, 9:14 PM
emmanuelp accepted D7519: Fix DolphinRemoveAction Shift toggling on Wayland.

Some nitpicks, looks good otherwise!

Sep 6 2017, 9:09 PM

Sep 3 2017

emmanuelp added inline comments to D7571: Enable modifying root-owned files in Dolphin.
Sep 3 2017, 9:45 AM · Dolphin

Sep 1 2017

emmanuelp committed R318:94fab8c80ed6: Limit folder panel to home directory if inside home (authored by hoffmannrobert).
Limit folder panel to home directory if inside home
Sep 1 2017, 8:16 AM
emmanuelp closed D7477: Limit folder panel to home directory if inside home by committing R318:94fab8c80ed6: Limit folder panel to home directory if inside home (authored by hoffmannrobert).
Sep 1 2017, 8:16 AM
emmanuelp accepted D7477: Limit folder panel to home directory if inside home.

Nice work! Thanks!

Sep 1 2017, 7:15 AM

Aug 31 2017

emmanuelp added inline comments to D7477: Limit folder panel to home directory if inside home.
Aug 31 2017, 8:08 PM
emmanuelp requested changes to D7477: Limit folder panel to home directory if inside home.

Last round

Aug 31 2017, 8:43 AM

Aug 30 2017

emmanuelp added inline comments to D7477: Limit folder panel to home directory if inside home.
Aug 30 2017, 4:45 PM

Aug 29 2017

emmanuelp added inline comments to D7477: Limit folder panel to home directory if inside home.
Aug 29 2017, 6:16 PM
emmanuelp requested changes to D7477: Limit folder panel to home directory if inside home.

Nice work! :)

Aug 29 2017, 5:43 PM

Aug 25 2017

emmanuelp accepted D7215: Add Genre to additional information for audio files. Fixes T5599.

LGTM!

Aug 25 2017, 6:13 PM
emmanuelp accepted D4826: Prefer place name over actual name in title bar.

Nice work!

Aug 25 2017, 6:09 PM
emmanuelp added a comment to D7390: Support middle clicking of Back/Forward/Up/Home toolbar buttons.

Nice addition :)

Aug 25 2017, 6:03 PM

Jun 20 2017

emmanuelp accepted D6269: Support "Deletion Date" role in Trash.
  • Adjust timeRoleGroups so it takes a lambda where we can then return the proper timestamp (either from KFileItem or a role)
Jun 20 2017, 9:31 AM
emmanuelp added a comment to D6269: Support "Deletion Date" role in Trash.

Special handling of DeletionDateRole is missing in:

  • KFileItemModel::sortRoleCompare (see ModificationTimeRole for an example)
  • KFileItemModel::groups -> requires that timeRoleGroups() uses the sort role instead of KFileItem::FileTimes
Jun 20 2017, 9:13 AM
emmanuelp accepted D6243: Add role for file creation time..
Jun 20 2017, 8:55 AM
emmanuelp requested changes to D6269: Support "Deletion Date" role in Trash.
In D6269#117553, @cfeck wrote:

If trash KIO is already inconsistent we can indeed pick being inconsistent with either it or with the rest of Dolphin.

But I am concerned about the UI string.

Jun 20 2017, 8:52 AM

Mar 30 2017

emmanuelp accepted D5248: Update name of the delete action in the .rc files.

Oh thanks! Totally missed it during review :/

Mar 30 2017, 4:38 PM
emmanuelp added a comment to D4134: Take into account protocol class when determining whether it's a local file for preview.

Given PreviewJob now does the "right thing" by default, I think we can discard this.

Mar 30 2017, 4:36 PM

Mar 23 2017

emmanuelp added a comment to D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD.
In D5138#97024, @adridg wrote:

So, Linux, sort out your *stat(2) interfaces first and we'll get back to you.

Mar 23 2017, 11:48 AM · Frameworks

Mar 14 2017

emmanuelp accepted D5035: make services GHNS work with store.kde.org.

Thanks!

Mar 14 2017, 11:09 AM
emmanuelp added inline comments to D5035: make services GHNS work with store.kde.org.
Mar 14 2017, 10:52 AM

Mar 13 2017

emmanuelp renamed T5599: [Junior Job] Add 'Genre' to additional information from Add 'Genre' to additional information to [Junior Job] Add 'Genre' to additional information.
Mar 13 2017, 3:31 PM · Dolphin
emmanuelp created T5599: [Junior Job] Add 'Genre' to additional information.
Mar 13 2017, 3:28 PM · Dolphin
emmanuelp added inline comments to D4826: Prefer place name over actual name in title bar.
Mar 13 2017, 3:22 PM
emmanuelp accepted D5010: Port to KStandardAction::DeleteFile.
Mar 13 2017, 3:20 PM

Mar 8 2017

emmanuelp accepted D4823: Pass application name and icon to KRun.
Mar 8 2017, 1:42 PM
emmanuelp accepted D4978: Honor KFileItem isHidden() in view.

Nice!

Mar 8 2017, 1:38 PM
emmanuelp added inline comments to D4823: Pass application name and icon to KRun.
Mar 8 2017, 1:37 PM
emmanuelp requested changes to D4978: Honor KFileItem isHidden() in view.
Mar 8 2017, 1:27 PM

Mar 7 2017

emmanuelp requested changes to D4823: Pass application name and icon to KRun.

Nice work! :)

Mar 7 2017, 1:18 PM

Mar 5 2017

emmanuelp requested changes to D4826: Prefer place name over actual name in title bar.

Nice feature :)

Mar 5 2017, 3:22 PM
emmanuelp accepted D4873: Show pointing hand cursor when hovering spaceinfo bar.

Nice, thanks!

Mar 5 2017, 2:57 PM
emmanuelp added a comment to D4823: Pass application name and icon to KRun.

Can you please add a new function to global.h which encapsulates all this?
Maybe "Dolphin::openNewWindow(urls, flags = None)"

Mar 5 2017, 2:56 PM
emmanuelp requested changes to D4873: Show pointing hand cursor when hovering spaceinfo bar.
Mar 5 2017, 2:33 PM

Feb 23 2017

This is a test notification, sent at Thu, Feb 23, 16:04.
Feb 23 2017, 3:04 PM
emmanuelp accepted D4560: Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart.

Do you have commit access?

Feb 23 2017, 3:02 PM

Feb 22 2017

emmanuelp added a comment to D4560: Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart.

I guess, yeah 300 ms and InOutQuart would look good to me too.

Feb 22 2017, 4:22 PM

Feb 19 2017

emmanuelp committed R318:0bdd8e0b0516: Disallow executing Dolphin as root on Linux (authored by emmanuelp).
Disallow executing Dolphin as root on Linux
Feb 19 2017, 1:41 AM
emmanuelp created T5408: Integrate KBookmarks (incl. bookmarks editor) into Dolphin.
Feb 19 2017, 12:41 AM · Dolphin
emmanuelp added a watcher for Dolphin: emmanuelp.
Feb 19 2017, 12:09 AM

Feb 18 2017

emmanuelp updated subscribers of D4560: Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart.
Feb 18 2017, 11:53 PM
emmanuelp added a comment to D4560: Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart.

Thanks for the patch!

Feb 18 2017, 11:51 PM
emmanuelp committed R318:bdd336512226: Add a gitignore file (authored by donnguyen).
Add a gitignore file
Feb 18 2017, 10:06 PM
emmanuelp committed R318:bea831da5242: Added .kdev4 to gitignore (authored by emmanuelp).
Added .kdev4 to gitignore
Feb 18 2017, 10:06 PM
emmanuelp committed R318:edf8e5737316: Make "show filter bar" a toggle action (authored by donnguyen).
Make "show filter bar" a toggle action
Feb 18 2017, 10:06 PM
emmanuelp committed R318:db3f3746798a: Apply the file preview shadow frame to most previews instead of only image file… (authored by Diego Soenens <hyperz.2007@gmail.com>).
Apply the file preview shadow frame to most previews instead of only image file…
Feb 18 2017, 9:44 PM
emmanuelp committed R318:6b727613db73: Remove the preserving of the selected items in reload(), this is already… (authored by emmanuelp).
Remove the preserving of the selected items in reload(), this is already…
Feb 18 2017, 9:06 PM
emmanuelp committed R318:41b0e4297313: Restore the view state after the URL of the DolphinView has been changed, as… (authored by emmanuelp).
Restore the view state after the URL of the DolphinView has been changed, as…
Feb 18 2017, 9:06 PM
emmanuelp committed R318:1d0b6ba65ff6: Start an anchored selection when restoring the selected items to make it… (authored by emmanuelp).
Start an anchored selection when restoring the selected items to make it…
Feb 18 2017, 9:06 PM
emmanuelp committed R318:8bc6d09c57eb: Preserve selected items when changing folders (authored by emmanuelp).
Preserve selected items when changing folders
Feb 18 2017, 9:06 PM

Feb 11 2017

emmanuelp accepted D4553: [KStandardItemListWidget] Support QIcon from path in addition to fromTheme.
Feb 11 2017, 11:15 AM

Feb 8 2017

emmanuelp accepted D4502: [Settings Dialog] Show Trash settings only if authorized.

Nice!

Feb 8 2017, 2:33 PM
emmanuelp accepted D4501: Close tab on mouse release rather than on mouse press.

Thanks for the adjustments, looks good!

Feb 8 2017, 2:29 PM
emmanuelp accepted D4451: Rename FileMetaDataToolTip to DolphinFileMetaDataWidget.
Feb 8 2017, 12:29 PM
emmanuelp accepted D4498: Cleanup Places Panel context menus.
Feb 8 2017, 12:28 PM

Feb 5 2017

emmanuelp accepted D3937: [KStandardItemListWidget] Update icon when palette changes.

Looks good otherwise!

Feb 5 2017, 7:49 PM
emmanuelp accepted D4449: Port tooltips to KToolTipWidget.

Nice, thanks!

Feb 5 2017, 7:47 PM · Dolphin
emmanuelp added a comment to D4134: Take into account protocol class when determining whether it's a local file for preview.

I'm wondering if we should make this the default in PreviewJob

Feb 5 2017, 7:45 PM
emmanuelp accepted D4438: Remove deprecated K_EXPORT_PLUGIN macros.
Feb 5 2017, 7:43 PM

Jan 31 2017

emmanuelp accepted D4372: Hide progress info for rename jobs in rename dialog.

Ah ok submitting my previous comment fixed it (don't know what happened) :)

Jan 31 2017, 6:03 PM
emmanuelp added a comment to D4372: Hide progress info for rename jobs in rename dialog.

The diff is somehow corrupted ...

Jan 31 2017, 6:01 PM

Jan 14 2017

emmanuelp accepted D4078: Dolphin: Show full path in title bar.
Jan 14 2017, 11:59 AM
emmanuelp added a comment to D3937: [KStandardItemListWidget] Update icon when palette changes.

I see some potential problems with the QPalette key approach. The key only covers some parts of the palette, so it is not really future proof when colors different than text, highlight or highlighted text are used in future. It also requires more memory because the cache still holds old unused pixmaps (only true if number of used pixmaps doesn't exceed the cache limit). Also the keys are much longer which requires more work when generating and hashing the keys.

Jan 14 2017, 11:18 AM
emmanuelp accepted D3935: In doubt use URL scheme for place.
Jan 14 2017, 11:08 AM
emmanuelp added a member for Dolphin: emmanuelp.
Jan 14 2017, 11:06 AM
emmanuelp added inline comments to D4078: Dolphin: Show full path in title bar.
Jan 14 2017, 11:05 AM

Jan 12 2017

emmanuelp accepted D3972: Add document title to additional information.
Jan 12 2017, 7:08 AM
emmanuelp added a comment to D3937: [KStandardItemListWidget] Update icon when palette changes.

Wouldn't it be easier if you just clear the pixmap cache on palette change? e.g. in MainWindow?
A palette change basically invalidates all cached icons, so I don't see any advantage in adding the palette information to the key (... use cases like frequently toggling between two palettes are not supported).

Jan 12 2017, 7:07 AM

Jan 1 2017

emmanuelp accepted D3896: Explicitly pass iconNameForUrl when creating new places entry.
Jan 1 2017, 6:17 PM
emmanuelp accepted D3909: [DolphinView] Update view palette on palette change.
Jan 1 2017, 6:16 PM