User Details
- User Since
- Sep 30 2016, 6:25 AM (394 w, 4 d)
- Availability
- Available
Jun 11 2019
Dec 4 2017
You shouldn't depend on the implementation details of ioslaves. KIO has a well-defined interface to determine if an protocol can be handled.
And if the implementation of this interface is not good enough, then it needs to be improved (e.g. decrease number of file system look-ups, better cache invalidation, ...).
Oct 14 2017
Sep 21 2017
A better fix is https://git.reviewboard.kde.org/r/123253/
Sep 15 2017
Sep 12 2017
Sep 11 2017
(I'll commit your patches in the evening)
Thanks for the patch!
Sep 6 2017
Hmm I don't think that we should add additional shortcuts to user-defined shortcuts. What if the user assigned {Shift, Del} to something different?
Some nitpicks, looks good otherwise!
Sep 3 2017
Sep 1 2017
Nice work! Thanks!
Aug 31 2017
Last round
Aug 30 2017
Aug 29 2017
Nice work! :)
Aug 25 2017
LGTM!
Nice work!
Nice addition :)
Jun 20 2017
Special handling of DeletionDateRole is missing in:
- KFileItemModel::sortRoleCompare (see ModificationTimeRole for an example)
- KFileItemModel::groups -> requires that timeRoleGroups() uses the sort role instead of KFileItem::FileTimes
Mar 30 2017
Oh thanks! Totally missed it during review :/
Mar 23 2017
Mar 14 2017
Mar 13 2017
Mar 8 2017
Mar 7 2017
Nice work! :)
Mar 5 2017
Nice feature :)
Nice, thanks!
Can you please add a new function to global.h which encapsulates all this?
Maybe "Dolphin::openNewWindow(urls, flags = None)"
Feb 23 2017
Do you have commit access?
Feb 22 2017
Feb 19 2017
Feb 18 2017
Thanks for the patch!
Feb 11 2017
Feb 8 2017
Nice!
Thanks for the adjustments, looks good!
Feb 5 2017
Looks good otherwise!
Nice, thanks!
I'm wondering if we should make this the default in PreviewJob
Jan 31 2017
Ah ok submitting my previous comment fixed it (don't know what happened) :)
The diff is somehow corrupted ...
Jan 14 2017
I see some potential problems with the QPalette key approach. The key only covers some parts of the palette, so it is not really future proof when colors different than text, highlight or highlighted text are used in future. It also requires more memory because the cache still holds old unused pixmaps (only true if number of used pixmaps doesn't exceed the cache limit). Also the keys are much longer which requires more work when generating and hashing the keys.
Jan 12 2017
Wouldn't it be easier if you just clear the pixmap cache on palette change? e.g. in MainWindow?
A palette change basically invalidates all cached icons, so I don't see any advantage in adding the palette information to the key (... use cases like frequently toggling between two palettes are not supported).