Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

Authored by dfaure on Jul 7 2017, 1:48 PM.



This is what other webbrowsers like Firefox and Chrome do,
and is certainly much more international than Ctrl+Comma/Ctrl+Dot which
is very qwerty centric.

Test Plan

Switching tabs in Konqueror

Diff Detail

R237 KConfig
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Jul 7 2017, 1:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 7 2017, 1:48 PM
apol added a subscriber: apol.Jul 7 2017, 3:32 PM

+1, this has annoyed me in the past.

Just to be sure, does it touch all applications which uses tabs (like Okular)?

apol added a comment.Jul 7 2017, 3:43 PM

Just to be sure, does it touch all applications which uses tabs (like Okular)?

Yes, unless Okular is not using the standard action.

mdawson edited edge metadata.Jul 7 2017, 5:47 PM

+1 LGTM. Before submitting, can you poke the usability people about this change please? If they are also happy, then it's got a ship it from me.

aacid added a subscriber: aacid.Jul 8 2017, 11:08 AM

-1 don't see why we should change established shortcuts people have learnt to use.

Don't we have support for infinite shortcuts? Why not just add those that you find important?

QKeySequence supports more, just not this data table.

I can look into extending that of course, if we want to be conservative about this.

dfaure updated this revision to Diff 16335.Jul 8 2017, 11:29 AM

Preserve existing shortcuts

cfeck added a subscriber: cfeck.Jul 8 2017, 11:43 AM

I am not sure if the shortcut editor allows editing the third shortcut. If the user had assigned these to other actions, she needs a way to resolve the conflicts.

Damn, you're right, the third alternate isn't editable.

Making the shortcuts dialog more complex for this corner case doesn't sound like a good solution either...

I'm considering going back to the previous approach, users of Ctrl comma/dot will have to either switch to [ / ] or PgUp/PgDown, or reconfigure shortcuts.

This revision was automatically updated to reflect the committed changes.

FYI this has caused a conflict in Kate:

Also, I have created a patch to add the new shortcuts to Konsole, which does not use KStandardShortcuts: