If we parsed the service type from a qrc file (like kpackagetool does)
then it's wrong to later on say we can't find the file defining that
service type.
Details
Details
make uninstall in kpackage, then
XDG_DATA_DIRS=$KDEDIR/share <builddir>/bin/kpackagetool5 --appstream-metainfo . --appstream-metainfo-output /tmp/a.xml
Used to say: Unable to find service type for service "KPackage/Generic" listed in "./metadata.desktop"
even though it parsed ":/kservicetypes5/kpackage-generic.desktop" before.
For this we need to extract and store the name of the service type we're
parsing (key "X-KDE-ServiceType").
Diff Detail
Diff Detail
- Repository
- R244 KCoreAddons
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11123 Build 11141: arc lint + arc unit
Comment Actions
It looks good to me, but i'm not sure i know enough about this code to give you an approved, but if noone else does, let's assume i did :D
src/lib/plugin/desktopfileparser.cpp | ||
---|---|---|
402–403 | Where def is deleted? |
src/lib/plugin/desktopfileparser.cpp | ||
---|---|---|
402–403 | It's owned by the QCache. |