Use Title Case for the Copy to Clipboard button. In this case, it means making the word "to" lowercase.
Details
- Reviewers
broulik cfeck lueck - Group Reviewers
Spectacle KDE Applications Localization - Commits
- R166:3d30e3d03ae0: Use title case for the clipboard button
Compile, deploy, open Spectacle, look at button title and docbook
Diff Detail
- Repository
- R166 Spectacle
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Question for the localization folks: can I change this string in the stable branch? It's just a capitalization change to one letter. Is the policy "no string changes on the stable branch no matter what", or is there some flexibility there?
It is possible to ask and if nobody objects for a few days commit to the stable branch.
No objections from Ukrainian team.
There is the string freeze in stable branches.
It's just a capitalization change to one letter.
IMHO breaking the string freeze and forcing translators to edit a string for a very minor style change is not a good idea. This kind of i18n style fixes is usually done in master branches only. Others may think differently though.
So I guess that's my question: is the freeze a total freeze, or does changing capitalization not count? If changing capitalization violates the string freeze, I'm more than happy to re-base this on master instead of the stable branch.
The freeze is usually "lifted" in case a fix really needs to also change strings/messages, because that is something that cannot be avoided otherwise.
If changing capitalization violates the string freeze,
It definitely does. This change does not fix any bug, and the not-that-perfect style of the original string does not affect transitions.
For the fix itself: you do not need a diff review for this kind of changes, especially for master branches that were recently opened again for development...
OK, no problem. :) I just like to do my work in public. I'll take your comment to mean acceptance and land the patch!
You neet to understand that if you change the capitalization, the string changes, and all translations "disappear", so your "small tweak" suddenly untranslates the string for every single language, so really not a good idea to do it on a stable branch.